Bug #43327 for Sendmail-PMilter: Milter protocol version update needed

Mon Feb 16 02:12:44 2009 guthrie [...] counterexample.org - Ticket created

CC:	guthrie [...] counterexample.org
Subject:	Milter protocol version update needed
Date:	Mon, 16 Feb 2009 02:12:20 -0500
To:	bug-Sendmail-PMilter [...] rt.cpan.org
From:	"John T. Guthrie III" <guthrie [...] counterexample.org>

Hello all, I am currently using Sendmail-PMilter-0.96 on Fedora 9 and Fedora 10. The sendmail version in both cases is 8.14. It seems that when sendmail connects to the milter, it sends a milter protocol version of 6. Sendmail::PMilter::Context seems to only accept a protocol version of 2. (See line 273 of Context.pm.) It seems to me that this restriction is going to keep Sendmail::PMilter from running with several current versions of Sendmail. I don't know if simply changing ($ver == 2) to something like ($ver >= 2) is the correct solution. It would certainly get things working again. At the same time, who knows what sorts of bugs we could be letting ourselves in for... Right now, I am currently using Perl 5.10.0. The error message that is currently being generated is: SMFIC_OPTNEG: unknown milter protocol version 6 Thank you very much.

Tue Feb 17 01:20:18 2009 guthrie [...] counterexample.org - Correspondence added

CC:	guthrie [...] counterexample.org (John Guthrie)
Subject:	Re: [rt.cpan.org #43327] AutoReply: Milter protocol version update needed
Date:	Tue, 17 Feb 2009 01:20:01 -0500 (EST)
To:	bug-Sendmail-PMilter [...] rt.cpan.org
From:	"John T. Guthrie III" <guthrie [...] counterexample.org>

Show quoted text

> Hello all, > > I am currently using Sendmail-PMilter-0.96 on Fedora 9 and Fedora 10. The > sendmail version in both cases is 8.14. It seems that when sendmail connects > to the milter, it sends a milter protocol version of 6. > Sendmail::PMilter::Context seems to only accept a protocol version of 2. > (See line 273 of Context.pm.) It seems to me that this restriction is going > to keep Sendmail::PMilter from running with several current versions of > Sendmail. I don't know if simply changing > > ($ver == 2) > > to something like > > ($ver >= 2)

The following patch seems to be working with no problems so far: 273c273 < die "SMFIC_OPTNEG: unknown milter protocol version $ver\n" unless ($ver == 2); --- Show quoted text

> die "SMFIC_OPTNEG: unknown milter protocol version $ver\n" unless ($ver >= 2 && $ver <= 6);

I am also sending this diff as an attachment as well.

Message body is not shown because sender requested not to inline it.

Fri Nov 06 04:10:47 2009 dcantrell [...] cpan.org - Correspondence added

Would you like to take over maintenance of this distribution?

Fri Nov 06 04:10:51 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 12 19:49:12 2010 avar [...] cpan.org - Correspondence added

On Fri Nov 06 04:10:47 2009, DCANTRELL wrote: Show quoted text

> Would you like to take over maintenance of this distribution?

(This is a copy/paste form letter) Hello bug submitter to Sendmail::PMilter. As you may or may not be aware Sendmail::Pmilter is effectively orphaned. You've opened an issue against it which the current maintainer (me) doesn't have the time/want to solve. See http://search.cpan.org/~avar/Sendmail-PMilter- 0.98/lib/Sendmail/PMilter.pm#Maintenance for more details. But worry not, you can help solve it yourself if you're interested by patching the module in Git and asking for co-maint permission to upload a new version of the module. Even though your fix may seem trivial to you keep in mind that I'd still need to apply / *TEST* / release it. The testing step would require installing Sendmail and I have no interest in doing so ever again. The reason I'm the maintainer in the first place is that I spotted & patched a problem that needed to be solved and then got maintainer permission because the module was orphaned at the time. It's now orphaned again so if you need fixes to it you're going to have top step up and overtake it.

Fri Mar 12 19:49:16 2010 avar [...] cpan.org - Status changed from 'open' to 'stalled'

Tue Apr 30 12:08:15 2013 ZUMMO [...] cpan.org - Status changed from 'stalled' to 'resolved'

Tue Apr 30 12:08:15 2013 ZUMMO [...] cpan.org - Taken

Tue Apr 30 12:08:15 2013 ZUMMO [...] cpan.org - Fixed in 1.00 added