Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 43291
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: MATEU [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.096
Fixed in: 1.108



Subject: t/20_policy_pod_spelling - wrong number of tests for Non English - patch included
The number of tests for not English" is hard-coded at 4, but should now be 5 according to the test plan. I'm attaching a patch that hard-codes the test number in only one place.
Subject: perlcritic_t20_patch.diff
Index: 20_policy_pod_spelling.t =================================================================== --- 20_policy_pod_spelling.t (revision 3113) +++ 20_policy_pod_spelling.t (working copy) @@ -17,7 +17,11 @@ use Perl::Critic::TestUtils qw(pcritique); -use Test::More tests => 5; +my $number_of_tests; +BEGIN { + $number_of_tests = 5; +} +use Test::More tests => $number_of_tests; #----------------------------------------------------------------------------- @@ -68,7 +72,7 @@ END_PERL if ( eval { pcritique($policy, \$code) } ) { - skip 'Test environment is not English', 4 + skip 'Test environment is not English', $number_of_tests } #-----------------------------------------------------------------------------
On Sat Feb 14 16:01:59 2009, MATEU wrote: Show quoted text
> The number of tests for not English" is hard-coded at 4, but should now > be 5 according to the test plan. I'm attaching a patch that hard-codes > the test number in only one place. >
Thanks (_very_ belatedly) for the patch. Proposed fix (for RT 48986 as well, which is a repeat of this) committed as SVN revision 3757.