Bug #43243 for Perl-Dist-Strawberry: ppm is installing html files into incorrect dir

Thu Feb 12 15:26:20 2009 CHORNY [...] cpan.org - Ticket created

Subject:

ppm is installing html files into incorrect dir

Latest Strawberry 5.10. Show quoted text

PPM> install DBD-mysql

Install package 'DBD-mysql?' (y/N): y Installing package 'DBD-mysql'... Bytes transferred: 1018351 Files found in blib\arch: installing files in blib\lib into architecture dependent library tree Installing C:\strawberry\perl\site\lib\auto\DBD\mysql\mysql.bs Installing C:\strawberry\perl\site\lib\auto\DBD\mysql\mysql.dll Installing C:\strawberry\perl\site\lib\auto\DBD\mysql\mysql.exp Installing C:\strawberry\perl\site\lib\auto\DBD\mysql\mysql.lib Installing C:\strawberry\perl\site\lib\auto\DBD\mysql\mysql.pdb Installing \site\lib\Bundle\DBD\mysql.html Installing \site\lib\DBD\mysql.html Installing \site\lib\DBD\mysql\INSTALL.html Installing C:\strawberry\perl\site\lib\Bundle\DBD\mysql.pm Installing C:\strawberry\perl\site\lib\DBD\mysql.pm Installing C:\strawberry\perl\site\lib\DBD\mysql\GetInfo.pm Installing C:\strawberry\perl\site\lib\DBD\mysql\INSTALL.pod http://cpan.uwinnipeg.ca/PPMPackages/10xx/DBD-mysql.ppd http://cpan.uwinnipeg.ca/PPMPackages/10xx/x86/DBD-mysql.tar.gz C:\strawberry\perl\site\lib\ppm.xml is attached I guess it happens because /html[13]dir/ in Config is empty. -- Alexandr Ciornii, http://chorny.net

Subject:

ppm.xml

<PPMCONFIG> <PPMVER>0,01_01,0,0</PPMVER> <PLATFORM CPU="x86" OSVALUE="MSWin32" OSVERSION="4,0,0,0" /> <OPTIONS BUILDDIR="C:\strawberry\ppm" CLEAN="1" CONFIRM="1" DOWNLOADSTATUS="16384" FORCEINSTALL="1" IGNORECASE="1" MORE="24" ROOT="" TRACE="0" TRACEFILE="PPM.LOG" VERBOSE="1" /> <REPOSITORY LOCATION="http://ppm.activestate.com/PPMPackages/5.10-windows" NAME="ActiveState" SUMMARYFILE="searchsummary.ppm" /> <REPOSITORY LOCATION="http://www.bribes.org/perl/ppm" NAME="Bribes" SUMMARYFILE="searchsummary.ppm" /> <REPOSITORY LOCATION="http://trouchelle.com/ppm10" NAME="Trouchelle" SUMMARYFILE="package.xml" /> <REPOSITORY LOCATION="http://cpan.uwinnipeg.ca/PPMPackages/10xx" NAME="UWinnipeg" SUMMARYFILE="searchsummary.ppm" /> <PPMPRECIOUS>Compress-Zlib;Archive-Tar;Digest-MD5;File-CounterFile;Font-AFM;HTML-Parser;HTML-Tree;MIME-Base64;URI;XML-Element;libwww-perl;XML-Parser;SOAP-Lite;PPM;libnet;libwin32</PPMPRECIOUS> <PACKAGE NAME="DBD-mysql"> <LOCATION>http://cpan.uwinnipeg.ca/PPMPackages/10xx</LOCATION> <INSTPACKLIST>C:\strawberry\perl\site\lib\auto\DBD\mysql\.packlist</INSTPACKLIST> <INSTROOT>C:\strawberry\perl</INSTROOT> <INSTDATE>Thu Feb 12 10:09:38 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="DBD-mysql" VERSION="4,005,0,0"> <TITLE>DBD-mysql</TITLE> <ABSTRACT>A MySQL driver for the Perl5 Database Interface (DBI)</ABSTRACT> <AUTHOR>Rudy Lippan <rlippan@remotelinux.com></AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="http://cpan.uwinnipeg.ca/PPMPackages/10xx/x86/DBD-mysql.tar.gz" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE></PPMCONFIG>

Wed Mar 25 19:46:42 2009 krishpl [...] shamu.corp.sgi.com - Correspondence added

Identical behavior under portable Strawberry 5.10: Show quoted text

PPM> install DBD-mysql

Install package 'DBD-mysql?' (y/N): y Installing package 'DBD-mysql'... Bytes transferred: 1018351 Files found in blib\arch: installing files in blib\lib into architecture dependent library tree Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD \mysql\mysql.bs Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD \mysql\mysql.dll Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD \mysql\mysql.exp Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD \mysql\mysql.lib Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD \mysql\mysql.pdb Installing \site\lib\Bundle\DBD\mysql.html Installing \site\lib\DBD\mysql.html Installing \site\lib\DBD\mysql\INSTALL.html Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\Bundle \DBD\mysql.pm Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\DBD \mysql.pm Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\DBD \mysql\GetInfo.pm Installing C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\DBD \mysql\INSTALL.pod Show quoted text

PPM> quit

Quit!

<PPMCONFIG> <PPMVER>0,01_01,0,0</PPMVER> <PLATFORM CPU="x86" OSVALUE="MSWin32" OSVERSION="4,0,0,0" /> <OPTIONS BUILDDIR="C:\strawberry\ppm" CLEAN="1" CONFIRM="1" DOWNLOADSTATUS="16384" FORCEINSTALL="1" IGNORECASE="1" MORE="24" ROOT="" TRACE="0" TRACEFILE="PPM.LOG" VERBOSE="1" /> <REPOSITORY LOCATION="http://ppm.activestate.com/PPMPackages/5.10-windows" NAME="ActiveState" SUMMARYFILE="searchsummary.ppm" /> <REPOSITORY LOCATION="http://cpan.uwinnipeg.ca/PPMPackages/10xx" NAME="UWinnipeg" SUMMARYFILE="searchsummary.ppm" /> <REPOSITORY LOCATION="http://trouchelle.com/ppm10" NAME="Trouchelle" SUMMARYFILE="package.xml" /> <REPOSITORY LOCATION="http://www.bribes.org/perl/ppm" NAME="Bribes" SUMMARYFILE="searchsummary.ppm" /> <PPMPRECIOUS>Compress-Zlib;Archive-Tar;Digest-MD5;File-CounterFile;Font-AFM;HTML-Parser;HTML-Tree;MIME-Base64;URI;XML-Element;libwww-perl;XML-Parser;SOAP-Lite;PPM;libnet;libwin32</PPMPRECIOUS> <PACKAGE NAME="Win32-OLE"> <LOCATION>http://www.bribes.org/perl/ppm</LOCATION> <INSTPACKLIST>C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\Win32\OLE\.packlist</INSTPACKLIST> <INSTROOT>C:\krishna\purpleplug-4g\dev\aliasperl\perl</INSTROOT> <INSTDATE>Tue Mar 3 00:43:47 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="Win32-OLE" VERSION="0,1709,0,0"> <TITLE>Win32-OLE</TITLE> <ABSTRACT>OLE Automation extensions</ABSTRACT> <AUTHOR>Jan Dubois (jand@activestate.com)</AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="Win32-OLE-0.1709-PPM510.tar.gz" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE> <PACKAGE NAME="Tk"> <LOCATION>http://www.bribes.org/perl/ppm</LOCATION> <INSTPACKLIST>C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\Tk\.packlist</INSTPACKLIST> <INSTROOT>C:\krishna\purpleplug-4g\dev\aliasperl\perl</INSTROOT> <INSTDATE>Thu Mar 5 12:54:33 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="Tk" VERSION="804,028,0,0"> <TITLE>Tk</TITLE> <ABSTRACT>Tk - a Graphical User Interface Toolkit</ABSTRACT> <AUTHOR>Nick Ing-Simmons (nick@ing-simmons.net)</AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="Tk-804.028-PPM510.tar.gz" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE> <PACKAGE NAME="List-MoreUtils"> <LOCATION>http://www.bribes.org/perl/ppm</LOCATION> <INSTPACKLIST>C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\List\MoreUtils\.packlist</INSTPACKLIST> <INSTROOT>C:\krishna\purpleplug-4g\dev\aliasperl\perl</INSTROOT> <INSTDATE>Wed Mar 18 22:00:03 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="List-MoreUtils" VERSION="0,22,0,0"> <TITLE>List-MoreUtils</TITLE> <ABSTRACT>Provide the stuff missing in List::Util</ABSTRACT> <AUTHOR>Tassilo von Parseval (tassilo.von.parseval@rwth-aachen.de)</AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="List-MoreUtils-0.22-PPM510.tar.gz" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE> <PACKAGE NAME="Text-CSV"> <LOCATION>http://trouchelle.com/ppm10</LOCATION> <INSTPACKLIST>C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\Text\CSV\.packlist</INSTPACKLIST> <INSTROOT>C:\krishna\purpleplug-4g\dev\aliasperl\perl</INSTROOT> <INSTDATE>Wed Mar 18 22:25:14 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="Text-CSV" VERSION="1,10,0,0"> <TITLE>Text-CSV</TITLE> <ABSTRACT>comma-separated values manipulator (using XS or PurePerl)</ABSTRACT> <AUTHOR>Makamaka Hannyaharamitu, E<lt>makamaka[at]cpan.orgE<gt></AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="MSWin32-x86-multi-thread-5.10/Text-CSV-1.10.zip" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE> <PACKAGE NAME="DBD-mysql"> <LOCATION>http://cpan.uwinnipeg.ca/PPMPackages/10xx</LOCATION> <INSTPACKLIST>C:\krishna\purpleplug-4g\dev\aliasperl\perl\site\lib\auto\DBD\mysql\.packlist</INSTPACKLIST> <INSTROOT>C:\krishna\purpleplug-4g\dev\aliasperl\perl</INSTROOT> <INSTDATE>Wed Mar 25 16:41:24 2009</INSTDATE> <INSTPPD> <SOFTPKG NAME="DBD-mysql" VERSION="4,005,0,0"> <TITLE>DBD-mysql</TITLE> <ABSTRACT>A MySQL driver for the Perl5 Database Interface (DBI)</ABSTRACT> <AUTHOR>Rudy Lippan <rlippan@remotelinux.com></AUTHOR> <IMPLEMENTATION> <CODEBASE HREF="http://cpan.uwinnipeg.ca/PPMPackages/10xx/x86/DBD-mysql.tar.gz" /> <INSTALL /> <UNINSTALL /></IMPLEMENTATION></SOFTPKG></INSTPPD></PACKAGE></PPMCONFIG>

Wed Mar 25 19:46:45 2009 The RT System itself - Status changed from 'new' to 'open'

Tue May 04 10:53:51 2010 kmx [...] cpan.org - Correspondence added

Dne Čt 12.úno.2009 15:26:20, CHORNY napsal(a):
Show quoted text

> ...
> I guess it happens because /html[13]dir/ in Config is empty.

No, but close :)
We need to set $Config{installhtmldir} to some reasonable value - according to my tests it solves this issue.

I left up to Curtis whether we want to have
- $Config{installhtmldir} = 'C:\strawberry\html'
- or $Config{installhtmldir} = 'C:\strawberry\perl'

Path to installed files is e.g.
- c:\strawberry\html\site\lib\MySQL\Config.html
- or c:\strawberry\html\perl\lib\MySQL\Config.html

I propose to add this fix to July2010 queue.

--
kmx

Tue May 04 23:10:18 2010 adam [...] ali.as - Correspondence added

Subject:	Re: [rt.cpan.org #43243] ppm is installing html files into incorrect dir
Date:	Wed, 5 May 2010 13:10:07 +1000
To:	bug-Perl-Dist-Strawberry [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

I disagree, we should not be installing HTML files at all. The installer should detect a null install path for HTML files and not install them, recommend we work to fix that instead. Adam K On 5 May 2010 00:53, kmx via RT <bug-Perl-Dist-Strawberry@rt.cpan.org> wrote: Show quoted text

> Queue: Perl-Dist-Strawberry > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=43243 > > > Dne Čt 12.úno.2009 15:26:20, CHORNY napsal(a):

>> ... >> I guess it happens because /html[13]dir/ in Config is empty.

> > No, but close :) > We need to set $Config{installhtmldir} to some reasonable value - according to > my tests it solves this issue. > > I left up to Curtis whether we want to have > - $Config{installhtmldir} = 'C:\strawberry\html' > - or $Config{installhtmldir} = 'C:\strawberry\perl' > > Path to installed files is e.g. > - c:\strawberry\html\site\lib\MySQL\Config.html > - or c:\strawberry\html\perl\lib\MySQL\Config.html > > I propose to add this fix to July2010 queue. > > -- > kmx > >

Wed May 05 10:34:36 2010 kmx [...] cpan.org - Correspondence added

Dne Út 04.Květen.2010 23:10:18, adam@ali.as napsal(a):
Show quoted text

> I disagree, we should not be installing HTML files at all.
>
> The installer should detect a null install path for HTML files and not
> install them, recommend we work to fix that instead.

OK, then we need to patch PPM package (which is already a patched version of latesr PPM release) preinstalled in strawberry perl.

--
kmx

Wed May 05 14:16:13 2010 csjewell [...] cpan.org - Correspondence added

On Wed May 05 10:34:36 2010, KMX wrote: Show quoted text

> Dne Út 04.Květen.2010 23:10:18, adam@ali.as napsal(a):

> > I disagree, we should not be installing HTML files at all. > > > > The installer should detect a null install path for HTML files and not > > install them, recommend we work to fix that instead.

> > OK, then we need to patch PPM package (which is already a patched

version of Show quoted text

> latesr PPM release) preinstalled in strawberry perl.

Patch attached that *should* (untested) do the trick for both this bug and #57197.

Subject:

ppm-43243-57197.patch

diff -u3 -r PPM-0.01_02/lib/PPM.pm PPM/lib/PPM.pm --- PPM-0.01_02/lib/PPM.pm 2010-02-19 08:15:57.000000000 -0700 +++ PPM/lib/PPM.pm 2010-05-05 12:15:02.840456000 -0600 @@ -2,7 +2,7 @@ require 5.004; require Exporter; use vars qw( $VERSION ); -$VERSION = '0.01_02'; +$VERSION = '0.01_03'; @ISA = qw(Exporter); @EXPORT = qw(PPMdat PPMERR InstalledPackageProperties ListOfRepositories @@ -411,11 +411,11 @@ my $INST_HTMLHELPDIR = File::Spec->catdir(File::Spec->curdir,'blib','htmlhelp'); my $inst_script = $Config{installscript}; - my $inst_man1dir = $Config{installman1dir}; - my $inst_man3dir = $Config{installman3dir}; + my $inst_man1dir = $Config{installman1dir} || q{}; + my $inst_man3dir = $Config{installman3dir} || q{}; my $inst_bin = $Config{installbin}; - my $inst_htmldir = $Config{installhtmldir}; - my $inst_htmlhelpdir = $Config{installhtmlhelpdir}; + my $inst_htmldir = $Config{installhtmldir} || q{}; + my $inst_htmlhelpdir = $Config{installhtmlhelpdir} || q{}; my $inst_lib = $Config{installsitelib}; if (defined $root && $root !~ /^\Q$inst_root\E$/i) { @@ -435,12 +435,17 @@ &Trace("Calling ExtUtils::Install::install") if $options{'TRACE'} > 1; eval { ExtUtils::Install::install({ - "read" => $packlist, "write" => $packlist, - $INST_LIB => $inst_lib, $INST_ARCHLIB => $inst_archlib, - $INST_BIN => $inst_bin, $INST_SCRIPT => $inst_script, - $INST_MAN1DIR => $inst_man1dir, $INST_MAN3DIR => $inst_man3dir, - $INST_HTMLDIR => $inst_htmldir, - $INST_HTMLHELPDIR => $inst_htmlhelpdir},0,0,0); + "read" => $packlist, + "write" => $packlist, + $INST_LIB => $inst_lib, + $INST_ARCHLIB => $inst_archlib, + $INST_BIN => $inst_bin, + $INST_SCRIPT => $inst_script, + ($inst_man1dir ne q{}) ? ($INST_MAN1DIR => $inst_man1dir) : (), + ($inst_man3dir ne q{}) ? ($INST_MAN3DIR => $inst_man3dir) : (), + ($inst_htmldir ne q{}) ? ($INST_HTMLDIR => $inst_htmldir) : (), + ($inst_htmlhelpdir ne q{}) ? ($INST_HTMLHELPDIR => $inst_htmlhelpdir) : (), + },0,0,0); }; # install might have croaked in another directory chdir($cwd); diff -u3 -r PPM-0.01_02/Makefile.PL PPM/Makefile.PL --- PPM-0.01_02/Makefile.PL 2010-02-19 08:26:42.000000000 -0700 +++ PPM/Makefile.PL 2010-05-05 12:12:39.674593600 -0600 @@ -61,6 +61,8 @@ %opts, ); + + my $repositories = {'5.6' => { 'ActiveState' => @@ -100,6 +102,27 @@ summaryfile => 'package.xml', }, }, + '5.12' => { + ($Config ~= m/x86/) ? + ('ActiveState' => + {location => 'http://ppm4.activestate.com/MSWin32-x86/5.12/1200/', + summaryfile => 'package.xml', + }, + 'Bribes' => + {location => 'http://www.bribes.org/perl/ppm', + summaryfile => 'searchsummary.ppm', + }, + 'Trouchelle' => + {location => 'http://trouchelle.com/ppm12', + summaryfile => 'package.xml', + }, + },) + : + ('ActiveState' => + {location => 'http://ppm4.activestate.com/MSWin32-x64/5.12/1200/', + summaryfile => 'package.xml', + },) + ; }; ppm_config(); @@ -116,15 +139,21 @@ $perl_version = '5.8'; last PERLV; }; - $perl_version = '5.10'; + ($] < 5.012) and do { + $perl_version = '5.10'; + last PERLV; + }; + $perl_version = '5.12'; } my $reps = $repositories->{$perl_version}; - + my $cpu = $Config ~= m/x86/ ? 'x86' : 'x64'; + my %subs = ( '%OSNAME%' => $Config{osname}, '%OSVERSION%' => '4,0,0,0', '%TEMP%' => $ENV{TMP} || $ENV{TEMP}, '%SITELIB%' => $Config{sitelib}, '%PERLDIR%' => $Config{prefix}, + '%CPU%' => $cpu, '%INSTDATE%' => scalar localtime, ); open(PPM, ">$ppm") or die "Cannot open $ppm: $!"; @@ -166,8 +195,8 @@ __DATA__ <PPMCONFIG> - <PPMVER>0,01_02,0,0</PPMVER> - <PLATFORM CPU="x86" OSVALUE="%OSNAME%" OSVERSION="%OSVERSION%" /> + <PPMVER>0,01_03,0,0</PPMVER> + <PLATFORM CPU="%CPU%" OSVALUE="%OSNAME%" OSVERSION="%OSVERSION%" /> <OPTIONS BUILDDIR="%TEMP%" CLEAN="1" CONFIRM="1" DOWNLOADSTATUS="16384" FORCEINSTALL="1" IGNORECASE="1" MORE="24" ROOT="" TRACE="0" TRACEFILE="PPM.LOG" VERBOSE="1" /> <PPMPRECIOUS>Compress-Zlib;Archive-Tar;Digest-MD5;File-CounterFile;Font-AFM;HTML-Parser;HTML-Tree;MIME-Base64;URI;XML-Element;libwww-perl;XML-Parser;SOAP-Lite;PPM;libnet;libwin32</PPMPRECIOUS> </PPMCONFIG>

Wed May 05 19:25:02 2010 csjewell [...] cpan.org - Correspondence added

http://fisheye2.atlassian.com/changelog/cpan/?cs=12102 installs a version of PPM that fixes this bug in future versions of Strawberry Perl. http://csjewell.dreamwidth.org/12480.html gives descriptions on how to install the new version of PPM on current versions of Strawberry. These descriptions will also be in the release notes for current versions in the next few hours.

Wed May 05 19:25:04 2010 csjewell [...] cpan.org - Status changed from 'open' to 'patched'

Thu Aug 19 23:50:12 2010 csjewell [...] cpan.org - Status changed from 'patched' to 'resolved'