Bug #43151 for Devel-REPL: tab completion plugin doesn't work with

Mon Feb 09 12:50:53 2009 DOY [...] cpan.org - Ticket created

Subject:

tab completion plugin doesn't work with _

Pressing tab after "_->" results in "Error! - I do not recognize that sigil '_' at /usr/lib/perl5/site_perl/5.10.0/Class/MOP/Package.pm line 116"

Wed May 12 22:48:27 2010 chm [...] cpan.org - Correspondence added

On Mon Feb 09 12:50:53 2009, DOY wrote: Show quoted text

> Pressing tab after "_->" results in "Error! - I do not recognize that > sigil '_' at /usr/lib/perl5/site_perl/5.10.0/Class/MOP/Package.pm line

116" I'm not sure how you would like to have it complete things here. However, I think the fact that it reports an error after a valid construct could be construed as a bug and not a "feature".

Wed May 12 22:48:28 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Jun 01 12:58:42 2010 chm [...] cpan.org - Correspondence added

The problem report appears incomplete. I guess the user may be trying TAB completion from the _ routine in the OutputCache plugin. It is unclear what completion is desired, available, or useful, but ideally the complete should not generate an error from valid code. On Mon Feb 09 12:50:53 2009, DOY wrote: Show quoted text

> Pressing tab after "_->" results in "Error! - I do not recognize that > sigil '_' at /usr/lib/perl5/site_perl/5.10.0/Class/MOP/Package.pm line

116"

Tue Jun 01 13:23:37 2010 chm [...] cpan.org - Correspondence added

The problem occurs in CompletionDriver::Methods around line 43. find_variable is being called with '_' which is incorrect since '_' is not a variable (has no sigil). The fix would be to do a little better check here....

Sat Jun 12 12:43:16 2010 chm [...] cpan.org - Correspondence added

This fixes the error from TAB completion of the _-> construct. I'm not sure what completions would happen from that initial step but the completion does not die trying now. Fixed in git and should be in the next release. I've attached the new version of the FindVariable plugin in the meantime.

Subject:

FindVariable.pm

package Devel::REPL::Plugin::FindVariable; use Devel::REPL::Plugin; use namespace::clean -except => [ 'meta' ]; sub find_variable { my ($self, $name) = @_; return \$self if $name eq '$_REPL'; # XXX: this code needs to live in LexEnv if ($self->can('lexical_environment')) { return \( $self->lexical_environment->get_context('_')->{$name} ) if exists $self->lexical_environment->get_context('_')->{$name}; } my $sigil = $name =~ s/^([\$\@\%\&\*])// ? $1 : ''; my $default_package = $self->can('current_package') ? $self->current_package : 'main'; my $package = $name =~ s/^(.*)(::|')// ? $1 : $default_package; my $meta = Class::MOP::Class->initialize($package); # Class::MOP::Package::has_package_symbol method *requires* a sigil return unless length($sigil) and $meta->has_package_symbol("$sigil$name"); $meta->get_package_symbol("$sigil$name"); } 1; __END__ =head1 NAME Devel::REPL::Plugin::FindVariable - Finds variables by name =head1 AUTHOR Shawn M Moore, C<< <sartak at gmail dot com> >> =cut

Sat Jun 12 12:43:18 2010 chm [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #43151 for Devel-REPL: tab completion plugin doesn't work with _