Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the YAML-LibYAML CPAN distribution.

Report information
The Basics
Id: 43115
Status: resolved
Priority: 0/
Queue: YAML-LibYAML
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.32
Fixed in: (no value)

History Show all quoted text
  Sun Feb 08 01:38:55 2009 ANDK [...] cpan.org - Ticket created
Subject: Two binary searches
cpantesters expose there is only a range of perls that pass all tests. Current blead does not PASS because of the new regexes. These started with patch 32740. From then on the tests fail similar to this: http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3220752.html http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3219948.html At the lower end there was patch 22862 which fixed Scalar::Util::refaddr. Before this fix the tests complained about bad quoting as you can see here: http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3225989.html For the latter you could get away with 'require 5.008005'. Best,
  Fri Mar 13 03:27:48 2009 ANDK [...] cpan.org - Subject changed from 'Two binary searches' to 'Broken with bleadperl and with 5.8.4 (was: Two binary searches)'
  Thu Dec 10 01:41:28 2009 cnhacktnt [...] cpan.org - Correspondence added
I have the same issues as http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3220615.html when I try to install YAML::LibYAML 0.32 I use Perl 5.11.2， any solution by now? Show quoted text
> Current blead does not PASS because of the new regexes. These started > with patch 32740. From then on the tests fail similar to this: > > http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3220752.html > http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3219948.html > > At the lower end there was patch 22862 which fixed > Scalar::Util::refaddr. Before this fix the tests complained about bad > quoting as you can see here: > > http://www.nntp.perl.org/group/perl.cpan.testers/2009/02/msg3225989.html > > For the latter you could get away with 'require 5.008005'. > > Best,
  Thu Dec 10 01:41:29 2009 The RT System itself - Status changed from 'new' to 'open'
  Thu Dec 10 04:40:36 2009 NUFFIN [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #43115] Broken with bleadperl and with 5.8.4 (was: Two binary searches)
Date: Thu, 10 Dec 2009 11:40:00 +0200
To: bug-YAML-LibYAML [...] rt.cpan.org
From: Yuval Kogman <nuffin [...] cpan.org>
Looks like the new SvTYPE for regexes is not yet supported. It shouldn't be hard to patch. i might have time to try doing this next week
  Sun Feb 14 05:11:12 2010 GAAS [...] cpan.org - Correspondence added
RT-Send-CC: nuffin [...] cpan.org
This patch seems to do the trick.
Subject: 0004-Add-support-for-SVt_REGEXP-RT-43115.patch
From 01e53918fab954e8c52bba258068599807fe6367 Mon Sep 17 00:00:00 2001 From: Gisle Aas <gisle@activestate.com> Date: Sun, 14 Feb 2010 02:06:16 -0800 Subject: [PATCH 4/4] Add support for SVt_REGEXP [RT#43115] perl-5.12 make regular expressions first class. --- LibYAML/perl_libyaml.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/LibYAML/perl_libyaml.c b/LibYAML/perl_libyaml.c index 811e3a5..29e0294 100644 --- a/LibYAML/perl_libyaml.c +++ b/LibYAML/perl_libyaml.c @@ -652,6 +652,15 @@ dump_node(perl_yaml_dumper_t *dumper, SV *node) } dump_scalar(dumper, node, tag); } +#if PERL_REVISION > 5 || (PERL_REVISION == 5 && PERL_VERSION >= 11) + else if (ref_type == SVt_REGEXP) { + yaml_char_t *tag = (yaml_char_t *)form(TAG_PERL_PREFIX "regexp"); + class = sv_reftype(rnode, TRUE); + if (!strEQ(class, "Regexp")) + tag = (yaml_char_t *)form("%s:%s", tag, class); + dump_scalar(dumper, node, tag); + } +#endif else { printf( "YAML::XS dump unhandled ref. type == '%d'!\n", -- 1.6.2.rc2
  Mon Apr 12 06:49:56 2010 ANDK [...] cpan.org - Correspondence added
Gisle's patch now also available for download: http://cpan.hexten.net/modules/by-authors/id/A/AN/ANDK/patches/YAML-LibYAML-0.32-GAAS-01.patch.gz distroprefs file to apply the patch: http://github.com/andk/cpanpm/blob/master/distroprefs/NUFFIN.YAML-LibYAML.yml
  Wed Apr 14 21:23:40 2010 ingy [...] cpan.org - Correspondence added
RT-Send-CC: nuffin [...] cpan.org
Applied Gisle's patch to 0.32 and released 0.33 to CPAN.
  Wed Apr 14 21:23:41 2010 ingy [...] cpan.org - Status changed from 'open' to 'resolved'