1) I would prefer that Apache::DBI be loaded in the apache conf so the
implementer can decide.
2) small fix for $HEX_STRING_REGEX definition
3) changed %CONFIG_DEFAULT to make the case consistent.
DBI->connect_cached as looking for $c{DBI_user} which was actually
defined in $c{DBI_User}.
| Subject: | Apache2-AuthCookieDBI-2.04.diff |
43,49c43
<
< # I think it is better to let the implementer decide if they want to use
< # Apache::DBI by setting PerlModule Apache::DBI in their apache conf.
< # The implementer may be using pgbouncer or some other connection pooling
< # service that is not compatible with Apache::DBI
< #use Apache::DBI;
<
---
> use Apache::DBI;
71c65
< my $HEX_STRING_REGEX = qr/ \A [0-9a-fA-F]+ \z /mx;
---
> my $HEX_STRING_REGEX = qr/ \A [0-9a-fA-F] \z /mx;
285,290c279,284
< DBI_dsn => undef,
< DBI_secretkey => undef,
< DBI_user => undef,
< DBI_password => undef,
< DBI_userstable => 'users',
< DBI_userfield => 'user',
---
> DBI_DSN => undef,
> DBI_SecretKey => undef,
> DBI_User => undef,
> DBI_Password => undef,
> DBI_UsersTable => 'users',
> DBI_UserField => 'user',
510c504
< DBI->connect_cached( $c{DBI_dsn}, $c{DBI_user}, $c{DBI_password} );
---
> DBI->connect_cached( $c{DBI_DSN}, $c{DBI_user}, $c{DBI_password} );
517c511
< "Apache2::AuthCookieDBI: couldn't connect to $c{ DBI_dsn } for auth realm $auth_name",
---
> "Apache2::AuthCookieDBI: couldn't connect to $c{ DBI_DSN } for auth realm $auth_name",
548c542
< "Apache2::AuthCookieDBI: couldn't select password from $c->{ DBI_dsn }, $c->{ DBI_userstable }, $c->{ DBI_userfield } for user $user for auth realm $auth_name",
---
> "Apache2::AuthCookieDBI: couldn't select password from $c->{ DBI_DSN }, $c->{ DBI_userstable }, $c->{ DBI_userfield } for user $user for auth realm $auth_name",
690c684
< my $secretkey = $c{DBI_secretkey};
---
> my $secretkey = $c{DBI_SecretKey};
724c718
< my $secret_key = $c{DBI_secretkey};
---
> my $secret_key = $c{DBI_SecretKey};