Bug #43071 for Net-ext: Patch: Net::Gen (Net-ext) Gen.xs patch for Perl v5.10.0

Fri Feb 06 01:20:01 2009 rmandalemula [...] yahoo.com - Ticket created

Subject:

Patch: Net::Gen (Net-ext) Gen.xs patch for Perl v5.10.0

Hi, The attached patch fixes the problem reported in http://www.mail- archive.com/cpan-testers@perl.org/msg997951.html --- Gen.xs 2002-04-10 16:35:58.000000000 +0530 +++ Gen-new.xs 2008-12-12 21:34:49.344756000 +0530 @@ -146,7 +146,7 @@ CV *cv; klen = strlen(name); (void) hv_fetch(missing, name, klen, TRUE); - cv = newXS(name, NULL, file); /* newSUB with no block */ + cv = newXS(name, Perl_cv_undef, file); /* newSUB with no block */ sv_setsv((SV*)cv, &PL_sv_no); /* prototype it as "()" */ } The above patch also fixes a core dump issue when used with threads module. Please apply the patch to the offcial Net-ext source. Thanks. Rajesh

Wed Apr 01 08:27:37 2009 jero [...] i2.com.br - Correspondence added

From:

jero [...] i2.com.br

Dear Rajesh, Em Sex. Fev. 06 01:20:01 2009, rmandalemula escreveu: Show quoted text

> Hi, > > The attached patch fixes the problem reported in http://www.mail- > archive.com/cpan-testers@perl.org/msg997951.html > > --- Gen.xs 2002-04-10 16:35:58.000000000 +0530 > +++ Gen-new.xs 2008-12-12 21:34:49.344756000 +0530 > @@ -146,7 +146,7 @@ > CV *cv; > klen = strlen(name); > (void) hv_fetch(missing, name, klen, TRUE); > - cv = newXS(name, NULL, file); /* newSUB with no block */ > + cv = newXS(name, Perl_cv_undef, file); /* newSUB with no block */ > sv_setsv((SV*)cv, &PL_sv_no); /* prototype it as "()" */ > } > > The above patch also fixes a core dump issue when used with threads > module. Please apply the patch to the offcial Net-ext source.

The patch works fine. Thank you very much !!! I'm using Perl-5.10.0, Bluewhite64 v12.2 and the following kernel: Linux server 2.6.28.9 #2 SMP Wed Apr 1 08:48:54 BRT 2009 x86_64 Intel(R) Pentium(R) Dual CPU E2200 @ 2.20GHz GenuineIntel GNU/Linux Thanks again ! ;-) []s, Jeronimo de A. Barros Belo Horizonte/MG - BRAZIL

Wed Apr 01 08:27:38 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 13 18:23:06 2009 cvicente [...] cpan.org - Correspondence added

Can the author please apply this patch? Other modules that depend on this one can't be installed using CPAN. Thanks cv

Fri Feb 12 16:55:20 2010 kris [...] kriskirkland.com - Correspondence added

From:

kris [...] kriskirkland.com

On Wed Apr 01 08:27:37 2009, jero wrote: Show quoted text

> Dear Rajesh, > > Em Sex. Fev. 06 01:20:01 2009, rmandalemula escreveu:

> > Hi, > > > > The attached patch fixes the problem reported in http://www.mail- > > archive.com/cpan-testers@perl.org/msg997951.html > > > > --- Gen.xs 2002-04-10 16:35:58.000000000 +0530 > > +++ Gen-new.xs 2008-12-12 21:34:49.344756000 +0530 > > @@ -146,7 +146,7 @@ > > CV *cv; > > klen = strlen(name); > > (void) hv_fetch(missing, name, klen, TRUE); > > - cv = newXS(name, NULL, file); /* newSUB with no block */ > > + cv = newXS(name, Perl_cv_undef, file); /* newSUB with no block

*/ Show quoted text

> > sv_setsv((SV*)cv, &PL_sv_no); /* prototype it as "()" */ > > } > > > > The above patch also fixes a core dump issue when used with threads > > module. Please apply the patch to the offcial Net-ext source.

> > The patch works fine. Thank you very much !!! > > I'm using Perl-5.10.0, Bluewhite64 v12.2 and the following kernel: > > Linux server 2.6.28.9 #2 SMP Wed Apr 1 08:48:54 BRT 2009 x86_64

Intel(R) Show quoted text

> Pentium(R) Dual CPU E2200 @ 2.20GHz GenuineIntel GNU/Linux > > Thanks again ! ;-) > > []s, Jeronimo de A. Barros > Belo Horizonte/MG - BRAZIL

I was not able to get the patch to work. Perl: 5.10.0 Debian (Lenny) Linux 2.6.26-2-686 #1 SMP File to patch: Gen.xs patching file Gen.xs patch: **** malformed patch at line 4: CV *cv;

Fri Mar 19 06:39:41 2010 DTADY [...] cpan.org - Correspondence added

On Mon Jul 13 18:23:06 2009, CVICENTE wrote: Show quoted text

> Can the author please apply this patch? > > Other modules that depend on this one can't be installed using CPAN. > > Thanks > > cv

+1 to applying the patch. Bumping up this ticket. The patch featured here worked cleanly (1-line change to Gen.c) Many of our modules depend on Net::TCP and it breaks on Perl 5.10.x. Thanks!

Sun Feb 24 10:30:01 2013 florian.koch1981 [...] gmail.com - Correspondence added

From:

florian.koch1981 [...] gmail.com

On Fri Mar 19 06:39:41 2010, DTADY wrote: Show quoted text

> On Mon Jul 13 18:23:06 2009, CVICENTE wrote:

> > Can the author please apply this patch? > > > > Other modules that depend on this one can't be installed using CPAN. > > > > Thanks > > > > cv

> > +1 to applying the patch. > > Bumping up this ticket. The patch featured here worked cleanly (1-line > change to Gen.c) > > Many of our modules depend on Net::TCP and it breaks on Perl 5.10.x. > > Thanks!

its also broken with Perl 5.16.1, please apply the patch