Skip Menu |

This queue is for tickets about the Net-IMAP-Client CPAN distribution.

Report information
The Basics
Id: 43049
Status: resolved
Priority: 0/
Queue: Net-IMAP-Client

People
Owner: Nobody in particular
Requestors: RADEK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 0.94



Subject: The append() method's documentation
The append() method doesn't work when passed $rfc822 as a plain scalar, as the _gen_cmd() method would just "join '', @$args". It works OK when $rfc822 is passed as a scalar ref, though. Suggested documentation tweak attached.
Subject: net-imap-client-append.patch
--- blib/lib/Net/IMAP/Client.pm 2009-01-25 11:34:12.000000000 +0100 +++ lib/Net/IMAP/Client.pm 2009-02-05 10:59:59.506123474 +0100 @@ -406,6 +406,8 @@ sub append { my ($self, $folder, $rfc822, $flags, $date) = @_; + die 'message body passed to append() must be a SCALAR reference' + unless ref $rfc822 eq 'SCALAR'; my $quoted = $folder; _string_quote($quoted); my $args = [ "$quoted " ]; @@ -1683,7 +1685,7 @@ on "EXISTS" to tell when new messages have arrived. Therefore I can only say that "RECENT" is useless and I advise you to ignore it. -=head2 append($folder, $rfc822, $flags, $date) +=head2 append($folder, \$rfc822, $flags, $date) Appends a message to the given C<$folder>. You must pass the full RFC822 body in C<$rfc822>. C<$flags> and C<$date> are optional. If
I have patched the documention as suggested.