Skip Menu |

This queue is for tickets about the MPEG-Audio-Frame CPAN distribution.

Report information
The Basics
Id: 43015
Status: resolved
Priority: 0/
Queue: MPEG-Audio-Frame

People
Owner: Nobody in particular
Requestors: RSAVAGE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.10
Fixed in: (no value)



Subject: Test 04-tie fails
OS: Debian. Perl: 5.10.0. Progress: None: I tried debugging the code (without the debugger) but could not determine what was going on. Output: Running Build test t/01-basic........................ok t/02-constants....................ok t/03-crc..........................ok t/04-tie..........................1/5 Not a HASH reference at /home/ron/.cpan/build/MPEG-Audio-Frame-0.09-TehE1p/blib/lib/MPEG/Audio/Frame.pm line 272, <DATA> line 1. # Looks like you planned 5 tests but ran 2. # Looks like your test exited with 255 just after 2. t/04-tie.......................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/5 subtests t/05-invalid......................ok t/10-mpeg1-44100..................ok t/11-mpeg1-layerI-fl1.............ok t/11-mpeg1-layerI-fl2.............ok t/11-mpeg1-layerI-fl3.............ok t/11-mpeg1-layerI-fl4.............ok t/11-mpeg1-layerI-fl5.............ok t/11-mpeg1-layerI-fl6.............ok t/11-mpeg1-layerI-fl7.............ok t/11-mpeg1-layerI-fl8.............ok t/12-mpeg1-layerII-fl10...........ok t/12-mpeg1-layerII-fl11...........ok t/12-mpeg1-layerII-fl12...........ok t/12-mpeg1-layerII-fl13...........ok t/12-mpeg1-layerII-fl14...........ok t/12-mpeg1-layerII-fl15...........ok t/12-mpeg1-layerII-fl16...........ok t/13-mpeg1-layerIII-compl.........ok t/14-mpeg1-layerIII-hecommon......ok t/15-mpeg1-layerIII-he_32khz......ok t/16-mpeg1-layerIII-he_44khz......ok t/17-mpeg1-layerIII-he_48khz......ok t/18-mpeg1-layerIII-he_mode.......ok t/19-mpeg1-layerIII-he_free.......ok t/20-mpeg1-test01.................ok t/20-mpeg2-22050..................ok t/30-mpeg25-11025.................ok Test Summary Report ------------------- t/04-tie.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 2.
Subject: [rt.cpan.org #43015] MPEG-Audio-Frame: Test 04-tie fails
Date: Wed, 11 Sep 2019 20:02:01 +0200
To: bug-MPEG-Audio-Frame [...] rt.cpan.org
From: Håkon Hægland <hakon.hagland [...] gmail.com>
This bug seems to have been introduced in perl 5.8.9, see http://matrix.cpantesters.org/?dist=MPEG-Audio-Frame+0.09 the problem with the test was that the line #194 https://metacpan.org/source/NUFFIN/MPEG-Audio-Frame-0.09/lib/MPEG/Audio/Frame.pm#L194 that is, this line: my $fh = shift || return undef introduced a boolean context and the return value of shift was passed to the overloaded stringification operator at line #270 https://metacpan.org/source/NUFFIN/MPEG-Audio-Frame-0.09/lib/MPEG/Audio/Frame.pm#L270 but this was too early for the object passed had not yet become a hash reference. See this post: https://stackoverflow.com/q/57890664/2173773 for more information. I have attached a patch that fixes the problem.

Message body is not shown because sender requested not to inline it.

Subject: RE: [rt.cpan.org #43015] MPEG-Audio-Frame: Test 04-tie fails
Date: Wed, 11 Sep 2019 20:16:28 +0000
To: "bug-MPEG-Audio-Frame [...] rt.cpan.org" <bug-MPEG-Audio-Frame [...] rt.cpan.org>
From: Adam Russell <ac.russell [...] live.com>
Thank you very much! I will merge the changes as soon as I can. (may be a day or two). From: Håkon Hægland via RT<mailto:bug-MPEG-Audio-Frame@rt.cpan.org> Sent: Wednesday, September 11, 2019 11:02 AM Subject: [rt.cpan.org #43015] MPEG-Audio-Frame: Test 04-tie fails Queue: MPEG-Audio-Frame Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=43015 > This bug seems to have been introduced in perl 5.8.9, see http://matrix.cpantesters.org/?dist=MPEG-Audio-Frame+0.09 the problem with the test was that the line #194 https://metacpan.org/source/NUFFIN/MPEG-Audio-Frame-0.09/lib/MPEG/Audio/Frame.pm#L194 that is, this line: my $fh = shift || return undef introduced a boolean context and the return value of shift was passed to the overloaded stringification operator at line #270 https://metacpan.org/source/NUFFIN/MPEG-Audio-Frame-0.09/lib/MPEG/Audio/Frame.pm#L270 but this was too early for the object passed had not yet become a hash reference. See this post: https://stackoverflow.com/q/57890664/2173773 for more information. I have attached a patch that fixes the problem.
fixed in 0.10