Skip Menu |

This queue is for tickets about the RRDTool-OO CPAN distribution.

Report information
The Basics
Id: 43011
Status: open
Priority: 0/
Queue: RRDTool-OO

People
Owner: Nobody in particular
Requestors: toddr [...] cpanel.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.22
Fixed in: (no value)



Subject: Precision problems with RRD 1.3.6 AMD64?
Hi, just successfully installed RRD binaries today and am now installing RRDTool::OO. I'm getting test errors that look like RRD is being too precise on a 64 bit system and messing up your results: $>make test PERL_DL_NONLAZY=1 /opt/perl588/release/perl588_linux/bin/perl "- MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/001Basic.......9/? # Failed test 'match expected value' # at t/001Basic.t line 103. # got: '1080462360:5.59999999999999964' # expected: '1080462360:5.6' # Failed test 'match expected value' # at t/001Basic.t line 103. # got: '1080462420:5.70000000000000018' # expected: '1080462420:5.7' # Failed test 'match expected value' # at t/001Basic.t line 103. # got: '1080462480:5.79999999999999982' # expected: '1080462480:5.8' # Failed test 'match expected value' # at t/001Basic.t line 103. # got: '1080462540:5.90000000000000036' # expected: '1080462540:5.9' t/001Basic.......15/? # Looks like you failed 4 tests of 30. t/001Basic....... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/30 subtests t/002Pod.........ok t/003Discover....ok t/004Template....ok t/005Graph.......1/17 rrdtool graph mygraph.png --vertical-label Test gprint --end 1080462600 --start 1080460200 DEF:firstgraph=foo:load1:MAX LINE1:firstgraph#FF0000:Unmodified Load VDEF:average_of_first_draw=firstgraph,AVERAGE GPRINT:average_of_first_draw:Hello %lf failed: unknown function 'VDEF' at /home/.../.cpan/build/RRDTool-OO-0.22-JMGklO/blib/lib/RRDTool/OO.pm line 410 # Looks like you planned 17 tests but ran 11. # Looks like your test exited with 255 just after 11. t/005Graph....... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/17 subtests t/006Tune........ok t/007Dump........ok t/008Mult........3/? # Failed test 'match expected value' # at t/008Mult.t line 69. # got: '1080462360:5.59999999999999964' # expected: '1080462360:5.6' # Failed test 'match expected value' # at t/008Mult.t line 70. # got: '1080462360:15.5999999999999996' # expected: '1080462360:15.6' # Failed test 'match expected value' # at t/008Mult.t line 69. # got: '1080462420:5.70000000000000018' # expected: '1080462420:5.7' # Failed test 'match expected value' # at t/008Mult.t line 70. # got: '1080462420:15.6999999999999993' # expected: '1080462420:15.7' # Failed test 'match expected value' # at t/008Mult.t line 69. # got: '1080462480:5.79999999999999982' # expected: '1080462480:5.8' # Failed test 'match expected value' # at t/008Mult.t line 70. # got: '1080462480:15.8000000000000007' # expected: '1080462480:15.8' # Failed test 'match expected value' # at t/008Mult.t line 69. # got: '1080462540:5.90000000000000036' # expected: '1080462540:5.9' # Failed test 'match expected value' # at t/008Mult.t line 70. # got: '1080462540:15.9000000000000004' # expected: '1080462540:15.9' # Looks like you failed 8 tests of 13. t/008Mult........ Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/13 subtests t/009Dry.........ok t/010ABD.........rrdtool create foo --start 1080460190 --step 60 DS:load1:GAUGE:90:0:100 RRA:MAX:0.5:1:300 RRA:HWPREDICT:300:0.5:0.5:30:3 RRA:SEASONAL:30:0.01:2 RRA:DEVSEASONAL:30:0.01:2 RRA:DEVPREDICT:300:4 RRA:FAILURES:300:2:9:4 failed: can't parse argument 'RRA:HWPREDICT:300:0.5:0.5:30:3' at /home/.../.cpan/build/RRDTool-OO-0.22-JMGklO/blib/lib/RRDTool/OO.pm line 410 # Looks like your test exited with 255 before it could output anything. t/010ABD......... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report ------------------- t/001Basic (Wstat: 1024 Tests: 30 Failed: 4) Failed tests: 9-12 Non-zero exit status: 4 t/005Graph (Wstat: 65280 Tests: 11 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 17 tests but ran 11. t/008Mult (Wstat: 2048 Tests: 13 Failed: 8) Failed tests: 3-10 Non-zero exit status: 8 t/010ABD (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 1 tests but ran 0. Files=10, Tests=91, 10 wallclock secs ( 0.06 usr 0.03 sys + 4.58 cusr 1.75 csys = 6.42 CPU) Result: FAIL Failed 4/10 test programs. 12/91 subtests failed. make: *** [test_dynamic] Error 255
perl version information if you need it: Summary of my perl5 (revision 5 version 8 subversion 8) configuration: Platform: osname=linux, osvers=2.6.9-42.0.3.elsmp, archname=x86_64-linux- thread-multi-ld uname='linux host 2.6.9-42.0.3.elsmp #1 smp mon sep 25 17:24:31 edt 2006 x86_64 x86_64 x86_64 gnulinux ' config_args='' hint=previous, useposix=true, d_sigaction=define usethreads=define use5005threads=undef useithreads=define usemultiplicity=define useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=define use64bitall=define uselongdouble=define usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS - fno-strict-aliasing -pipe -Wdeclaration-after-statement - I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2', cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno- strict-aliasing -pipe -Wdeclaration-after-statement - I/usr/local/include -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno- strict-aliasing -pipe -Wdeclaration-after-statement - I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' ccversion='', gccversion='3.4.6 20060404 (Red Hat 3.4.6-3)', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='long double', nvsize=16, Off_t='off_t', lseeksize=8 alignbytes=16, prototype=define Linker and Libraries: ld='gcc', ldflags =' -L/usr/local/lib' libpth=/opt/perl588/site/zlib- 1.2.3/lib /opt/perl588/site/ssl/lib /opt/perl588/site/libssh/lib /usr/lo cal/lib /lib /usr/lib libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc libc=/lib/libc-2.3.4.so, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='2.3.4' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP THREADS_HAVE_PIDS USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS USE_LARGE_FILES USE_LONG_DOUBLE USE_PERLIO USE_REENTRANT_API Built under linux Compiled at Oct 18 2007 19:34:15 %ENV: PERL5LIB="" PERL5OPT="" PERL5_CPANPLUS_IS_RUNNING="9201" PERL5_CPAN_IS_RUNNING="9201" PERLDB_OPTS="RemotePort=lhouatlm40d6bg1.texas.chase.com:9000" @INC: /opt/perl588/lib/5.8.8/x86_64-linux-thread-multi-ld /opt/perl588/lib/5.8.8 /opt/perl588/site/lib/x86_64-linux-thread-multi-ld /opt/perl588/site/lib /opt/perl588/site/lib /opt/perl588/site/jpmc_lib .
Good catch, I've (hopefully) fixed the issue in 0.23 (released to CPAN a couple of minutes ago). I don't have a similar system to test this on handy, so please let me know if there's still a problem! Thanks a bunch for your report, I really appreciate it. -- Mike
From: todd.e.rinaldo [...] jpmorgan.com
On Thu Feb 05 04:56:07 2009, MSCHILLI wrote: Show quoted text
> Good catch, I've (hopefully) fixed the issue in 0.23 (released to
CPAN a Show quoted text
> couple of minutes ago). I don't have a similar system to test this on > handy, so please let me know if there's still a problem! > > Thanks a bunch for your report, I really appreciate it. > > -- Mike
Hi, I continue to get the same errors on 0.23. Is there any more information I can provide?
Subject: Precision problems with RRD 1.3.6 AMD64? - Perl configured to use long doubles
From: salvatore.bonaccorso [...] gmail.com
Hi Not from the same reporter, but same behaviour: On Mon Feb 09 12:25:48 2009, todd_rinaldo wrote: Show quoted text
> On Thu Feb 05 04:56:07 2009, MSCHILLI wrote:
> > Good catch, I've (hopefully) fixed the issue in 0.23 (released to
> CPAN a
> > couple of minutes ago). I don't have a similar system to test this on > > handy, so please let me know if there's still a problem! > > > > Thanks a bunch for your report, I really appreciate it. > > > > -- Mike
> > Hi, I continue to get the same errors on 0.23. Is there any more > information I can provide?
It should be related to if Perl is configured to use long doubles (-Duselongdouble). See for example too the report in Debian: http://bugs.debian.org/578943 Bests Salvatore
From: salvatore.bonaccorso [...] gmail.com
Hi On Tue Feb 03 17:54:19 2009, todd_rinaldo wrote: Show quoted text
> t/001Basic.......9/? > # Failed test 'match expected value' > # at t/001Basic.t line 103. > # got: '1080462360:5.59999999999999964' > # expected: '1080462360:5.6'
One idea would be to rewrite that test to check, vor the $value part, not if is($val, $expected_value, 'match expected value'); but something like: ok(abs($val - $expected_value) < 1e-14,'match expected value'): but then the $time:$val has to be somehow reparted? Bests Salvatore