Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 43001
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: shay [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Don't check compiler version when embedding manifest file
The attached patch applies the EU-MM parts of the following two core commits to EU-MM: http://perl5.git.perl.org/perl.git/commit/4adc95e http://perl5.git.perl.org/perl.git/commit/200cbd6
Subject: eu-mm.patch
Index: lib/ExtUtils/MM_Win32.pm =================================================================== --- lib/ExtUtils/MM_Win32.pm (revision 4362) +++ lib/ExtUtils/MM_Win32.pm (working copy) @@ -338,13 +338,10 @@ q{ $(LD) -out:$@ $(LDDLFLAGS) }.$ldfrom.q{ $(OTHERLDFLAGS) } .q{$(MYEXTLIB) $(PERL_ARCHIVE) $(LDLOADLIBS) -def:$(EXPORT_LIST)}); - # VS2005 (aka VC 8) or higher, but not for 64-bit compiler from Platform SDK - if ($Config{ivsize} == 4 && $Config{cc} eq 'cl' and $Config{ccversion} =~ /^(\d+)/ and $1 >= 14) - { - push(@m, - q{ - mt -nologo -manifest $@.manifest -outputresource:$@;2 && del $@.manifest}); - } + # Embed the manifest file if it exists + push(@m, q{ + if exist $@.manifest mt -nologo -manifest $@.manifest -outputresource:$@;2 + if exist $@.manifest del $@.manifest}); } push @m, ' $(CHMOD) $(PERM_RWX) $@
I believe this was already done by pulling in rt.perl.org 61492 in 6.50. Please confirm.
Yes, the changes requested here are indeed in 6.50. Thanks.
Doh! I did ask it to leave the status as "Resolved (Unchanged)"...