Skip Menu |

This queue is for tickets about the X-Osd CPAN distribution.

Report information
The Basics
Id: 42943
Status: resolved
Priority: 0/
Queue: X-Osd

People
Owner: Nobody in particular
Requestors: janus [...] errornet.de
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.7
Fixed in: (no value)



Subject: Patch to fix use of barewords in tests
The attached patch replaces bareword strings with properly quoted ones. This silences warnings like ``Unquoted string "red" may clash with future reserved word at t/1-basic.t line 61.'' Kind regards, Simon
Subject: t_1-basic_t.diff
--- t/1-basic.t.orig Tue Sep 16 09:36:13 2008 +++ t/1-basic.t Tue Sep 16 09:36:30 2008 @@ -58,7 +58,7 @@ print(($@ ? 'not ok' : 'ok'), ' ', ($test_count++), "\ print(($@ ? 'not ok' : 'ok'), ' ', ($test_count++), "\n"); eval { - $osd->set_colour(red); + $osd->set_colour('red'); $osd->string(0, 'Red test line 1'); delay(); $osd->string(1, 'Red test line 2'); @@ -82,7 +82,7 @@ eval { $osd->set_shadow_offset(4); $osd->string(1, 'Shadow colour test 1'); delay(); - $osd->set_shadow_colour(green); + $osd->set_shadow_colour('green'); $osd->string(2, 'Shadow colour test 2'); delay(); }; @@ -99,7 +99,7 @@ print (($@ ? 'not ok' : 'ok'), ' ', ($test_count++), " eval { $osd->set_shadow_offset(0); - $osd->set_outline_colour(blue); + $osd->set_outline_colour('blue'); $osd->set_outline_offset(2); $osd->string(1, 'Outline colour and offset test 1'); delay(1);
Thanks! It will be in the next X-Osd release.