Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Business-ISBN CPAN distribution.

Report information
The Basics
Id: 42758
Status: resolved
Priority: 0/
Queue: Business-ISBN

People
Owner: Nobody in particular
Requestors: ovid [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.04
Fixed in: (no value)



Subject: t/isbn10.t failing "English" versus "English Speaking Area" comparison
A number of installs report report t/isbn10.t failing with errors such as got: "English Speaking Area", expected: "English". This is because this module was apparently developed on a machine with an older version of Business::ISBN::Data installed. This older version has %country_data defined as: %country_data = ( 0 => [ 'English', [ '00'=>19, 200=>699, 7000=>8499, 85000=>89999, 900000=>949999, 9500000=>9999999, ] ], 1 => [ 'English', [ 4000 => 4154, 55000=>86979, 869800=>998999, 9999900=>9999999]], 2 => [ 'French', [ '00'=>19, 200=>399, 500=>699, 7000=>8399, 84000=>89999, 900000=>949999, 9500000=>9999999]], <snip> Newer versions have: %country_data = ( 0 => ['English speaking area' => ['00' => '19', '200' => '699', '7000' => '8499', '85000' => '89999', '900000' => '949999' , '9500000' => '9999999'] ], 1 => ['English speaking area' => ['00' => '09', '100' => '399', '4000' => '5499', '55000' => '86979', '869800' => '998999'] ], 2 => ['French speaking area' => ['00' => '19', '200' => '349', '35000' => '39999', '400' => '699', '7000' => '8399', '84000' => '89999', '900000' => '949999', '9500000' => '9999999'] ], <snip> Update Business::ISBN::Data on your development box and you can get the failures, too :) (Sorry there's no patch. I'm in a hurry and just did a 'force install' instead) Cheers, Ovid
Fixed in 2.05.
Subject: Re: [rt.cpan.org #42758] t/isbn10.t failing "English" versus "English Speaking Area" comparison
Date: Sat, 24 Jan 2009 23:58:18 -0600
To: bug-Business-ISBN [...] rt.cpan.org
From: brian d foy <bdfoy [...] cpan.org>
On Sat, Jan 24, 2009 at 11:58 AM, Curtis 'Ovid' Poe via RT <bug-Business-ISBN@rt.cpan.org> wrote: Show quoted text
> > A number of installs report report t/isbn10.t failing with errors such > as got: "English Speaking Area", expected: "English". > > This is because this module was apparently developed on a machine with > an older version of Business::ISBN::Data installed.
Actually, that's a bit backwards. I updated Business::ISBN::Data without an update to Business::ISBN. Show quoted text
> (Sorry there's no patch. I'm in a hurry and just did a 'force install' > instead)
No worries. It's been fixed in source control for awhile. -- brian d foy <brian.d.foy@gmail.com> http://www.pair.com/~comdog/