Skip Menu |

This queue is for tickets about the DBIx-SearchBuilder CPAN distribution.

Report information
The Basics
Id: 427
Status: resolved
Worked: 10 min
Priority: 0/
Queue: DBIx-SearchBuilder

People
Owner: Nobody in particular
Requestors: tibbetts [...] terc.edu
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: DBIx::SearchBuilder::Handle->Insert should be renamed.
DBIx::SearchBuilder::Handle has an Insert method, that inserts a row in the database and returns the statement handle. This method is designed to be called by subclasses. Its subclasses all have insert methods that insert something, and then return its id. These methods are designed to be called by clients. These two methods should have different names.
Hello, You're right that behaviour for base class and sub-classes is different and it's bad in theory, but we can not change this as it will potentially break backwards compatibility. I don't believe any DB will work without custom subclass of the base Handle. I'm rejecting this ticket. On Thu Mar 28 17:18:31 2002, guest wrote: Show quoted text
> DBIx::SearchBuilder::Handle has an Insert method, that inserts a row > in the database and returns the statement handle. This method is > designed to be called by subclasses. > > Its subclasses all have insert methods that insert something, and then > return its id. These methods are designed to be called by clients. > > These two methods should have different names.
-- Best regards, Ruslan.