Skip Menu |

This queue is for tickets about the CPANPLUS-Dist-Build CPAN distribution.

Report information
The Basics
Id: 42670
Status: resolved
Worked: 15 min
Priority: 0/
Queue: CPANPLUS-Dist-Build

People
Owner: BINGOS [...] cpan.org
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Fix "module_name not a class method" warning
As documented here: http://www.nntp.perl.org/group/perl.perl5.porters/2009/01/msg143431.html t/02_CPANPLUS-Dist-Build.t is calling a private method in Module::Build which is now generating warnings. I submitted a patch against blead here: http://www.nntp.perl.org/group/perl.perl5.porters/2009/01/msg143436.html This patch calls the appropriate API for determining 'C_support'. I have also attached the patch here.
Subject: 0001-Fix-module_name-not-a-class-method-warning.patch
From 334ffe5cff9da8651d921b8ef37eda6ef51eb468 Mon Sep 17 00:00:00 2001 From: Jerry D. Hedden <jdhedden@cpan.org> Date: Thu, 15 Jan 2009 15:26:53 -0500 Subject: [PATCH] Fix "module_name not a class method" warning Use the proper Module::Build API for detecting 'C_support' --- lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) mode change 100644 => 100755 lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t diff --git a/lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t b/lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t old mode 100644 new mode 100755 index 2c64905..80ce154 --- a/lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t +++ b/lib/CPANPLUS/Dist/Build/t/02_CPANPLUS-Dist-Build.t @@ -133,7 +133,8 @@ while( my($path,$need_cc) = each %Map ) { "-- skipping compile tests", 5) if $need_cc && !$Have_CC; skip("Module::Build is not compiled with C support ". "-- skipping compile tests", 5) - unless Module::Build->_mb_feature('C_support'); + unless eval { require Module::Build::ConfigData; + Module::Build::ConfigData->feature('C_support') }; ok( $mod->create( ), "Creating module" ); ok( $mod->status->dist_cpan->status->created, -- 1.6.0.4
Hey Jerry, thanks for the patch. CPANLUS::Dist::Build is it's own distribution, so I moved it over to the proper queue, so the maintainers can take a look at it. Cheers,
Fixed as of development release 0.06_04. Many thanks. Bingos