Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Prereq CPAN distribution.

Report information
The Basics
Id: 42539
Status: resolved
Priority: 0/
Queue: Test-Prereq

People
Owner: Nobody in particular
Requestors: bpphillips+bitcard [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.025
Fixed in: (no value)



When ignoring modules that have been use'd because they're included in distributions that have already been listed as a dependency, the loop is using the wrong array ref (loopking of @$skip instead of @$modules). As an example, this can be reproduced by running the test against a distribution that lists "Moose" as a dependency but has a "use Moose::Util::TypeConstraints" somewhere in the code. Obviously, this module is included in the "Moose" distribution and the code itself is "expanding" the Moose distribution to list all the modules included but it's simply not looping over the right list of modules.
Subject: 0001-loop-over-the-correct-set-of-modules.patch
From d4bacc8564db14726356741a68e355cbfe18f075 Mon Sep 17 00:00:00 2001 From: Brian Phillips <bphillips@digitalriver.com> Date: Mon, 19 Jan 2009 14:24:22 -0600 Subject: [PATCH] loop over the correct set of modules --- lib/Prereq.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Prereq.pm b/lib/Prereq.pm index 8165dc0..a837997 100644 --- a/lib/Prereq.pm +++ b/lib/Prereq.pm @@ -266,7 +266,7 @@ sub _prereq_check { my $modules = $class->_get_from_prereqs( $prereqs ); - foreach my $module ( @$skip ) + foreach my $module ( @$modules ) { delete $loaded->{$module}; } -- 1.6.0.2
Patch applied and uploaded as version 1.036. Thanks,