Skip Menu |

This queue is for tickets about the Net-Proxy CPAN distribution.

Report information
The Basics
Id: 42525
Status: resolved
Priority: 0/
Queue: Net-Proxy

People
Owner: Nobody in particular
Requestors: peter.oliver [...] eon-is.co.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.12
Fixed in: 0.13



Subject: Spurious "--tunnel <port:host:hostport> format required" error.
The --tunnel option in connect-tunnel rejects some perfectly valid hostnames. For example, any hostname that contains hyphens is not accepted. The attached patch allows these hostnames to be used.
Subject: connect-tunnel-hostname.patch
--- connect-tunnel~ 2007-10-17 23:57:44.000000000 +0100 +++ connect-tunnel 2009-01-19 12:43:20.000000000 +0000 @@ -4,6 +4,7 @@ use Net::Proxy; use Getopt::Long; use Pod::Usage; +use Regexp::Common qw(net); our $VERSION = '0.07'; @@ -50,7 +51,7 @@ for my $tunnel ( @{ $CONF{tunnel} } ) { die "--tunnel <port:host:hostport> format required$/" - if $tunnel !~ /^\d+:[\w.]+:\d+$/; + if $tunnel !~ /^\d+:$RE{net}{domain}:\d+$/; my ( $port, $host, $hostport ) = split ':', $tunnel; my ( $proxy_host, $proxy_port) = split ':', $CONF{proxy};
Subject: Re: [rt.cpan.org #42525] Spurious "--tunnel <port:host:hostport> format required" error.
Date: Mon, 19 Jan 2009 14:34:00 +0100
To: Peter Oliver via RT <bug-Net-Proxy [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <book [...] cpan.org>
On Mon, Jan 19, 2009 at 07:50:43AM -0500, Peter Oliver via RT wrote: Show quoted text
> Mon Jan 19 07:50:41 2009: Request 42525 was acted upon. > Transaction: Ticket created by pdoliver > Queue: Net-Proxy > Subject: Spurious "--tunnel <port:host:hostport> format required" error. > Broken in: 0.12 > Severity: Normal > Owner: Nobody > Requestors: peter.oliver@eon-is.co.uk > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42525 > > > > The --tunnel option in connect-tunnel rejects some perfectly valid > hostnames. For example, any hostname that contains hyphens is not accepted. > > The attached patch allows these hostnames to be used. >
I'll make the regexp even more liberal by using the attached patch. Thanks for your report! -- Philippe Bruhat (BooK) Too many believe only in the belief. (Moral from Groo The Wanderer #58 (Epic))

Message body is not shown because sender requested not to inline it.