Bug #42508 for Curses: Leftover files in 1.26 distribution file

Sun Jan 18 21:52:01 2009 he [...] NetBSD.org - Ticket created

Subject:	Leftover files in 1.26 distribution file
Date:	Mon, 19 Jan 2009 01:12:17 +0100 (CET)
To:	bug-Curses [...] rt.cpan.org
From:	Havard Eidnes <he [...] NetBSD.org>

Hi, it appears you've left Curses.i and Curses.s for i386 in your distribution file for 1.26 -- as part of debugging? Certain other systems than Linux/i386 (?) will be greatly confused, when the Curses.s file is built in preference to Curses.c. :) Regards, - Håvard

Mon Jan 19 11:55:51 2009 bryanh [...] giraffe-data.com - Correspondence added

Subject:	Re: [rt.cpan.org #42508] Leftover files in 1.26 distribution file
Date:	19 Jan 2009 16:54:01 +0000
To:	bug-Curses [...] rt.cpan.org
From:	bryanh [...] giraffe-data.com (Bryan Henderson)

Yes, they are left over from debugging and won't be in the next release. However, does it really pose a danger? I believe Curses.o always gets built from Curses.c. It does for me, anyway. -- Bryan Henderson San Jose, California

Mon Jan 19 11:55:52 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 19 13:06:08 2009 he [...] NetBSD.org - Correspondence added

Subject:	Re: [rt.cpan.org #42508] Leftover files in 1.26 distribution file
Date:	Mon, 19 Jan 2009 19:05:46 +0100 (CET)
To:	bug-Curses [...] rt.cpan.org
From:	Havard Eidnes <he [...] NetBSD.org>

Show quoted text

> Yes, they are left over from debugging and won't be in the next release. > > However, does it really pose a danger? I believe Curses.o always gets > built from Curses.c. It does for me, anyway.

Nope, in my case Curses.o got built from Curses.s, probably due to the default .SUFFIXES setting. I'm doing this update for the NetBSD pkgsrc collection, and once I found out that this was the problem, I added this change to the package Makefile: pre-configure: @${LN} -sf ${WRKSRC}/hints/c-netbsd.ncurses.h ${WRKSRC}/c-config.h + @${RM} -f ${WRKSRC}/Curses.i ${WRKSRC}/Curses.s Regards, - Håvard

Mon Jan 19 22:50:11 2009 bryanh [...] giraffe-data.com - Correspondence added

Subject:	Re: [rt.cpan.org #42508] Leftover files in 1.26 distribution file
Date:	20 Jan 2009 03:43:42 +0000
To:	bug-Curses [...] rt.cpan.org
From:	bryanh [...] giraffe-data.com (Bryan Henderson)

Maybe it's because you're using a different Perl. What version is it? Can you attach your Makefile? My make file (made by Perl 5.6.2 MakeMaker) doesn't have any .s.o rule, so it doesn't matter that .s is in the list of recognized suffixes .SUFFIXES. I'm sure I just have to package up a new version soon without the extraneous files (and an improved make file where 'clean' cleans them up), but I'd still like to understand. -- Bryan Henderson San Jose, California

Tue Jan 20 06:09:57 2009 he [...] NetBSD.org - Correspondence added

Subject:	Re: [rt.cpan.org #42508] Leftover files in 1.26 distribution file
Date:	Tue, 20 Jan 2009 12:09:30 +0100 (CET)
To:	bug-Curses [...] rt.cpan.org
From:	Havard Eidnes <he [...] NetBSD.org>

Show quoted text

> Maybe it's because you're using a different Perl. What version is it?

My perl is version 5.10. Show quoted text

> Can you attach your Makefile?

Sure, follows below. Show quoted text

> My make file (made by Perl 5.6.2 MakeMaker) doesn't have any .s.o rule, so it > doesn't matter that .s is in the list of recognized suffixes .SUFFIXES.

Well, my make is not gnu make, but rather the make from NetBSD. It automatically consults /usr/share/mk/sys.mk, which among other stuff has this rule: .s.o: ${COMPILE.s} ${.IMPSRC} so that rule is applied due to the .SUFFIXES setting in the Makefile. Show quoted text

> I'm sure I just have to package up a new version soon without the extraneous > files (and an improved make file where 'clean' cleans them up), but I'd still > like to understand.

I understand. Regards, - Håvard

Message body is not shown because it is too large.

Tue Jan 20 14:15:43 2009 GIRAFFED [...] cpan.org - Correspondence added

I have released 1.27 without those files, and with a make clean target that will remove them in the future.

Tue Jan 20 14:15:45 2009 GIRAFFED [...] cpan.org - Status changed from 'open' to 'resolved'