Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 42458
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: thaljef [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Remove TODO status on passing tests
I'm just posting this here as a reminder to myself (or anyone else that cares to do it). As of revision 2962, the following TODO tests are passing: Test Summary Report ------------------- t/20_policies (Wstat: 0 Tests: 2296 Failed: 0) TODO passed: 617, 624, 649, 656, 713, 720, 745, 752 777, 784, 873, 880, 969, 976, 1065, 1072 1097, 1104, 1161, 1168, 1193, 1200, 1289 1296, 1321, 1328, 1385, 1392, 1417, 1424 1449, 1456, 1481, 1488, 1513, 1520, 1545 1552, 1577, 1584, 1609, 1616, 1641, 1648 Some of these are due to bug fixes in PPI, others may be due to fixes in Perl-Critic, and still others may be outright bogus tests. Each should probably be examined a little before removing the TODO status.
These are the tests in question (they're all "PPI that supports state variables isn't released yet."). I tried just taking out the TODO lines in t/NamingConventions/Capitalization.run.PL, but then other tests failed. ok 617 - NamingConventions::Capitalization - line 284 - State variable as foreach loop variable named "all_lower_case" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 624 - NamingConventions::Capitalization - line 366 - State variable as C-style for loop variable named "all_lower_case" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 649 - NamingConventions::Capitalization - line 634 - State variable as foreach loop variable named "ALL_UPPER_CASE" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 656 - NamingConventions::Capitalization - line 716 - State variable as C-style for loop variable named "ALL_UPPER_CASE" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 713 - NamingConventions::Capitalization - line 1334 - State variable as foreach loop variable named "a11_lower_case_with_digits" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 720 - NamingConventions::Capitalization - line 1416 - State variable as C-style for loop variable named "a11_lower_case_with_digits" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 745 - NamingConventions::Capitalization - line 1684 - State variable as foreach loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 752 - NamingConventions::Capitalization - line 1766 - State variable as C-style for loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":single_case" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 777 - NamingConventions::Capitalization - line 2034 - State variable as foreach loop variable named "all_lower_case" vs the ":all_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 784 - NamingConventions::Capitalization - line 2116 - State variable as C-style for loop variable named "all_lower_case" vs the ":all_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 873 - NamingConventions::Capitalization - line 3084 - State variable as foreach loop variable named "a11_lower_case_with_digits" vs the ":all_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 880 - NamingConventions::Capitalization - line 3166 - State variable as C-style for loop variable named "a11_lower_case_with_digits" vs the ":all_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 969 - NamingConventions::Capitalization - line 4134 - State variable as foreach loop variable named "ALL_UPPER_CASE" vs the ":all_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 976 - NamingConventions::Capitalization - line 4216 - State variable as C-style for loop variable named "ALL_UPPER_CASE" vs the ":all_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1065 - NamingConventions::Capitalization - line 5184 - State variable as foreach loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":all_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1072 - NamingConventions::Capitalization - line 5266 - State variable as C-style for loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":all_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1097 - NamingConventions::Capitalization - line 5534 - State variable as foreach loop variable named "all_lower_case" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1104 - NamingConventions::Capitalization - line 5616 - State variable as C-style for loop variable named "all_lower_case" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1161 - NamingConventions::Capitalization - line 6234 - State variable as foreach loop variable named "________all_lower_case_with_leading_underscores" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1168 - NamingConventions::Capitalization - line 6316 - State variable as C-style for loop variable named "________all_lower_case_with_leading_underscores" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1193 - NamingConventions::Capitalization - line 6584 - State variable as foreach loop variable named "a11_lower_case_with_digits" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1200 - NamingConventions::Capitalization - line 6666 - State variable as C-style for loop variable named "a11_lower_case_with_digits" vs the ":starts_with_lower" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1289 - NamingConventions::Capitalization - line 7634 - State variable as foreach loop variable named "ALL_UPPER_CASE" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1296 - NamingConventions::Capitalization - line 7716 - State variable as C-style for loop variable named "ALL_UPPER_CASE" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1321 - NamingConventions::Capitalization - line 7984 - State variable as foreach loop variable named "________ALL_UPPER_CASE_WITH_LEADING_UNDERSCORES" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1328 - NamingConventions::Capitalization - line 8066 - State variable as C-style for loop variable named "________ALL_UPPER_CASE_WITH_LEADING_UNDERSCORES" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1385 - NamingConventions::Capitalization - line 8684 - State variable as foreach loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1392 - NamingConventions::Capitalization - line 8766 - State variable as C-style for loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":starts_with_upper" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1417 - NamingConventions::Capitalization - line 9034 - State variable as foreach loop variable named "all_lower_case" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1424 - NamingConventions::Capitalization - line 9116 - State variable as C-style for loop variable named "all_lower_case" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1449 - NamingConventions::Capitalization - line 9384 - State variable as foreach loop variable named "ALL_UPPER_CASE" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1456 - NamingConventions::Capitalization - line 9466 - State variable as C-style for loop variable named "ALL_UPPER_CASE" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1481 - NamingConventions::Capitalization - line 9734 - State variable as foreach loop variable named "mixedCase" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1488 - NamingConventions::Capitalization - line 9816 - State variable as C-style for loop variable named "mixedCase" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1513 - NamingConventions::Capitalization - line 10084 - State variable as foreach loop variable named "________ALL_UPPER_CASE_WITH_LEADING_UNDERSCORES" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1520 - NamingConventions::Capitalization - line 10166 - State variable as C-style for loop variable named "________ALL_UPPER_CASE_WITH_LEADING_UNDERSCORES" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1545 - NamingConventions::Capitalization - line 10434 - State variable as foreach loop variable named "a11_lower_case_with_digits" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1552 - NamingConventions::Capitalization - line 10516 - State variable as C-style for loop variable named "a11_lower_case_with_digits" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1577 - NamingConventions::Capitalization - line 10784 - State variable as foreach loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1584 - NamingConventions::Capitalization - line 10866 - State variable as C-style for loop variable named "A11_UPPER_CASE_WITH_DIGITS" vs the ":no_restriction" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1609 - NamingConventions::Capitalization - line 11134 - State variable as foreach loop variable named "foobar" vs the "foo.*bar" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1616 - NamingConventions::Capitalization - line 11216 - State variable as C-style for loop variable named "foobar" vs the "foo.*bar" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1641 - NamingConventions::Capitalization - line 11484 - State variable as foreach loop variable named "fooXYZZYbar" vs the "foo.*bar" capitalization scheme. # TODO PPI that supports state variables isn't released yet. ok 1648 - NamingConventions::Capitalization - line 11566 - State variable as C-style for loop variable named "fooXYZZYbar" vs the "foo.*bar" capitalization scheme. # TODO PPI that supports state variables isn't released yet.
Subject: Re: [rt.cpan.org #42458] Remove TODO status on passing tests
Date: Sat, 17 Jan 2009 16:27:28 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kyle Hasselbacher via RT wrote: Show quoted text
> These are the tests in question (they're all "PPI that supports state > variables isn't released yet."). I tried just taking out the TODO lines > in t/NamingConventions/Capitalization.run.PL, but then other tests failed.
Yup. It's a mixed situation. It has to do with how PPI currently parses barewords that it doesn't recognize. Rather than sort it out, it's best to just wait for the next PPI release.
Subject: Re: [rt.cpan.org #42458] Remove TODO status on passing tests
Date: Sun, 15 Feb 2009 16:57:42 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
I'm going to assume this branch is dead. We just wait until the next PPI release.
So this turned out to be a non-issue.