Skip Menu |

This queue is for tickets about the Text-Diff CPAN distribution.

Report information
The Basics
Id: 42431
Status: resolved
Priority: 0/
Queue: Text-Diff

People
Owner: NEILB [...] cpan.org
Requestors: frank.wiegand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.35
Fixed in: 1.40



Subject: [patch] warnings running t/general.t
Hi, t/general.t throws warnings: Use of /g modifier is meaningless in split at t/general.t line 129. Use of /g modifier is meaningless in split at t/general.t line 130. The attached patch removes the /g modifier. Thanks, Frank
Subject: general.t.patch
--- t/general.t.old 2009-01-15 10:01:46.000000000 +0100 +++ t/general.t 2009-01-15 10:02:08.000000000 +0100 @@ -126,8 +126,8 @@ warn "# diff options: $diff_opts\n" ; warn "# my options: $Diff_opts\n" ; ## Merge the outputs using A::D - my @E = split /^/g, $expect ; - my @G = split /^/g, $output ; + my @E = split /^/, $expect ; + my @G = split /^/, $output ; my $w = length "Expected" ; for ( @E, @G ) { s/\n/\\n/g ;
This seems to have been fixed some time between 2009 and 2001, possibly when Ovid imported the dist into git...