Bug #4242 for Gtk2: Makefile.PL requirements are incorrect

Thu Oct 30 07:57:52 2003 Guest - Ticket created

Subject:

Makefile.PL requirements are incorrect

PREREQ_PM has trailing "::"s on the module names, which doesn't work. Small patch attached removes the extra "::"s and MakeMaker can properly check the dependencies and CPAN.pm can auot install them.

--- ./Makefile.PL.orig 2003-10-30 12:52:38.000000000 +0000 +++ ./Makefile.PL 2003-10-30 12:52:58.000000000 +0000 @@ -48,9 +48,9 @@ WriteMakefile( PREREQ_FATAL => 1, PREREQ_PM => { - Glib:: => $build_reqs{'perl-Glib'}, - ExtUtils::Depends:: => $build_reqs{'perl-ExtUtils-Depends'}, - ExtUtils::PkgConfig:: => $build_reqs{'perl-ExtUtils-PkgConfig'}, + Glib => $build_reqs{'perl-Glib'}, + ExtUtils::Depends => $build_reqs{'perl-ExtUtils-Depends'}, + ExtUtils::PkgConfig => $build_reqs{'perl-ExtUtils-PkgConfig'}, }, ); exit 1; # not reached @@ -151,9 +151,9 @@ # PREREQ see beginning of file PREREQ_FATAL => 1, PREREQ_PM => { - Glib:: => $build_reqs{'perl-Glib'}, - ExtUtils::Depends:: => $build_reqs{'perl-ExtUtils-Depends'}, - ExtUtils::PkgConfig:: => $build_reqs{'perl-ExtUtils-PkgConfig'}, + Glib => $build_reqs{'perl-Glib'}, + ExtUtils::Depends => $build_reqs{'perl-ExtUtils-Depends'}, + ExtUtils::PkgConfig => $build_reqs{'perl-ExtUtils-PkgConfig'}, }, FUNCLIST => \@exports, DL_FUNCS => { Gtk2 => [] },

Thu Oct 30 09:41:16 2003 Guest - Correspondence added

From:

fergal [...] esatclear.ie

Actually, here's a better patch that removes a bit of redundancy in the way the prereqs are handled, F [guest - Thu Oct 30 07:57:52 2003]: Show quoted text

> PREREQ_PM has trailing "::"s on the module names, which doesn't work. > Small patch attached removes the extra "::"s and MakeMaker can > properly check the dependencies and CPAN.pm can auot install them.

--- ./Makefile.PL.orig 2003-10-30 14:37:34.000000000 +0000 +++ ./Makefile.PL 2003-10-30 14:37:21.000000000 +0000 @@ -23,12 +23,22 @@ use File::Spec; use Cwd; +# perl modules we need in order to build +our %prereq_pm = ( + ExtUtils::Depends => '0.1', + ExtUtils::PkgConfig => '1.00', + Glib => '1.00', +); + # minimum required version of dependancies we need to build +# automatically include the perl dependencies from above our %build_reqs = ( - 'perl-ExtUtils-Depends' => '0.1', - 'perl-ExtUtils-PkgConfig' => '1.00', - 'perl-Glib' => '1.00', 'Gtk+' => '2.0.0', + map { + $version = $prereq_pm{$_}; + s/::/-/g; + ("perl-$_", $version) + } keys %prereq_pm ); # minimum required version of dependancies we need to run @@ -47,11 +57,7 @@ warn "$@\n"; WriteMakefile( PREREQ_FATAL => 1, - PREREQ_PM => { - Glib:: => $build_reqs{'perl-Glib'}, - ExtUtils::Depends:: => $build_reqs{'perl-ExtUtils-Depends'}, - ExtUtils::PkgConfig:: => $build_reqs{'perl-ExtUtils-PkgConfig'}, - }, + PREREQ_PM => \%prereq_pm, ); exit 1; # not reached } @@ -150,11 +156,7 @@ MAN3PODS => \%pod_files, # PREREQ see beginning of file PREREQ_FATAL => 1, - PREREQ_PM => { - Glib:: => $build_reqs{'perl-Glib'}, - ExtUtils::Depends:: => $build_reqs{'perl-ExtUtils-Depends'}, - ExtUtils::PkgConfig:: => $build_reqs{'perl-ExtUtils-PkgConfig'}, - }, + PREREQ_PM => \%prereq_pm, FUNCLIST => \@exports, DL_FUNCS => { Gtk2 => [] }, $gtk2->get_makefile_vars,

Fri Oct 31 05:02:13 2003 pcg [...] goof.com - Correspondence added

Date:	Thu, 30 Oct 2003 23:49:03 +0100
From:	<pcg [...] goof.com ( Marc) (A.) (Lehmann )>
To:	Guest via RT <bug-Gtk2 [...] rt.cpan.org>
CC:	"AdminCc of cpan Ticket #4242": ;
Subject:	Re: [cpan #4242] Makefile.PL requirements are incorrect
RT-Send-Cc:

On Thu, Oct 30, 2003 at 07:57:53AM -0500, Guest via RT <bug-Gtk2@rt.cpan.org> wrote: Show quoted text

> Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=4242 > > > PREREQ_PM has trailing "::"s on the module names, which doesn't work. Small patch attached removes the extra "::"s and MakeMaker can properly check the dependencies and CPAN.pm can auot install them.

This looks like a perl bug, and I can't reproduce it. Anyways, removing the ::'s should be possible, however, it would be interesting to find out which perl version you use, since Gtk2 only works correctly on 5.8 (which unfortunately isn't checked and should be checked), and my only explanation for this is that you use an older version which can't understand the ::'s. -- -----==- | ----==-- _ | ---==---(_)__ __ ____ __ Marc Lehmann +-- --==---/ / _ \/ // /\ \/ / pcg@goof.com |e| -=====/_/_//_/\_,_/ /_/\_\ XX11-RIPE --+ The choice of a GNU generation | |

Tue Jan 25 17:15:51 2005 rmcfarla [...] neces.com - Status changed from 'new' to 'resolved'