Subject: | Can't compile Object.xs, typo "want" should be "wand" |
Hi,
I also emailed you about this a while ago, but here's a bug report.
This is a dup report since other people have reported it. I also offer
a patch below.
Trying to make this version generate the following:
/usr/bin/perl /home/builduser/perl5/lib/perl5/ExtUtils/xsubpp -typemap
/usr/lib/perl5/5.8.5/ExtUtils/typemap Object.xs > Object.xsc && mv
Object.xsc Object.c
gcc -c -D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing
-pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-I/usr/include/gdbm -O2 -g -pipe -m64 -DVERSION=\"1.26\"
-DXS_VERSION=\"1.26\" -fPIC
"-I/usr/lib64/perl5/5.8.5/x86_64-linux-thread-multi/CORE" Object.c
Object.xs: In function `iset_insert_one':
Object.xs:194: warning: cast from pointer to integer of different size
Object.xs:243: warning: cast from pointer to integer of different size
Object.xs: In function `_dispel_magic':
Object.xs:345: error: `want' undeclared (first use in this function)
Object.xs:345: error: (Each undeclared identifier is reported only once
Object.xs:345: error: for each function it appears in.)
Object.xs: In function `iset_remove_one':
Object.xs:541: warning: cast from pointer to integer of different size
Object.xs: In function `XS_Set__Object_includes':
Object.xs:759: warning: cast from pointer to integer of different size
make: *** [Object.o] Error 1
SAMV/Set-Object-1.26.tar.gz
/usr/bin/make -- NOT OK
This is due to what I imagine is a type, you have "want" where you want
"wand" instead. Here's the patch I promised.
--- Object.xs.bak 2009-01-14 15:26:51.000000000 -0600
+++ Object.xs 2009-01-14 15:27:19.000000000 -0600
@@ -342,7 +342,7 @@
I32 i = AvFILLp(wand);
int c = 0;
- assert( SvTYPE(want) == SVt_PVAV );
+ assert( SvTYPE(wand) == SVt_PVAV );
while (i >= 0) {
if (svp[i] && SvIV(svp[i])) {
Should only take you a moment. This is a critical module for our app,
if you don't have the time to fix it, I am happy to help, my cpan author
id is "JJNAPIORK". Feel free to contact me.
Sincerely,
John Napiorkowski