Bug #4238 for CGI-Session-Auth: make test fails with "skip all" message

Wed Oct 29 14:35:47 2003 Guest - Ticket created

Subject:

make test fails with "skip all" message

This was also reported through CPAN testers. 'make test' is failing like this: t/base....ok 2/13Undefined subroutine &main::skip_all called at t/base.t line 14. It seems like the expected syntax is something like this instead: if( $^O eq 'MacOS' ) { plan skip_all => 'Test irrelevant on MacOS'; }

Wed Oct 29 14:46:15 2003 Guest - Correspondence added

Subject:	[PATCH] make test fails with "skip all" message
From:	markstos [...] cpan.org

Attached is a patch which I believe fixes the test. It also adds a dependency on CGI::Session to the Makefile.PL. You may also want to look at "Module::Build" as an alternative to MakeMaker. I find it more pleasant to work with, and it can be configured to be backward compatible.

Wed Oct 29 14:48:04 2003 Guest - Correspondence added

From:

markstos [...] cpan.org

Hmm.. my attachment didn't come through. I'll try pasting it in here. --- CGI-Session-Auth-0.13/Makefile.PL Fri Sep 26 02:30:48 2003 +++ CGI-Session-Auth-0.13-modified/Makefile.PL Wed Oct 29 14:40:02 2003 @@ -6,6 +6,7 @@ 'NAME' => 'CGI::Session::Auth', 'VERSION' => '0.13', PREREQ_PM => { + 'CGI::Session' => 0, 'Digest::MD5' => '0', }, ($] >= 5.005 ? ## Add these new keywords supported since 5.005 diff -r --unified CGI-Session-Auth-0.13/t/base.t CGI-Session-Auth-0.13-modified/t/base.t --- CGI-Session-Auth-0.13/t/base.t Fri Sep 26 08:30:53 2003 +++ CGI-Session-Auth-0.13-modified/t/base.t Wed Oct 29 14:40:02 2003 @@ -1,18 +1,22 @@ -use Test::More tests => 13; - -BEGIN { - use_ok('CGI::Session::Auth'); -} -require_ok('CGI::Session::Auth'); +use Test::More; eval "use CGI"; if ($@) { - skip_all("no CGI module"); + plan skip_all => "no CGI module"; } + eval "use CGI::Session"; if ($@) { - skip_all("no CGI::Session module"); + plan skip_all => "no CGI::Session module"; } + +plan tests => 13; + +BEGIN { + use_ok('CGI::Session::Auth'); +} +require_ok('CGI::Session::Auth'); + my $cgi = new CGI; my $session = new CGI::Session(undef, $cgi, {Directory=>'/tmp'});

Fri Oct 31 03:37:45 2003 geewiz [...] cpan.org - Correspondence added

[guest - Wed Oct 29 14:48:04 2003]: Show quoted text

> Hmm.. my attachment didn't come through. I'll try pasting it in here.

Thanks, Mark. I integrated your patch in 0.14.

Wed Sep 22 14:03:08 2004 geewiz [...] cpan.org - Status changed from 'new' to 'resolved'