Bug #42276 for Acme-Study-Perl: [Patch] POD typos

Sat Jan 10 05:27:57 2009 frank.wiegand [...] gmail.com - Ticket created

Subject:

[Patch] POD typos

Hi, attached is a patch that fixes two small POD typos. Andreas, could you please give me a small response whether the git diff format is okay and applicable or not. Thanks, Frank

Subject:

0001-fix-POD-typo.patch

From 85f15e2022eda029c3ebf733477bf5137f400895 Mon Sep 17 00:00:00 2001 From: Frank Wiegand <fw@hal2.(none)> Date: Sat, 10 Jan 2009 11:13:07 +0100 Subject: [PATCH] fix POD typo --- lib/Acme/Study/Perl.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Acme/Study/Perl.pm b/lib/Acme/Study/Perl.pm index cf6ab9a..7658e43 100644 --- a/lib/Acme/Study/Perl.pm +++ b/lib/Acme/Study/Perl.pm @@ -69,7 +69,7 @@ So far we have defined four characters as hash keys per study: > output @ error ($@) -We have configured Data::Dumpe to write one line and sort the keys +We have configured Data::Dumper to write one line and sort the keys. =cut -- 1.5.6.5

Sat Jan 10 06:15:53 2009 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

Subject:	Re: [rt.cpan.org #42276] [Patch] POD typos
Date:	Sat, 10 Jan 2009 12:15:32 +0100
To:	bug-Acme-Study-Perl [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Sat, 10 Jan 2009 05:27:58 -0500, "Frank Wiegand via RT" <bug-Acme-Study-Perl@rt.cpan.org> said:

Show quoted text

> attached is a patch that fixes two small POD typos.

Thanks! Show quoted text

> Andreas, could you please give me a small response whether the git diff > format is okay and applicable or not.

No, it did not work: % git am ~/Mail/cpan/21821 Applying POD typos error: lib/Acme/Study/Perl.pm: does not match index Patch failed at 0001. I applied the patch manually and added you as author manually. Pushed to repo.or.cz. Thanks again, -- andreas

Sat Jan 10 06:15:54 2009 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 10 07:55:49 2009 frank.wiegand [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #42276] [Patch] POD typos
Date:	Sat, 10 Jan 2009 13:55:23 +0100
To:	bug-Acme-Study-Perl [...] rt.cpan.org
From:	Frank Wiegand <frank.wiegand [...] gmail.com>

Am Samstag, den 10.01.2009, 06:15 -0500 schrieb (Andreas J. Koenig) via RT: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=42276 >

> > Andreas, could you please give me a small response whether the git diff > > format is okay and applicable or not.

> > No, it did not work: > > % git am ~/Mail/cpan/21821 > Applying POD typos > error: lib/Acme/Study/Perl.pm: does not match index > Patch failed at 0001.

Here is what I did: % git clone git://repo.or.cz/acme-study-perl.git acme-study-perl Initialized empty Git repository in /home/fw/src/git/acme-study-perl/.git/ remote: Counting objects: 77, done. Receiving objects: 100% (77/77), 13.10 KiB, done.ts: 41% (32/77) Resolving deltas: 100% (26/26), done. remote: Compressing objects: 100% (41/41), done. remote: Total 77 (delta 26), reused 67 (delta 20) % cd acme-study-perl % git checkout -b fw Switched to a new branch "fw" % vim lib/Acme/Study/Perl.pm % git add lib/Acme/Study/Perl.pm % git commit -m 'fix POD typo' Created commit 85f15e2: fix POD typo 1 files changed, 1 insertions(+), 1 deletions(-) This created the 0001-fix-POD-typo.patch file. Thanks, Frank

Sat Jan 10 15:39:29 2009 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

Subject:	Re: [rt.cpan.org #42276] [Patch] POD typos
Date:	Sat, 10 Jan 2009 21:39:11 +0100
To:	bug-Acme-Study-Perl [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Sat, 10 Jan 2009 07:55:50 -0500, "Frank Wiegand via RT" <bug-Acme-Study-Perl@rt.cpan.org> said:

Show quoted text

> % git commit -m 'fix POD typo' > Created commit 85f15e2: fix POD typo > 1 files changed, 1 insertions(+), 1 deletions(-)

Show quoted text

> This created the 0001-fix-POD-typo.patch file.

I think the reason was that some MTA magled the content a little bit. I did not download your patch file but applied the stored mail and I see the mail had a ">" in the first column, so the patch was not properly starting at the beginning of the line. Next time I'll try to download the patch separately to the rescue. -- andreas