Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 42190
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: user42 [...] zip.com.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: perlcritic.el perlcritic-severity radio group
Date: Wed, 07 Jan 2009 08:07:30 +1100
To: bug-Perl-Critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
In perlcritic.el I think M-x customize-variable of perlcritic-severity doesn't show a radio group because the default `nil' isn't among the available choices. Adding it seems to do the trick.
Index: perlcritic.el =================================================================== --- perlcritic.el (revision 2954) +++ perlcritic.el (working copy) @@ -184,13 +184,13 @@ This variable is automatically buffer-local and may be overridden on a per-file basis with File Variables." - ;; FIXME: My GNU Emacs doesn't show a radio widget or a menu here. :type '(radio (const :tag "Show only the most severe: 5" 5) (const :tag "4" 4) (const :tag "3" 3) (const :tag "2" 2) - (const :tag "Show everything including the least severe: 1" 1)) + (const :tag "Show everything including the least severe: 1" 1) + (const :tag "Default from .perlcriticrc" nil)) :group 'perlcritic) (make-variable-buffer-local 'perlcritic-severity)
Subject: Re: [rt.cpan.org #42190] perlcritic.el perlcritic-severity radio group
Date: Thu, 15 Jan 2009 21:20:31 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kevin Ryde via RT wrote: Show quoted text
> In perlcritic.el I think M-x customize-variable of perlcritic-severity > doesn't show a radio group because the default `nil' isn't among the > available choices. Adding it seems to do the trick.
I have no idea if this works or even compiles, but it's been applied.
Note to self: Ask Josh ben Jore to review changes and test it out.
This has been fixed and released as Perl-Critic-1.095_001 to a CPAN near you. Thanks for reporting this bug. -Jeff