| Subject: | undef warning when create_shortcut (patch attached) |
There is an undef warning spit out in callback_create_shortcut. A patch
is attached.
| Subject: | shortcut.patch |
*** lib/Tk/Wizard/Installer/Win32.pm Wed Jan 23 16:47:18 2008
--- lib/Tk/Wizard/Installer/Win32.pm.martin Fri Jan 2 15:03:31 2009
***************
*** 588,598 ****
$args->{-arguments} = '' unless exists $args->{-arguments};
$args->{-workingdir} = '' unless exists $args->{-workingdir};
$args->{-description} = '' unless exists $args->{-description};
! $args->{-show} = '' unless exists $args->{-show};
$args->{-hotkey} = '' unless exists $args->{-hotkey};
$args->{-iconpath} = '' unless exists $args->{-iconpath};
! $args->{-iconindex} = '' unless exists $args->{-iconindex};
! undef $self->{-program_group} if exists $args->{-no_program_group};
if ( exists $self->{-program_group}
and exists $args->{-save_path} )
--- 588,598 ----
$args->{-arguments} = '' unless exists $args->{-arguments};
$args->{-workingdir} = '' unless exists $args->{-workingdir};
$args->{-description} = '' unless exists $args->{-description};
! $args->{-show} = 0 unless exists $args->{-show};
$args->{-hotkey} = '' unless exists $args->{-hotkey};
$args->{-iconpath} = '' unless exists $args->{-iconpath};
! $args->{-iconindex} = 0 unless exists $args->{-iconindex};
! delete $self->{-program_group} if exists $args->{-no_program_group};
if ( exists $self->{-program_group}
and exists $args->{-save_path} )
***************
*** 600,606 ****
my ( $base, $file ) = $args->{-save_path} =~ /(.*?)([^\/\\]+)$/;
# Historical error on $self->{-program_groups}
! $base .= "\\" . ($self->{-program_groups} || $self->{-program_groups});
mkpath $base if !-e $base;
$args->{-save_path} = $base . "\\" . $file;
--- 600,607 ----
my ( $base, $file ) = $args->{-save_path} =~ /(.*?)([^\/\\]+)$/;
# Historical error on $self->{-program_groups}
! $base .= "\\" . ($self->{-program_group} || $self->{-program_groups});
mkpath $base if !-e $base;
$args->{-save_path} = $base . "\\" . $file;