Skip Menu |

This queue is for tickets about the Text-KwikiFormatish CPAN distribution.

Report information
The Basics
Id: 42090
Status: open
Priority: 0/
Queue: Text-KwikiFormatish
People
Owner: Nobody in particular
Requestors: RUZ [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.11
Fixed in: (no value)

History Show all quoted text
  Thu Jan 01 23:24:10 2009 RUZ [...] cpan.org - Ticket created
Subject: prefix option doesn't work
Subj. "prefix" is not used in format_wiki_link or in other functional code. -- Best regards, Ruslan.
  Sat Jan 03 16:18:57 2009 RUZ [...] cpan.org - Correspondence added
Subject: [PATCH] prefix option doesn't work
Hello, Simple patch that fixes this issue. On Thu Jan 01 23:24:10 2009, RUZ wrote: Show quoted text
> Subj. "prefix" is not used in format_wiki_link or in other functional
code. Show quoted text
>
-- Best regards, Ruslan.
Only in Text-KwikiFormatish-1.11-my/: Makefile Only in Text-KwikiFormatish-1.11-my/: blib diff -ur Text-KwikiFormatish-1.11/lib/Text/KwikiFormatish.pm Text-KwikiFormatish-1.11-my/lib/Text/KwikiFormatish.pm --- Text-KwikiFormatish-1.11/lib/Text/KwikiFormatish.pm 2006-02-12 02:50:42.000000000 +0300 +++ Text-KwikiFormatish-1.11-my/lib/Text/KwikiFormatish.pm 2009-01-03 23:46:09.000000000 +0300 @@ -76,10 +76,9 @@ my ( $raw, %args ) = @_; # create instance of formatter - my $f = __PACKAGE__->new(); - - # translate Text::Wikiformat args to Kwiki formatter args - $f->{_node_prefix} = $args{prefix} if exists $args{prefix}; + my $f = __PACKAGE__->new( + exists $args{prefix}? (node_prefix => $args{prefix}): () + ); # do the deed return $f->process($raw); @@ -400,7 +399,8 @@ sub wiki_link_format { my ( $self, $text ) = @_; my $url = $self->escape($text); - my $wiki_link = qq{<a href="./$url">$text</a>}; + my $prefix = $self->{'_node_prefix'} || './'; + my $wiki_link = qq{<a href="$prefix$url">$text</a>}; return $wiki_link; } Only in Text-KwikiFormatish-1.11-my/: pm_to_blib
  Sat Jan 03 16:18:58 2009 RUZ [...] cpan.org - Status changed from 'new' to 'open'
  Sat Jan 10 02:39:06 2009 ian [...] cpan.org - Correspondence added
Thank you, Ruslan. I have no idea when I'll get around to patching this.
  Sat Jan 10 11:40:01 2009 RUZ [...] cpan.org - Correspondence added
On Sat Jan 10 02:39:06 2009, IAN wrote: Show quoted text
> Thank you, Ruslan. I have no idea when I'll get around to patching this.
If you have no objections on the patch then give me co-maint and I'll release a new version :) -- Best regards, Ruslan.