Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 42088
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: rsoderberg [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Jan 01 21:20:17 2009 rsoderberg [...] gmail.com - Ticket created
Subject: 1.094: make distclean "Not in MANIFEST" due to bash syntax error on "ARRAY(0x8b9bf8)"
Date: Thu, 1 Jan 2009 18:19:58 -0800
To: bug-Perl-Critic [...] rt.cpan.org
From: "Richard Soderberg" <rsoderberg [...] gmail.com>
distclean tries to remove "ARRAY(0x8b9bf8)" which breaks bash and I think causes the "Not in MANIFEST" errors below. - R. # perl Makefile.PL # make all # make distclean /bin/sh: -c: line 0: syntax error near unexpected token `(' /bin/sh: -c: line 0: `rm -rf xt/author/generated/t/07_perlcritic.t_without_optional_dependencies.t xt/author/generated/t/12_theme_listing.t_without_optional_dependencies.t xt/author/generated/t/02_policy.t_without_optional_dependencies.t xt/author/generated/t/01_config_bad_perlcriticrc.t_without_optional_dependencies.t xt/author/generated/t/08_document.t_without_optional_dependencies.t xt/author/generated/t/05_utils_ppi.t_without_optional_dependencies.t Perl-Critic-1.094 t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run ARRAY(0x8b9bf8) lib/Perl/Critic/PolicySummary.pod .... /usr/bin/perl "-MExtUtils::Manifest=fullcheck" -e fullcheck Not in MANIFEST: lib/Perl/Critic/PolicySummary.pod Not in MANIFEST: t/ControlStructures/ProhibitNegativeExpressionsInUnlessAndUntilConditions.run Not in MANIFEST: t/NamingConventions/Capitalization.run Not in MANIFEST: t/Variables/RequireLocalizedPunctuationVars.run
  Thu Jan 01 21:54:55 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #42088] 1.094: make distclean "Not in MANIFEST" due to bash syntax error on "ARRAY(0x8b9bf8)"
Date: Thu, 01 Jan 2009 20:54:37 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Richard Soderberg via RT wrote: Show quoted text
> distclean tries to remove "ARRAY(0x8b9bf8)" which breaks bash and I think > causes the "Not in MANIFEST" errors below.
Don't know what would cause that, but I'm not much interested in the vagaries of ExtUtils::MakeMaker in terms of development (installation is another matter). All development of P::C takes place using Module::Build.
  Thu Jan 01 21:54:56 2009 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 01 22:31:24 2009 rsoderberg [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42088] 1.094: make distclean "Not in MANIFEST" due to bash syntax error on "ARRAY(0x8b9bf8)"
Date: Thu, 1 Jan 2009 19:31:10 -0800
To: bug-Perl-Critic [...] rt.cpan.org
From: "Richard Soderberg" <rsoderberg [...] gmail.com>
This patch fixes it: --- Makefile.PL 2009-01-01 11:41:47.000000000 -0800 +++ /Users/coral/Perl-Critic-1.094/Makefile.PL 2009-01-01 19:29:44.000000000 -0800 @@ -85,7 +85,7 @@ FILES => join q< >, - values %{ get_PL_files() }, + (map { (ref $_ eq 'ARRAY') ? @{$_} : $_ } values %{ get_PL_files() }), test_wrappers_to_generate(), }, ); On Thu, Jan 1, 2009 at 6:54 PM, Elliot Shank via RT < bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=42088 > > > Richard Soderberg via RT wrote:
> > distclean tries to remove "ARRAY(0x8b9bf8)" which breaks bash and I think > > causes the "Not in MANIFEST" errors below.
> > Don't know what would cause that, but I'm not much interested in the > vagaries of ExtUtils::MakeMaker in terms of development (installation is > another matter). All development of P::C takes place using Module::Build. > >
  Thu Jan 01 22:59:42 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #42088] 1.094: make distclean "Not in MANIFEST" due to bash syntax error on "ARRAY(0x8b9bf8)"
Date: Thu, 01 Jan 2009 21:59:30 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Applied. Thank you.
  Sun Jan 18 21:36:41 2009 thaljef [...] cpan.org - Correspondence added
This has been fixed and released as Perl-Critic-1.095_001 to a CPAN near you. Thanks for reporting this bug. -Jeff
  Sun Jan 18 21:36:42 2009 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'