Skip Menu |

This queue is for tickets about the Tk-Wizard CPAN distribution.

Report information
The Basics
Id: 42080
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: Tk-Wizard
People
Owner: LGODDARD [...] cpan.org
Requestors: ANDK [...] cpan.org
Cc: SREZIC [...] cpan.org
AdminCc:
Bug Information
Severity: Critical
Broken in:
  • 2.143
  • 2.144
Fixed in: (no value)

History Show all quoted text
  Thu Jan 01 09:42:35 2009 ANDK [...] cpan.org - Ticket created
Subject: Broken tarball
Your tarball has totally broken permissions which prevents proceeding on my GNU/Debian system: % LANG=C ls -la Tk-Wizard-2.143 ls: cannot access Tk-Wizard-2.143/.: Permission denied ls: cannot access Tk-Wizard-2.143/..: Permission denied ls: cannot access Tk-Wizard-2.143/Changes: Permission denied ls: cannot access Tk-Wizard-2.143/examples: Permission denied ls: cannot access Tk-Wizard-2.143/inc: Permission denied ls: cannot access Tk-Wizard-2.143/lib: Permission denied ls: cannot access Tk-Wizard-2.143/Makefile.PL: Permission denied ls: cannot access Tk-Wizard-2.143/MANIFEST: Permission denied ls: cannot access Tk-Wizard-2.143/MANIFEST.skip: Permission denied ls: cannot access Tk-Wizard-2.143/META.yml: Permission denied ls: cannot access Tk-Wizard-2.143/README: Permission denied ls: cannot access Tk-Wizard-2.143/RELEASE_PROCEDURE: Permission denied ls: cannot access Tk-Wizard-2.143/t: Permission denied ls: cannot access Tk-Wizard-2.143/TODO: Permission denied total 0 d????????? ? ? ? ? ? ./ d????????? ? ? ? ? ? ../ -????????? ? ? ? ? ? Changes -????????? ? ? ? ? ? MANIFEST -????????? ? ? ? ? ? MANIFEST.skip -????????? ? ? ? ? ? META.yml -????????? ? ? ? ? ? Makefile.PL -????????? ? ? ? ? ? README -????????? ? ? ? ? ? RELEASE_PROCEDURE -????????? ? ? ? ? ? TODO d????????? ? ? ? ? ? examples/ d????????? ? ? ? ? ? inc/ d????????? ? ? ? ? ? lib/ d????????? ? ? ? ? ? t/ All files and directories have the permissions rw-rw-rw- which disables stepping through directories even for the owner. Thanks,
  Thu Jan 01 12:29:09 2009 SREZIC [...] cpan.org - Correspondence added
On Thu Jan 01 09:42:35 2009, ANDK wrote: Show quoted text
> Your tarball has totally broken permissions which prevents proceeding on > my GNU/Debian system: > > % LANG=C ls -la Tk-Wizard-2.143 > ls: cannot access Tk-Wizard-2.143/.: Permission denied > ls: cannot access Tk-Wizard-2.143/..: Permission denied > ls: cannot access Tk-Wizard-2.143/Changes: Permission denied > ls: cannot access Tk-Wizard-2.143/examples: Permission denied > ls: cannot access Tk-Wizard-2.143/inc: Permission denied > ls: cannot access Tk-Wizard-2.143/lib: Permission denied > ls: cannot access Tk-Wizard-2.143/Makefile.PL: Permission denied > ls: cannot access Tk-Wizard-2.143/MANIFEST: Permission denied > ls: cannot access Tk-Wizard-2.143/MANIFEST.skip: Permission denied > ls: cannot access Tk-Wizard-2.143/META.yml: Permission denied > ls: cannot access Tk-Wizard-2.143/README: Permission denied > ls: cannot access Tk-Wizard-2.143/RELEASE_PROCEDURE: Permission denied > ls: cannot access Tk-Wizard-2.143/t: Permission denied > ls: cannot access Tk-Wizard-2.143/TODO: Permission denied > total 0 > d????????? ? ? ? ? ? ./ > d????????? ? ? ? ? ? ../ > -????????? ? ? ? ? ? Changes > -????????? ? ? ? ? ? MANIFEST > -????????? ? ? ? ? ? MANIFEST.skip > -????????? ? ? ? ? ? META.yml > -????????? ? ? ? ? ? Makefile.PL > -????????? ? ? ? ? ? README > -????????? ? ? ? ? ? RELEASE_PROCEDURE > -????????? ? ? ? ? ? TODO > d????????? ? ? ? ? ? examples/ > d????????? ? ? ? ? ? inc/ > d????????? ? ? ? ? ? lib/ > d????????? ? ? ? ? ? t/ > > > All files and directories have the permissions rw-rw-rw- which disables > stepping through directories even for the owner. >
This seems to happen quite often recently. These tickets report the same problem: [rt.cpan.org #32099] [rt.cpan.org #38376] [rt.cpan.org #41176] [rt.cpan.org #41433] And in my "DISABLED" distropref file there are more references (though mostly solved in the meantime). So maybe there's something which should be solved earlier, maybe in the "make dist" rule created by ExtUtils::MakeMaker? Regards, Slaven
  Thu Jan 01 12:29:10 2009 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 01 12:29:47 2009 SREZIC [...] cpan.org - Cc SREZIC added
  Thu Jan 01 12:50:54 2009 leegee [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42080] Broken tarball
Date: Thu, 01 Jan 2009 18:50:40 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
Thank you very much for that report. I did the usual make tardist I always do, must be something to do with a new default on newly installed GNU Win32 binaries of tar/gzip. Will, of course, look into it, Lee Andreas Koenig via RT wrote: Show quoted text
> Thu Jan 01 09:42:35 2009: Request 42080 was acted upon. > Transaction: Ticket created by ANDK > Queue: Tk-Wizard > Subject: Broken tarball > Broken in: 2.143 > Severity: Important > Owner: Nobody > Requestors: ANDK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42080 > > > > Your tarball has totally broken permissions which prevents proceeding on > my GNU/Debian system: > > % LANG=C ls -la Tk-Wizard-2.143 > ls: cannot access Tk-Wizard-2.143/.: Permission denied > ls: cannot access Tk-Wizard-2.143/..: Permission denied > ls: cannot access Tk-Wizard-2.143/Changes: Permission denied > ls: cannot access Tk-Wizard-2.143/examples: Permission denied > ls: cannot access Tk-Wizard-2.143/inc: Permission denied > ls: cannot access Tk-Wizard-2.143/lib: Permission denied > ls: cannot access Tk-Wizard-2.143/Makefile.PL: Permission denied > ls: cannot access Tk-Wizard-2.143/MANIFEST: Permission denied > ls: cannot access Tk-Wizard-2.143/MANIFEST.skip: Permission denied > ls: cannot access Tk-Wizard-2.143/META.yml: Permission denied > ls: cannot access Tk-Wizard-2.143/README: Permission denied > ls: cannot access Tk-Wizard-2.143/RELEASE_PROCEDURE: Permission denied > ls: cannot access Tk-Wizard-2.143/t: Permission denied > ls: cannot access Tk-Wizard-2.143/TODO: Permission denied > total 0 > d????????? ? ? ? ? ? ./ > d????????? ? ? ? ? ? ../ > -????????? ? ? ? ? ? Changes > -????????? ? ? ? ? ? MANIFEST > -????????? ? ? ? ? ? MANIFEST.skip > -????????? ? ? ? ? ? META.yml > -????????? ? ? ? ? ? Makefile.PL > -????????? ? ? ? ? ? README > -????????? ? ? ? ? ? RELEASE_PROCEDURE > -????????? ? ? ? ? ? TODO > d????????? ? ? ? ? ? examples/ > d????????? ? ? ? ? ? inc/ > d????????? ? ? ? ? ? lib/ > d????????? ? ? ? ? ? t/ > > > All files and directories have the permissions rw-rw-rw- which disables > stepping through directories even for the owner. > > Thanks, > > > >
  Thu Jan 01 12:52:57 2009 leegee [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42080] Broken tarball
Date: Thu, 01 Jan 2009 18:52:44 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
Slaven_Rezic via RT wrote: Show quoted text
> Queue: Tk-Wizard > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42080 > > > On Thu Jan 01 09:42:35 2009, ANDK wrote: >
>> Your tarball has totally broken permissions which prevents proceeding on >> my GNU/Debian system: >> >> % LANG=C ls -la Tk-Wizard-2.143 >> ls: cannot access Tk-Wizard-2.143/.: Permission denied >> ls: cannot access Tk-Wizard-2.143/..: Permission denied >> ls: cannot access Tk-Wizard-2.143/Changes: Permission denied >> ls: cannot access Tk-Wizard-2.143/examples: Permission denied >> ls: cannot access Tk-Wizard-2.143/inc: Permission denied >> ls: cannot access Tk-Wizard-2.143/lib: Permission denied >> ls: cannot access Tk-Wizard-2.143/Makefile.PL: Permission denied >> ls: cannot access Tk-Wizard-2.143/MANIFEST: Permission denied >> ls: cannot access Tk-Wizard-2.143/MANIFEST.skip: Permission denied >> ls: cannot access Tk-Wizard-2.143/META.yml: Permission denied >> ls: cannot access Tk-Wizard-2.143/README: Permission denied >> ls: cannot access Tk-Wizard-2.143/RELEASE_PROCEDURE: Permission denied >> ls: cannot access Tk-Wizard-2.143/t: Permission denied >> ls: cannot access Tk-Wizard-2.143/TODO: Permission denied >> total 0 >> d????????? ? ? ? ? ? ./ >> d????????? ? ? ? ? ? ../ >> -????????? ? ? ? ? ? Changes >> -????????? ? ? ? ? ? MANIFEST >> -????????? ? ? ? ? ? MANIFEST.skip >> -????????? ? ? ? ? ? META.yml >> -????????? ? ? ? ? ? Makefile.PL >> -????????? ? ? ? ? ? README >> -????????? ? ? ? ? ? RELEASE_PROCEDURE >> -????????? ? ? ? ? ? TODO >> d????????? ? ? ? ? ? examples/ >> d????????? ? ? ? ? ? inc/ >> d????????? ? ? ? ? ? lib/ >> d????????? ? ? ? ? ? t/ >> >> >> All files and directories have the permissions rw-rw-rw- which disables >> stepping through directories even for the owner. >> >>
> > This seems to happen quite often recently. These tickets report the same > problem: > > [rt.cpan.org #32099] > [rt.cpan.org #38376] > [rt.cpan.org #41176] > [rt.cpan.org #41433] > > And in my "DISABLED" distropref file there are more references (though > mostly solved in the meantime). > > So maybe there's something which should be solved earlier, maybe in the > "make dist" rule created by ExtUtils::MakeMaker? >
Thanks, Slaven. If it helps, I was using a fresh download of GNU Win32 tar and gzip, and Perl 5.10. I am going back to 5.8, since 5.10 causes me problems with CPAN.pm and YAML that I haven't got time to look into. I'll rebuild the dist, and repost, and hopefully that will generate test reports that may help in tracking down any greater problem. Cheers, Lee Show quoted text
> Regards, > Slaven > > >
  Thu Jan 01 15:36:58 2009 SREZIC [...] cpan.org - Correspondence added
On Thu Jan 01 12:52:57 2009, leegee@gmail.com wrote: Show quoted text
> Slaven_Rezic via RT wrote:
> > Queue: Tk-Wizard > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42080 > > >
[...] Show quoted text
> > > > This seems to happen quite often recently. These tickets report the same > > problem: > > > > [rt.cpan.org #32099] > > [rt.cpan.org #38376] > > [rt.cpan.org #41176] > > [rt.cpan.org #41433] > > > > And in my "DISABLED" distropref file there are more references (though > > mostly solved in the meantime). > > > > So maybe there's something which should be solved earlier, maybe in the > > "make dist" rule created by ExtUtils::MakeMaker? > >
> Thanks, Slaven. If it helps, I was using a fresh download of GNU Win32 > tar and gzip, and Perl 5.10. I am going back to 5.8, since 5.10 causes > me problems with CPAN.pm and YAML that I haven't got time to look into. > I'll rebuild the dist, and repost, and hopefully that will generate test > reports that may help in tracking down any greater problem. >
2.144 has the same problem. I vaguely remember that people said that the newest GNU Win32 tar is causing the problem. So a downgrade will probably help. Maybe it could also help if you could create the archive using Archive::Tar, but I don't know if this is possible through "make dist". Regards, Slaven
  Thu Jan 01 16:09:42 2009 leegee [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42080] Broken tarball
Date: Thu, 01 Jan 2009 22:08:49 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
Slaven_Rezic via RT wrote: Show quoted text
> Queue: Tk-Wizard > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42080 > > > On Thu Jan 01 12:52:57 2009, leegee@gmail.com wrote: >
>> Slaven_Rezic via RT wrote: >>
>>> Queue: Tk-Wizard >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42080 > >>> >>>
> [...] >
>>> This seems to happen quite often recently. These tickets report the same >>> problem: >>> >>> [rt.cpan.org #32099] >>> [rt.cpan.org #38376] >>> [rt.cpan.org #41176] >>> [rt.cpan.org #41433] >>> >>> And in my "DISABLED" distropref file there are more references (though >>> mostly solved in the meantime). >>> >>> So maybe there's something which should be solved earlier, maybe in the >>> "make dist" rule created by ExtUtils::MakeMaker? >>> >>>
>> Thanks, Slaven. If it helps, I was using a fresh download of GNU Win32 >> tar and gzip, and Perl 5.10. I am going back to 5.8, since 5.10 causes >> me problems with CPAN.pm and YAML that I haven't got time to look into. >> I'll rebuild the dist, and repost, and hopefully that will generate test >> reports that may help in tracking down any greater problem. >> >>
> > 2.144 has the same problem. I vaguely remember that people said that the > newest GNU Win32 tar is causing the problem. So a downgrade will > probably help. Maybe it could also help if you could create the archive > using Archive::Tar, but I don't know if this is possible through "make > dist". >
Just read the report from PAUSE, will downgrade the GNU binaries and try again tomorrow. If that fails, Archive::Tar it is (by hand). Thanks for your help, Lee
  Fri Jan 02 05:36:49 2009 leegee [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42080] Broken tarball
Date: Fri, 02 Jan 2009 11:36:32 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
Show quoted text
> .....So a downgrade will probably help. .....
Downgrade to previous version did not help, which surprises me as I am sure I was using it without issue. Seems this is a known issue, and the advice is to switch to bsdtar, which I will try now: http://sourceforge.net/forum/message.php?msg_id=4028811
  Fri Jan 02 05:50:54 2009 LGODDARD [...] cpan.org - Taken
  Fri Jan 02 05:51:31 2009 LGODDARD [...] cpan.org - TimeWorked changed from (no value) to '20'
  Fri Jan 02 05:51:32 2009 LGODDARD [...] cpan.org - Severity Important changed to Critical
  Fri Jan 02 05:51:32 2009 LGODDARD [...] cpan.org - Broken in 2.144 added
  Fri Jan 02 05:54:17 2009 LGODDARD [...] cpan.org - Correspondence added 10 min
Switching to bsdtar (ExtUtils::MM_Unix::init_dist $self->{TAR}) did not help: The following report has been written by the PAUSE namespace indexer. Please contact modules@perl.org if there are any open questions. Id: mldistwatch.pm 1083 2009-01-01 14:03:08Z k User: LGODDARD (Lee Goddard) Distribution file: Tk-Wizard-2.144_bsdtar.tar.gz Number of files: 60 *.pm files: 16 README: Tk-Wizard-2.144_bsdtar/README META.yml: Tk-Wizard-2.144_bsdtar/META.yml META-driven index: no Timestamp of file: Fri Jan 2 10:49:53 2009 UTC Time of this run: Fri Jan 2 10:51:25 2009 UTC The distribution contains the following world writable directories or files and is therefore considered a security breach and as such not being indexed:
  Fri Jan 02 06:10:28 2009 LGODDARD [...] cpan.org - Correspondence added
Am using the code at http://perlmonks.org/index.pl?node_id=731935 Might be able to get this into my Makefile.PL postamble.
  Fri Jan 02 06:39:32 2009 LGODDARD [...] cpan.org - Correspondence added 30 min
The fix recommended by PAUSE - using Archive::Tar to post-process the GNU Win32 tar archive - works. The script has been stripped and included as fix.pl (attached). This ought to be added as a makefile target, via the postamble in the Makefile.PL. Thanks to 'bart' for bothering to write it. The following report has been written by the PAUSE namespace indexer. Please contact modules@perl.org if there are any open questions. Id: mldistwatch.pm 1083 2009-01-01 14:03:08Z k User: LGODDARD (Lee Goddard) Distribution file: Tk-Wizard-2.145.tar.gz Number of files: 60 *.pm files: 16 README: Tk-Wizard-2.145/README META.yml: Tk-Wizard-2.145/META.yml META-driven index: no Timestamp of file: Fri Jan 2 11:27:54 2009 UTC Time of this run: Fri Jan 2 11:29:31 2009 UTC Status of this distro: OK ========================= The following packages (grouped by status) have been found in the distro: Status: Successfully indexed ============================ module: Tk::Wizard version: 2.084 in file: Tk-Wizard-2.145/lib/Tk/Wizard.pm status: indexed module: Tk::Wizard::Choices version: 2.076 in file: Tk-Wizard-2.145/lib/Tk/Wizard/Choices.pm status: indexed module: Tk::Wizard::FileSystem version: 2.076 in file: Tk-Wizard-2.145/lib/Tk/Wizard/FileSystem.pm status: indexed module: Tk::Wizard::Image version: 2.008 in file: Tk-Wizard-2.145/lib/Tk/Wizard/Image.pm status: indexed module: Tk::Wizard::Installer version: 2.038 in file: Tk-Wizard-2.145/lib/Tk/Wizard/Installer.pm status: indexed module: Tk::Wizard::Installer::Win32 version: 2.018 in file: Tk-Wizard-2.145/lib/Tk/Wizard/Installer/Win32.pm status: indexed module: Tk::Wizard::Tasks version: 2.079 in file: Tk-Wizard-2.145/lib/Tk/Wizard/Tasks.pm status: indexed __END__
use warnings; use strict; use Archive::Tar; $Archive::Tar::DO_NOT_USE_PREFIX = 1; =head1 NAME fix.pl =head1 DESCRIPTION This code found at http://perlmonks.org/index.pl?node_id=731935 via PAUSE's reports of failed uploads. The author wrote: I found it way too hard to try to make Getopt::Std and Getopt::Long behave as I'd like It's much easier to just implement command line options parsing by h and... Careful: you cannot combine several single letter command line optio ns into one, They must stay separate. I have removed command line options: the script now just takes the path to a tarball to fix. =cut # DISTVNAME while(@ARGV) { my $dist = shift; $dist =~ /\.t(ar\.)?gz$/ or die "Wrong argument: '$dist'; please provide a '.tar.gz' file as argument"; print "Loading distribution '$dist'\n"; my $fixes; my $tar = Archive::Tar->new; $tar->read($dist); my @files = $tar->get_files; foreach my $file (@files) { my $fixedmode = my $mode = $file->mode; my $filetype = ''; if($file->is_file) { $filetype = 'file'; if(substr(${ $file->get_content_by_ref }, 0, 2) eq '#!') { $fixedmode = 0775; } else { $fixedmode = 0664; } } elsif($file->is_dir) { $filetype = 'dir'; $fixedmode = 0775; } else { next; } next if $mode eq $fixedmode; $file->mode($fixedmode); $fixes++; printf "Change mode %03o to %03o for %s '%s'\n", $mode, $fixedmode, $filetype, $file->name; } if ($fixes) { rename $dist, "$dist.bak" or die "Cannot rename file '$dist' to '$dist.bak': $!"; $tar->write($dist, 9); print "File '$dist' saved.\n"; } else { print "File '$dist' didn't need fixing, skipped.\n"; } }
  Fri Jan 02 06:39:33 2009 LGODDARD [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Jan 02 13:56:53 2009 leegee [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #42080] Broken tarball
Date: Fri, 02 Jan 2009 19:56:39 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <leegee [...] gmail.com>
Latest version includes a 'fix' target in the makefile, via Makefile.PL postamble: fix: $(PERLRUN) inc/fix.pl $(DISTVNAME).tar.gz inc/fix.pl is based on the file provided by "bart" via the PAUSE error message: it could be neater, but this is a rush job: while(@ARGV) { my $dist = shift; $dist =~ /\.t(ar\.)?gz$/ or die "Wrong argument: '$dist'; please provide a '.tar.gz' file as argument"; print "Loading distribution '$dist'\n"; my $fixes; my $tar = Archive::Tar->new; if (not $tar->read($dist)){ warn "Have you run make tardist?\n"; next; } my @files = $tar->get_files; foreach my $file (@files) { my $fixedmode = my $mode = $file->mode; my $filetype = ''; if($file->is_file) { $filetype = 'file'; if(substr(${ $file->get_content_by_ref }, 0, 2) eq '#!') { $fixedmode = $ENV{PERM_RW}? '0'.$ENV{PERM_RW} : 0775; } else { $fixedmode = $ENV{PERM_RWX}? '0'.$ENV{PERM_RWX} : 0664; } } elsif($file->is_dir) { $filetype = 'dir'; $fixedmode = $ENV{PERM_RW}? '0'.$ENV{PERM_RW} : 0775;; } else { next; } next if $mode eq $fixedmode; $file->mode($fixedmode); $fixes++; printf "Change mode %03o to %03o for %s '%s'\n", $mode, $fixedmode, $filetype, $file->name; } if ($fixes) { rename $dist, "$dist.bak" or die "Cannot rename file '$dist' to '$dist.bak': $!"; $tar->write($dist, 9); print "File '$dist' saved.\n"; } else { print "File '$dist' didn't need fixing, skipped.\n"; } }
  Fri Jan 02 13:56:53 2009 The RT System itself - Status changed from 'resolved' to 'open'
  Fri Jan 02 14:01:55 2009 LGODDARD [...] cpan.org - Status changed from 'open' to 'resolved'