Bug #4207 for activitymail: Diffed ViewCVS links not practical on SourceForge

Fri Oct 24 17:05:05 2003 Guest - Ticket created

Subject:

Diffed ViewCVS links not practical on SourceForge

The problem is that the ViewCVS link is pointing to a server that is a day behind the commit you just made, so the links in the emails are not valid yet. To "fix" this I just added " if $opt_V;" to the end of line 639 so they don't show up without the version numbers being displayed (I don't use this option), but you may want to add another option for this. Some context code (because I don't know how to do a proper diff without a CVS checkout :p): if ($type eq 'mod') { $url .= ".diff?r1=$old&r2=$new" if $opt_V; $nm .= " (r$old -> r$new)" if $opt_V; } elsif ($type eq 'add') {

Fri Oct 24 19:24:26 2003 david [...] kineticode.com - Correspondence added

Date:	Fri, 24 Oct 2003 16:23:58 -0700
Subject:	Re: [cpan #4207] Diffed ViewCVS links not practical on SourceForge
From:	David Wheeler <david [...] kineticode.com>
To:	bug-activitymail [...] rt.cpan.org
RT-Send-Cc:

On Friday, October 24, 2003, at 02:05 PM, Guest via RT wrote: Show quoted text

> Some context code (because I don't know how to do a proper diff > without a CVS checkout :p):

It's on CSVHome, FWIW. http://activitymail.cvshome.org/servlets/ProjectSource Show quoted text

> if ($type eq 'mod') { > $url .= ".diff?r1=$old&r2=$new" if $opt_V; > $nm .= " (r$old -> r$new)" if $opt_V; > } elsif ($type eq 'add') {

Good idea. I've added this in. Send me your name and I'll give you credit in Changes. Regards, David -- David Wheeler AIM: dwTheory david@kineticode.com ICQ: 15726394 http://www.kineticode.com/ Yahoo!: dew7e Jabber: Theory@jabber.org Kineticode. Setting knowledge in motion.[sm]

Wed Feb 25 19:52:52 2004 dwheeler [...] cpan.org - Status changed from 'new' to 'resolved'

Wed Feb 25 19:53:08 2004 dwheeler [...] cpan.org - Fixed in 1.16 added

Wed Feb 25 19:53:08 2004 dwheeler [...] cpan.org - CustomField 1.15 deleted