| Subject: | Module monkeypatches Catalyst::Request, should use ->request_class |
| Date: | Mon, 29 Dec 2008 16:53:52 +0000 |
| To: | bugs-Catalyst-Plugin-HashedCookies [...] rt.cpan.org |
| From: | Matt S Trout <mst [...] shadowcat.co.uk> |
# apparently this should be done by subclassing Catalyst::Request and using
# response_class, but I'm suspicious that that process isn't tolerant to
# multiple users.
*{Symbol::qualify_to_ref('validhashedcookies', 'Catalyst::Request')} =
Class::Accessor::Fast::make_accessor('Catalyst::Request', 'validhashedcookies');
*{Symbol::qualify_to_ref('invalidhashedcookies', 'Catalyst::Request')} =
Class::Accessor::Fast::make_accessor('Catalyst::Request', 'invalidhashedcookies');
Well, you can be as suspicious as you like, but ->request_class is supported
and this horrific hack isn't.
Your plugin will be broken on 5.80, and frankly if I could see an easy way
to make it die on 5.70 I would - this is not rails, we do not monkeypatch
things at random..
--
Matt S Trout Need help with your Catalyst or DBIx::Class project?
Technical Director http://www.shadowcat.co.uk/catalyst/
Shadowcat Systems Ltd. Want a managed development or deployment platform?
http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/