Skip Menu |

This queue is for tickets about the Params-Util CPAN distribution.

Report information
The Basics
Id: 42012
Status: resolved
Priority: 0/
Queue: Params-Util

People
Owner: Nobody in particular
Requestors: sisyphus [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.35
Fixed in: (no value)



Hi Adam, Not really a bug .... 'test.c' and 'test.o' ship with the source and are listed in the MANIFEST. 'test.c' is explicitly marked for cleanup. If, having built Params-Util-0.35, we run 'make clean' or 'make realclean', those 2 files are removed. And then, if we subsequently try to rebuild the module we get: Warning: the following files are missing in your kit: test.c test.o Please inform the author. (Assuming there's no need for 'test.c' and 'test.o' to ship with the source, they could be removed and the MANIFEST adjusted accordingly.) Cheers, Rob
Subject: Re: [rt.cpan.org #42012]
Date: Mon, 29 Dec 2008 12:34:09 +1100
To: bug-Params-Util [...] rt.cpan.org
From: "Adam Kennedy" <adamkennedybackup [...] gmail.com>
The MANIFEST is generated automatically, by the common MANIFEST.SKIP file. Most of the files that SHOULDN'T be in MANIFEST are represented in the MANIFEST.SKIP, but clearly in this case we need to add an extra couple. Adam K 2008/12/29 Sisyphus via RT <bug-Params-Util@rt.cpan.org>: Show quoted text
> Sun Dec 28 19:58:57 2008: Request 42012 was acted upon. > Transaction: Ticket created by SISYPHUS > Queue: Params-Util > Subject: (No subject given) > Broken in: 0.35 > Severity: Unimportant > Owner: Nobody > Requestors: sisyphus@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42012 > > > > Hi Adam, > Not really a bug .... 'test.c' and 'test.o' ship with the source and are > listed in the MANIFEST. 'test.c' is explicitly marked for cleanup. > > If, having built Params-Util-0.35, we run 'make clean' or 'make > realclean', those 2 files are removed. And then, if we subsequently try > to rebuild the module we get: > > Warning: the following files are missing in your kit: > test.c > test.o > Please inform the author. > > (Assuming there's no need for 'test.c' and 'test.o' to ship with the > source, they could be removed and the MANIFEST adjusted accordingly.) > > Cheers, > Rob >
On Sun Dec 28 20:34:20 2008, adamkennedybackup@gmail.com wrote: Show quoted text
> The MANIFEST is generated automatically, by the common MANIFEST.SKIP file. > > Most of the files that SHOULDN'T be in MANIFEST are represented in the > MANIFEST.SKIP, but clearly in this case we need to add an extra > couple.
That would work ... though I don't see why 'test.c' (which the Makefile.PL overwrites) and 'test.o' (which is platform dependent, and is overwritten by a successful test compilation) are included in the source to begin with. (Of course, no explanation is necessary ... my main aim was simply to draw your attention to this ... and that has already been achieved :-) Cheers, Rob
Subject: Fixed
This no longer seems to be a problem in the current release