Bug #41928 for SOAP-Lite: Missing import of HTTP_BAD

Wed Dec 24 11:48:37 2008 dmn [...] debian.org - Ticket created

Subject:	Missing import of HTTP_BAD_REQUEST
Date:	Wed, 24 Dec 2008 18:48:18 +0200
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Damyan Ivanov <dmn [...] debian.org>

Hi, Please find attached a patch that fixes missing import of HTTP_BAD_REQUEST apache constant. I have also taken the opportunity to add relevant imports for mod_perl version 1 and 1.99. I haven't tested these, so apply that with a grain of salt. For reference, this has been reported as #509625 in the Debian bug tracking system. (http://bugs.debian.org/509625). It would be nice if you CC 509625@bugs.debian.org on replies. Happy holidays! -- dam JabberID: dam@jabber.minus273.org

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Wed Dec 24 15:16:20 2008 dam [...] modsoftsys.com - Correspondence added

Subject:	Re: Missing import of HTTP_BAD_REQUEST
From:	dmn [...] debian.org

On Wed Dec 24 11:48:37 2008, dmn@debian.org wrote: Show quoted text

> Please find attached a patch that fixes ...

Here's the patch itself.

# Author: Damyan Ivanov <dmn@debian.org> # Description: add missing Apache constant imports # Upstream-Bug: http://rt.cpan.org/Ticket/Display.html?id=41928 # Debian-Bug: http://bugs.debian.org/509625 --- a/lib/SOAP/Transport/HTTP.pm +++ b/lib/SOAP/Transport/HTTP.pm @@ -644,7 +644,7 @@ sub new { require Apache2::Const; require Apache2::RequestUtil; require APR::Table; - Apache2::Const->import(-compile => 'OK'); + Apache2::Const->import(-compile => qw(OK HTTP_BAD_REQUEST)); $self->{'MOD_PERL_VERSION'} = 2; $self->{OK} = &Apache2::Const::OK; } @@ -656,7 +656,7 @@ sub new { if ($mod_perl::VERSION < 1.99) { require Apache; require Apache::Constants; - Apache::Constants->import('OK'); + Apache::Constants->import(qw(OK BAD_REQUEST)); $self->{'MOD_PERL_VERSION'} = 1; $self->{OK} = &Apache::Constants::OK; } @@ -664,7 +664,7 @@ sub new { require Apache::RequestRec; require Apache::RequestIO; require Apache::Const; - Apache::Const->import(-compile => 'OK'); + Apache::Const->import(-compile => qw(OK HTTP_BAD_REQUEST)); $self->{'MOD_PERL_VERSION'} = 1.99; $self->{OK} = &Apache::OK; }

Wed Dec 24 15:16:21 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 21 13:25:03 2009 kutterma [...] users.sourceforge.net - Correspondence added

Hi, fixed in SVN in rev306. Will be included in next release. Thanks, Martin

Sun Feb 28 15:07:57 2010 kutterma [...] users.sourceforge.net - Status changed from 'open' to 'resolved'

Sun Feb 28 15:08:05 2010 kutterma [...] users.sourceforge.net - Fixed in 0.710.10 added

Bug #41928 for SOAP-Lite: Missing import of HTTP_BAD_REQUEST