Skip Menu |

This queue is for tickets about the File-Copy-Recursive CPAN distribution.

Report information
The Basics
Id: 41778
Status: resolved
Priority: 0/
Queue: File-Copy-Recursive

People
Owner: Nobody in particular
Requestors: KAMARA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)



Subject: failed dircopy does not propagate in recursion
File-Copy-Recursive-0.38 Perl v5.8.8 This bug is related to the dircopy function. When copying a file in a directory fails it is not propagated to the return of the dircopy function. This only happens if the file is copied recursively. step by step ------------------------- $ mkdir -p a/b $ touch a/b/file $ chmod 000 a/b/file $ perl -e 'use File::Copy::Recursive qw(dircopy); dircopy("a", "a_copy") or die "Can not copy $!";' ------------------------- This should die because you do not have permission to copy the file. Patch is attached.
Subject: Recursive.patch
--- Recursive.pm 2008-11-20 15:38:20.000000000 +0100 +++ Recursive2.pm 2008-12-17 11:00:28.000000000 +0100 @@ -247,8 +247,8 @@ symlink readlink($org), $new or return; } elsif(-d $org) { - $recurs->($org,$new,$buf) if defined $buf; - $recurs->($org,$new) if !defined $buf; + $recurs->($org,$new,$buf) or return if defined $buf; + $recurs->($org,$new) or return if !defined $buf; $filen++; $dirn++; }
thank you, for some reason I didn't get notified of this. Will be addressed soon :)
On Wed May 20 11:37:03 2009, DMUEY wrote: Show quoted text
> thank you, for some reason I didn't get notified of this. Will be
addressed Show quoted text
> soon :)
Hiya Any idea when soon is? :) thanks Clint
Subject: Re: [rt.cpan.org #41778] failed dircopy does not propagate in recursion
Date: Wed, 14 Apr 2010 08:14:10 -0500
To: bug-File-Copy-Recursive [...] rt.cpan.org
From: Dan Muey <webmaster [...] simplemood.com>
Thanks for the ping, I'll try to have it done this weekend if possible. On Apr 13, 2010, at 12:11 PM, Clinton Gormley via RT wrote: Show quoted text
> Queue: File-Copy-Recursive > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=41778 > > > On Wed May 20 11:37:03 2009, DMUEY wrote:
>> thank you, for some reason I didn't get notified of this. Will be
> addressed
>> soon :)
> > Hiya > > Any idea when soon is? :) > > thanks > > Clint
From: Chas. Owens
On Wed Apr 14 09:14:22 2010, webmaster@simplemood.com wrote: Show quoted text
> Thanks for the ping, I'll try to have it done this weekend if possible.
snip Other users seem to be impacted by this bug: http://stackoverflow.com/questions/3694216/how-to-copy-a-read-only-directory-in- perl/3694258#3694258
Subject: [rt.cpan.org #41778] just ping
Date: Tue, 17 Dec 2013 00:10:17 +0400
To: bug-file-copy-recursive [...] rt.cpan.org
From: Dmitry Bolshakov <bdimych [...] yandex.ru>
still unsolved
 
--
with best regards
Dmitry Bolshakov
thanks Dmitry, I'll try really hard for this weekend
RT-Send-CC: bdimych [...] yandex.ru
Terribly sorry for the delay. I am looking into this and this report is about a file that is 000 and the stack overflow is about a directory that is readonly, so there are two things to address. The upcoming modern interface will have a better mechanism to get details back about what happened as well as behavior modifications. Until then I'd like to address both issues. I'll update this RT w/ the git hub commits that should address them.
I believe this RT (and the stackoverflow noted in it) should be addressed by https://github.com/drmuey/p5-File-Copy-Recursive/commit/8bf278cb4e132b595d2b3203d1a6af41f2140387