| Subject: | possible bug in $item->guid |
| Date: | Tue, 16 Dec 2008 22:38:13 -0600 |
| To: | "bug-XML-FeedPP [...] rt.cpan.org" <bug-XML-FeedPP [...] rt.cpan.org> |
| From: | Prigge Scott <PriggeScottM [...] JohnDeere.com> |
Hello Yusuke. I recently began using your FeedPP perl module from CPAN. I must tell you that as a *very* novice perl programmer, I found your module really simple to use, and very well documented. You did an excellent job, and thank you for the module!
This evening I was working on my first attempt to develop a very simple RSS XML file. I noticed that FeedPP added a <guid /> element even though I did not specify one, and that's fine. What I wanted to do was change the bool value (which was set by default) from "true" to "false". When I set the value to ""false", this was the result:
$item->guid($link, isPermaLink => "false");
produced
<guid isPermaLink="isPermaLink">http://192.168.0.4/podcasts/file.mp3</guid>
I took a closer look at the module and I think I found a slight bug:
XML::FeedPP::RSS::Item::guid(/usr/lib/perl5/site_perl/5.10.0/XML/FeedPP.pm:1004):
1004: my $perma = shift || "true";
DB<13> x @_
0 'isPermaLink'
1 'false'
So it appears the module is taking element 0 in the @_ array instead of element 1. I simply changed line 1004 in the module which had the desired effect:
my $perma = pop || "true";
produced
<guid isPermaLink="false">http://192.168.0.4/podcasts/file.mp3</guid>
I thought you might want to know for your next release. Thanks again for such an excellent module!