Bug #41710 for PadWalker: closed_over(\&xsub) causes segfault (or assertion failed)

Mon Dec 15 01:15:00 2008 gfuji [...] cpan.org - Ticket created

Subject:

closed_over(\&xsub) causes segfault (or assertion failed)

Hello. It seems that "closed_over(\&xsub)" (e.g. closed_over(\&UNIVERSAL::isa)) causes segfault, because XSUBs do not have PADLIST. Regards, -- Goro Fuji (GFUJI at CPAN.org)

Thu Feb 26 17:38:04 2009 DOY [...] cpan.org - Correspondence added

The attached patch seems to stop the crashing... I don't really know enough about the internals to vouch for the accuracy, but it seems fine.

--- PadWalker.xs.old 2009-02-26 16:31:32.000000000 -0600 +++ PadWalker.xs 2009-02-26 16:25:39.000000000 -0600 @@ -357,6 +357,9 @@ void get_closed_over(CV *cv, HV *hash, HV *indices) { + if (!CvPADLIST(cv)) { + return; + } I32 i; U32 val_depth = CvDEPTH(cv) ? CvDEPTH(cv) : 1; AV *pad_namelist = (AV*) *av_fetch(CvPADLIST(cv), 0, FALSE);

Thu Feb 26 17:38:05 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 10 21:54:42 2009 rt.cpan [...] sartak.org - Correspondence added

Hi Robin, I've been using doy's patch since he wrote it - without trouble. It hasn't segfaulted once. Could you please push a release to CPAN with the fix? My users keep hitting this crash. Thanks for a wonderful module, Shawn

Thu Jun 25 16:04:49 2009 robin [...] cpan.org - Correspondence added

I'm sorry I overlooked this for so long. Email to my CPAN address was going into a black hole, and I didn't realise until last week. This patch looks fine; I'll roll it into a release ASAP. Robin

Sat Mar 06 12:46:03 2010 JAWNSY [...] cpan.org - Correspondence added

Hi: I'm one of the maintainers of the Debian package of this module. I am unable to reproduce this issue on version 1.9, and given what Robin said the day before the 1.9 release: Show quoted text

> This patch looks fine; I'll roll it into a release ASAP.

I think it's fair assuming this issue has been fixed in that version.

Sat Mar 06 12:46:38 2010 JAWNSY [...] cpan.org - Severity Important added

Sat Mar 06 12:46:39 2010 JAWNSY [...] cpan.org - Fixed in 1.9 added

Sun Feb 05 10:49:32 2012 robin [...] cpan.org - Status changed from 'open' to 'resolved'