Bug #41683 for Test-NoTabs: Will not install cleanly on a fresh perl 5.8

Sat Dec 13 21:52:46 2008 bobtfish [...] bobtfish.net - Ticket created

Subject:	META.yml does not specify Module::Build is required
Date:	Sun, 14 Dec 2008 01:27:11 +0000
To:	bug-test-notabs [...] rt.cpan.org
From:	Tomas Doran <bobtfish [...] bobtfish.net>

Therefore if you try to install your module on a fresh perl build, the Makefile.PL won't run, as Module::Build isn't installed, therefore this module won't install from CPAN :( Test::NoTabs was recently made part of the Catalyst dependency chain (for the upcoming 5.80 release), but we'll have to remove it unless your module builds cleanly on a fresh perl. We'd prefer a switch to Module::Install (as that's what we use), but just a working dependency list in META.yml should give CPAN.pm enough clues to get it right. Thanks in advance t0m

Sun Dec 14 04:50:31 2008 bobtfish [...] bobtfish.net - Correspondence added

The root cause of my problem is that the CPAN.pm shipped with 5.8.8 doesn't know about Module::Build.. Therefore (as we have to support older perls), there is no way to cleanly build with this module in our dependency chain.. I'm more than happy to supply you a patch to switch to Module::Install - would that be acceptable? Cheers t0m

Sun Dec 14 04:50:33 2008 bobtfish [...] bobtfish.net - Status changed from 'new' to 'open'

Sun Dec 14 15:03:29 2008 SOCK [...] cpan.org - Correspondence added

I'd be happy to apply any patches you supply. I regret to say that I have effectively abandoned these modules and they don't get much attention.

Sun Dec 14 15:56:32 2008 bobtfish [...] bobtfish.net - Correspondence added

Please find a patch to switch to Module::Install, and a dist created with the patch applied attached.. Cheers t0m

Only in Test-NoTabs-0.3: Build.PL diff -ur Test-NoTabs-0.3/Changes Test-NoTabs-0.3.t0m/Changes --- Test-NoTabs-0.3/Changes 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/Changes 2008-12-14 20:50:33.000000000 +0000 @@ -8,4 +8,8 @@ - Added Makefile.PL for compatibility 0.3 2006-08-26 - - Added missing dependancy (Test::Group) \ No newline at end of file + - Added missing dependancy (Test::Group) + +0.4 2008-12-14 + - Change to Module::Install so that we install + cleanly on a fresh perl 5.8 diff -ur Test-NoTabs-0.3/MANIFEST Test-NoTabs-0.3.t0m/MANIFEST --- Test-NoTabs-0.3/MANIFEST 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/MANIFEST 2008-12-14 20:51:21.000000000 +0000 @@ -1,12 +1,19 @@ -Build.PL -Makefile.PL Changes -MANIFEST +inc/Module/Install.pm +inc/Module/Install/Base.pm +inc/Module/Install/Can.pm +inc/Module/Install/Fetch.pm +inc/Module/Install/Makefile.pm +inc/Module/Install/Metadata.pm +inc/Module/Install/Win32.pm +inc/Module/Install/WriteAll.pm +lib/Test/NoTabs.pm +Makefile.PL +MANIFEST This list of files META.yml README -lib/Test/NoTabs.pm t/00-load.t t/04-pod.t t/05-pod-coverage.t t/11-all.t -t/12-fail.t \ No newline at end of file +t/12-fail.t diff -ur Test-NoTabs-0.3/META.yml Test-NoTabs-0.3.t0m/META.yml --- Test-NoTabs-0.3/META.yml 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/META.yml 2008-12-14 20:51:07.000000000 +0000 @@ -1,8 +1,26 @@ ---- #YAML:1.0 -name: Test-NoTabs -version: 0.3 +--- +abstract: 'Check the presence of tabs in your project' author: - - Nick Gerakines <nick@socklabs.com> -abstract: Check the presence of tabs in your project + - 'Nick Gerakines <nick@socklabs.com>' +distribution_type: module +generated_by: 'Module::Install version 0.77' license: perl -generated_by: Module::Build version 0.2612, without YAML.pm +meta-spec: + url: http://module-build.sourceforge.net/META-spec-v1.4.html + version: 1.4 +module_name: Test::NoTabs +name: Test-NoTabs +no_index: + directory: + - inc + - t +requires: + File::Find: 0 + File::Spec: 0 + FindBin: 0 + Test::Builder: 0 + Test::Group: 0 + Test::More: 0 +resources: + license: http://dev.perl.org/licenses/ +version: 0.4 Only in Test-NoTabs-0.3.t0m: Makefile diff -ur Test-NoTabs-0.3/Makefile.PL Test-NoTabs-0.3.t0m/Makefile.PL --- Test-NoTabs-0.3/Makefile.PL 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/Makefile.PL 2008-12-14 20:49:23.000000000 +0000 @@ -1,3 +1,14 @@ -use Module::Build::Compat; -Module::Build::Compat->run_build_pl(args => \@ARGV); -Module::Build::Compat->write_makefile(); \ No newline at end of file +use inc::Module::Install; +name 'Test-NoTabs', +license 'perl', +author 'Nick Gerakines <nick@socklabs.com>', +all_from 'lib/Test/NoTabs.pm', +requires 'Test::More'; +requires 'Test::Builder'; +requires 'File::Spec'; +requires 'FindBin'; +requires 'File::Find'; +requires 'Test::Group'; + +WriteAll; + Only in Test-NoTabs-0.3.t0m: inc diff -ur Test-NoTabs-0.3/lib/Test/NoTabs.pm Test-NoTabs-0.3.t0m/lib/Test/NoTabs.pm --- Test-NoTabs-0.3/lib/Test/NoTabs.pm 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/lib/Test/NoTabs.pm 2008-12-14 20:50:47.000000000 +0000 @@ -10,7 +10,7 @@ use vars qw( $VERSION $PERL $UNTAINT_PATTERN $PERL_PATTERN); -$VERSION = '0.3'; +$VERSION = '0.4'; $PERL = $^X || 'perl'; $UNTAINT_PATTERN = qr|^([-+@\w./:\\]+)$|; diff -ur Test-NoTabs-0.3/t/11-all.t Test-NoTabs-0.3.t0m/t/11-all.t --- Test-NoTabs-0.3/t/11-all.t 2006-08-26 19:39:28.000000000 +0100 +++ Test-NoTabs-0.3.t0m/t/11-all.t 2008-12-14 20:53:46.000000000 +0000 @@ -1,10 +1,11 @@ use strict; use Test::NoTabs; +use FindBin qw/$Bin/; use File::Temp qw( tempdir tempfile ); -all_perl_files_ok(); +all_perl_files_ok("$Bin/../lib"); notabs_ok( $0, "$0 is tab free" );

Download Test-NoTabs-0.4.tar.gz
application/x-gzip 15.9k

Message body not shown because it is not plain text.

Sun Dec 21 09:57:02 2008 bobtfish [...] bobtfish.net - Correspondence added

Any news here? We've got another pending patch to fix a warning with newer versions of Test::Builder... If you don't have time to look after this code, would it be too rude to ask you to assign co-maint to myself or someone who does have the time?

Sun Dec 21 09:57:40 2008 bobtfish [...] bobtfish.net - Subject changed from 'META.yml does not specify Module::Build is required' to 'Will not install cleanly on a fresh perl 5.8'

Sun Dec 21 09:57:40 2008 bobtfish [...] bobtfish.net - Severity Normal added

Sun Dec 21 09:57:40 2008 bobtfish [...] bobtfish.net - Broken in 0.1 added

Sun Dec 21 09:57:40 2008 bobtfish [...] bobtfish.net - Broken in 0.2 added

Sun Dec 21 09:57:40 2008 bobtfish [...] bobtfish.net - Broken in 0.3 added

Mon Dec 22 01:54:21 2008 SOCK [...] cpan.org - Correspondence added 30 min

No no, that's not rude at all. I'm ashamed to say that I had to setup a testing env on my computer to verify the changes you've sent. I'm happy to add you as a maintainer if you would like to be one. All of my perl-libs can be found at http://github.com/ngerakines/perl-libs/ . On Sun Dec 21 09:57:02 2008, BOBTFISH wrote: Show quoted text

> Any news here? > > We've got another pending patch to fix a warning with newer versions of > Test::Builder... > > If you don't have time to look after this code, would it be too rude to > ask you to assign co-maint to myself or someone who does have the time?

Mon Dec 22 01:54:22 2008 SOCK [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Dec 23 11:42:21 2008 bobtfish [...] bobtfish.net - Correspondence added

On Mon Dec 22 01:54:21 2008, SOCK wrote: Show quoted text

> > No no, that's not rude at all. I'm ashamed to say that I had to setup a > testing env on my computer to verify the changes you've sent. I'm happy > to add you as a maintainer if you would like to be one.

That would be brilliant if you wouldn't mind? Show quoted text

> All of my perl-libs can be found at > http://github.com/ngerakines/perl-libs/

Eeek, one repository with multiple projects, and what is with the tags/branches directories? :-/

Tue Dec 23 11:42:22 2008 The RT System itself - Status changed from 'resolved' to 'open'

Tue Dec 23 12:15:22 2008 SOCK [...] cpan.org - Correspondence added

On Tue Dec 23 11:42:21 2008, BOBTFISH wrote: Show quoted text

> On Mon Dec 22 01:54:21 2008, SOCK wrote:

> > > > No no, that's not rude at all. I'm ashamed to say that I had to setup a > > testing env on my computer to verify the changes you've sent. I'm happy > > to add you as a maintainer if you would like to be one.

> > That would be brilliant if you wouldn't mind?

Done. You've been added as a co-maintainer. Show quoted text

>

> > All of my perl-libs can be found at > > http://github.com/ngerakines/perl-libs/

> > Eeek, one repository with multiple projects, and what is with the > tags/branches directories? :-/ >

The perl-libs repository was an import of an internal svn repository that I had been using for a while. It's on my TODO list to split it out into separate repositories for each module/project. Create a GitHub account and add me as a follower. We should probably take this conversation to direct email (nick@gerakines.net).

Tue Dec 23 12:16:13 2008 SOCK [...] cpan.org - Correspondence added

BTW, Test-NoTabs-0.4 was pushed and is live. Marking this ticket as resolved. Please track additional bugs and issues separately. On Tue Dec 23 11:42:21 2008, BOBTFISH wrote: Show quoted text

> On Mon Dec 22 01:54:21 2008, SOCK wrote:

> > > > No no, that's not rude at all. I'm ashamed to say that I had to setup a > > testing env on my computer to verify the changes you've sent. I'm happy > > to add you as a maintainer if you would like to be one.

> > That would be brilliant if you wouldn't mind? >

> > All of my perl-libs can be found at > > http://github.com/ngerakines/perl-libs/

> > Eeek, one repository with multiple projects, and what is with the > tags/branches directories? :-/ >

Tue Dec 23 12:16:14 2008 SOCK [...] cpan.org - Status changed from 'open' to 'resolved'