Bug #41561 for Module-Build: dist and manifest actions don't copy/recognize empty directories

Tue Dec 09 06:51:57 2008 mkanat [...] cpan.org - Ticket created

Subject:

dist and manifest actions don't copy/recognize empty directories

Part of my tarball (for the "VCI" CPAN distribution) is a git repository. The git repo has a directory called "refs" which contains two empty directories: "heads" and "objects". Unfortunately, git believes that a repository is invalid if it does not contain these directories. This means that my tests fail if these directories are not present. However, ./Build manifest doesn't add these directories to the MANIFEST (because they're empty) and adding them directly to the MANIFEST causes ./Build dist to fail: Can't copy('t/repos/git/test.git/refs/heads', 'VCI-0.5.0_1/t/repos/git/test.git/refs/heads'): Is a directory at /usr/lib/perl5/vendor_perl/5.10.0/Module/Build/Base.pm line 4284. So, currently the dist action is only capable of making broken tarballs for my distribution.

Tue Dec 09 20:20:53 2008 EWILHELM [...] cpan.org - Correspondence added

On Tue Dec 09 06:51:57 2008, MKANAT wrote: Show quoted text

> However, ./Build manifest doesn't add these directories to the > MANIFEST

Unfortunately this is partly to do with ExtUtils::Manifest. The MANIFEST file has never been able to contain directories. If we can determine that MANIFEST could contain directories without breaking too many other tools, it might be reasonable to forgo usage of ExtUtils::Manifest or otherwise add this feature. --Eric

Tue Dec 09 20:20:56 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 09 20:20:56 2008 EWILHELM [...] cpan.org - Status changed from 'open' to 'stalled'

Tue Dec 09 20:21:18 2008 EWILHELM [...] cpan.org - Severity Important changed to Wishlist

Wed Dec 10 00:02:40 2008 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #41561] dist and manifest actions don't copy/recognize empty directories
Date:	Tue, 9 Dec 2008 21:00:12 -0800
To:	Max Kanat-Alexander via RT <bug-Module-Build [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Tue, Dec 09, 2008 at 06:52:05AM -0500, Max Kanat-Alexander via RT wrote: Show quoted text

> Part of my tarball (for the "VCI" CPAN distribution) is a git > repository. The git repo has a directory called "refs" which contains > two empty directories: "heads" and "objects". > > Unfortunately, git believes that a repository is invalid if it does not > contain these directories. This means that my tests fail if these > directories are not present.

What would git do if these subdirectories contain files .mft_exists? If it fails, what about creation of these directories during run of ./build? Hope this helps, Ilya

Wed Dec 10 00:03:22 2008 The RT System itself - Status changed from 'stalled' to 'open'