Bug #41552 for Params-Util: bleadperl@33452 breaks Params::Util

Mon Dec 08 16:37:58 2008 ANDK [...] cpan.org - Ticket created

Subject:

bleadperl and optimize=-g, suspicious data

Hi Adam, you should know that when you see perl: av.c:763: Perl_av_len: Zusicherung »((svtype)((av)->sv_flags & 0xff)) == SVt_PVAV« nicht erfüllt. that means simply perl: av.c:763: Perl_av_len: Assertion `((svtype)((av)->sv_flags & 0xff)) == SVt_PVAV' failed. I expect you will see more of those in the next hours in my cpantesters reports, I just want to announce my binary search running. It seems that bleadperl with optimize=-g does not like Params::Util while optimize=-O2 seems to work. Is this a known issue? Anyway, my smoker is running to find out the threshold. I'll summarize later when it has run through the test. Best,

Mon Dec 08 18:39:39 2008 adamkennedybackup [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #41552] bleadperl and optimize=-g, suspicious data
Date:	Tue, 9 Dec 2008 10:39:30 +1100
To:	bug-Params-Util [...] rt.cpan.org
From:	"Adam Kennedy" <adamkennedybackup [...] gmail.com>

I'm told that Params::Util uses basically identical code to Scalar::Util or List::MoreUtils, so this bug may be wider than just me. Adam K 2008/12/9 Andreas Koenig via RT <bug-Params-Util@rt.cpan.org>: Show quoted text

> Mon Dec 08 16:37:58 2008: Request 41552 was acted upon. > Transaction: Ticket created by ANDK > Queue: Params-Util > Subject: bleadperl and optimize=-g, suspicious data > Broken in: 0.35 > Severity: Normal > Owner: Nobody > Requestors: ANDK@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=41552 > > > > Hi Adam, > > you should know that when you see > > perl: av.c:763: Perl_av_len: Zusicherung »((svtype)((av)->sv_flags & > 0xff)) == SVt_PVAV« nicht erfüllt. > > that means simply > > perl: av.c:763: Perl_av_len: Assertion `((svtype)((av)->sv_flags & > 0xff)) == SVt_PVAV' failed. > > I expect you will see more of those in the next hours in my cpantesters > reports, I just want to announce my binary search running. > > It seems that bleadperl with optimize=-g does not like Params::Util > while optimize=-O2 seems to work. > > Is this a known issue? > > Anyway, my smoker is running to find out the threshold. > > I'll summarize later when it has run through the test. > > Best, > >

Mon Dec 08 18:39:41 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 09 00:17:02 2008 ANDK [...] cpan.org - Correspondence added

Bleadperl patch 33452 introduced the assertion. Since then we get Program received signal SIGABRT, Aborted. 0xffffe410 in ?? () (gdb) bt #0 0xffffe410 in ?? () #1 0xbfa66688 in ?? () #2 0x00000006 in ?? () #3 0x00004027 in ?? () #4 0xb7dd6ef5 in raise () from /lib/i686/cmov/libc.so.6 #5 0xb7dd8871 in abort () from /lib/i686/cmov/libc.so.6 #6 0xb7dd00ee in __assert_fail () from /lib/i686/cmov/libc.so.6 #7 0x08109247 in Perl_av_len (av=0x891ba08) at av.c:769 #8 0xb7f7c52c in XS_Params__Util__HASH (cv=0x86e88e8) at Util.xs:251 #9 0x0813b6c9 in Perl_pp_entersub () at pp_hot.c:2882 #10 0x080cf9d0 in Perl_runops_debug () at dump.c:1983 #11 0x081125f0 in S_run_body (oldscope=1) at perl.c:2394 #12 0x08111b92 in perl_run (my_perl=0x83cb008) at perl.c:2319 #13 0x0805edf4 in main (argc=5, argv=0xbfa66cd4, env=0xbfa66cec) at perlmain.c:117 This happens after the successful test 375 in t/02_util.t. The failing test 376 would try main::(t/02_util.t:534): null( Params::Util::_HASH({}), '...::_HASH(empty HASH) returns undef' ); Indeed I find in the body of _HASH this code: 251 if( is_hash(ref) && ( av_len((AV *)(SvRV(ref))) >= 1 ) ) which looks pretty much like a copy&paste error from 50 lines above.

Tue Dec 09 02:14:49 2008 adamkennedybackup [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #41552] bleadperl and optimize=-g, suspicious data
Date:	Tue, 9 Dec 2008 18:14:37 +1100
To:	bug-Params-Util [...] rt.cpan.org
From:	"Adam Kennedy" <adamkennedybackup [...] gmail.com>

Can you tell me what this needs to be replaced by? I didn't write XS code... Adam K 2008/12/9 Andreas Koenig via RT <bug-Params-Util@rt.cpan.org>: Show quoted text

> Queue: Params-Util > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=41552 > > > Bleadperl patch 33452 introduced the assertion. Since then we get > > Program received signal SIGABRT, Aborted. > 0xffffe410 in ?? () > (gdb) bt > #0 0xffffe410 in ?? () > #1 0xbfa66688 in ?? () > #2 0x00000006 in ?? () > #3 0x00004027 in ?? () > #4 0xb7dd6ef5 in raise () from /lib/i686/cmov/libc.so.6 > #5 0xb7dd8871 in abort () from /lib/i686/cmov/libc.so.6 > #6 0xb7dd00ee in __assert_fail () from /lib/i686/cmov/libc.so.6 > #7 0x08109247 in Perl_av_len (av=0x891ba08) at av.c:769 > #8 0xb7f7c52c in XS_Params__Util__HASH (cv=0x86e88e8) at Util.xs:251 > #9 0x0813b6c9 in Perl_pp_entersub () at pp_hot.c:2882 > #10 0x080cf9d0 in Perl_runops_debug () at dump.c:1983 > #11 0x081125f0 in S_run_body (oldscope=1) at perl.c:2394 > #12 0x08111b92 in perl_run (my_perl=0x83cb008) at perl.c:2319 > #13 0x0805edf4 in main (argc=5, argv=0xbfa66cd4, env=0xbfa66cec) > at perlmain.c:117 > > > This happens after the successful test 375 in t/02_util.t. The failing > test 376 would try > > > main::(t/02_util.t:534): null( Params::Util::_HASH({}), > '...::_HASH(empty HASH) returns undef' ); > > Indeed I find in the body of _HASH this code: > > 251 if( is_hash(ref) && ( av_len((AV *)(SvRV(ref))) >= 1 ) ) > > which looks pretty much like a copy&paste error from 50 lines above. > >

Tue Dec 09 15:09:04 2008 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org
Subject:	Re: [rt.cpan.org #41552] bleadperl and optimize=-g, suspicious data
Date:	Tue, 09 Dec 2008 21:08:15 +0100
To:	bug-Params-Util [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Tue, 09 Dec 2008 02:14:52 -0500, "Adam Kennedy via RT" <bug-Params-Util@rt.cpan.org> said:

Show quoted text

> I didn't write XS code...

Sorry, I haven't written XS for over 10 years. -- andreas

Thu Dec 11 01:23:59 2008 ANDK [...] cpan.org - Subject changed from 'bleadperl and optimize=-g, suspicious data' to 'bleadperl@33452 breaks Params::Util'

Thu Dec 11 01:24:00 2008 ANDK [...] cpan.org - Severity Normal changed to Critical

Thu Jan 08 08:16:02 2009 rafl [...] debian.org - Correspondence added

http://files.perldition.org/params-util.patch

Thu Feb 05 02:01:54 2009 adamk [...] cpan.org - Correspondence added

Patch applied by RJBS in 0.37

Thu Feb 05 02:01:55 2009 adamk [...] cpan.org - Status changed from 'open' to 'resolved'