Skip Menu |

This queue is for tickets about the Class-XSAccessor CPAN distribution.

Report information
The Basics
Id: 41421
Status: resolved
Priority: 0/
Queue: Class-XSAccessor

People
Owner: Nobody in particular
Requestors: cpan [...] punch.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.12
Fixed in: (no value)



Subject: warnings during make
This is a minor nit: I am getting warnings during the c compile. The attached patch is to remove the warnings.
Subject: 01.Class-XSAccessor-0.12.tar.gz.nowarnings.patch
diff -Naur ../Class-XSAccessor-0.12.orig/XSAccessor.xs ./XSAccessor.xs --- ../Class-XSAccessor-0.12.orig/XSAccessor.xs 2008-12-02 05:05:06.000000000 -0800 +++ ./Class-XSAccessor-0.12/XSAccessor.xs 2008-12-02 15:53:48.000000000 -0800 @@ -7,6 +7,7 @@ #include "AutoXS.h" MODULE = Class::XSAccessor PACKAGE = Class::XSAccessor +PROTOTYPES: DISABLE void getter(self) @@ -170,6 +171,8 @@ const unsigned int functionIndex = get_next_hashkey(); { CV * cv; + autoxs_hashkey hashkey; + const unsigned int len = strlen(key); /* This code is very similar to what you get from using the ALIAS XS syntax. * Except I took it from the generated C code. Hic sunt dragones, I suppose... */ cv = newXS(name, XS_Class__XSAccessor_getter, file); @@ -178,8 +181,6 @@ XSANY.any_i32 = functionIndex; /* Precompute the hash of the key and store it in the global structure */ - autoxs_hashkey hashkey; - const unsigned int len = strlen(key); hashkey.key = newSVpvn(key, len); PERL_HASH(hashkey.hash, key, len); AutoXS_hashkeys[functionIndex] = hashkey; @@ -196,6 +197,8 @@ const unsigned int functionIndex = get_next_hashkey(); { CV * cv; + autoxs_hashkey hashkey; + const unsigned int len = strlen(key); /* This code is very similar to what you get from using the ALIAS XS syntax. * Except I took it from the generated C code. Hic sunt dragones, I suppose... */ if (chained) @@ -207,8 +210,6 @@ XSANY.any_i32 = functionIndex; /* Precompute the hash of the key and store it in the global structure */ - autoxs_hashkey hashkey; - const unsigned int len = strlen(key); hashkey.key = newSVpvn(key, len); PERL_HASH(hashkey.hash, key, len); AutoXS_hashkeys[functionIndex] = hashkey; @@ -225,6 +226,8 @@ const unsigned int functionIndex = get_next_hashkey(); { CV * cv; + autoxs_hashkey hashkey; + const unsigned int len = strlen(key); /* This code is very similar to what you get from using the ALIAS XS syntax. * Except I took it from the generated C code. Hic sunt dragones, I suppose... */ if (chained) @@ -236,8 +239,6 @@ XSANY.any_i32 = functionIndex; /* Precompute the hash of the key and store it in the global structure */ - autoxs_hashkey hashkey; - const unsigned int len = strlen(key); hashkey.key = newSVpvn(key, len); PERL_HASH(hashkey.hash, key, len); AutoXS_hashkeys[functionIndex] = hashkey; @@ -253,6 +254,8 @@ const unsigned int functionIndex = get_next_hashkey(); { CV * cv; + autoxs_hashkey hashkey; + const unsigned int len = strlen(key); /* This code is very similar to what you get from using the ALIAS XS syntax. * Except I took it from the generated C code. Hic sunt dragones, I suppose... */ cv = newXS(name, XS_Class__XSAccessor_predicate, file); @@ -261,8 +264,6 @@ XSANY.any_i32 = functionIndex; /* Precompute the hash of the key and store it in the global structure */ - autoxs_hashkey hashkey; - const unsigned int len = strlen(key); hashkey.key = newSVpvn(key, len); PERL_HASH(hashkey.hash, key, len); AutoXS_hashkeys[functionIndex] = hashkey;
Thanks, applied. Look out for Class::XSAccessor 0.13 on CPAN shortly.