Bug #4141 for Net-Server: Net::Server comments/questions

Rob, thanks for your reply. Until now I could fit into existing boundaries. I've found some limitations using the PreFork.pm server. What I need is to establish a control connection to the parent process (either of socket or just stdio), and I need to handle input on this channel in run_parent method. Currently there is no way to hook in. In run_parent the child_is_talking_hook hook is called, but it can not happen, as it is not possible to add some handle into child_select. I think that it would be fine (and quite logic) to introduce new hooks for PreFork server like pre_fork_hook, post_fork_hook (per child process) pre_run_parent_hook, post_run_parent_hook (for controlling process) The patch is attached for for the second case. Thanks for your great work. Pavel Rob Brown wrote: Show quoted text
-- Pavel Hlavnicka Ginger Alliance www.gingerall.com

*** PreFork.pm.orig 2003-10-29 14:12:45.000000000 +0100 --- PreFork.pm 2003-10-29 14:19:09.000000000 +0100 *************** *** 129,138 **** --- 129,143 ---- $self->run_n_children( $prop->{min_servers} ); ### finish the parent routines + $self->pre_run_parent_hook; $self->run_parent; + $self->post_run_parent_hook; } + sub pre_run_parent_hook {} + sub post_run_parent_hook {} + ### sub to kill of a specified number of children sub kill_n_children { my $self = shift; *************** *** 652,657 **** --- 657,672 ---- has written to $self->{server}->{parent_sock}. The first argument will be the open socket to the child. + =item C<$self-E<gt>pre_run_parent_hook()> + + This hook occurs immediately before the controlling (parent) process + enters the endless loop. No arguments are available. + + =item C<$self-E<gt>post_run_parent_hook()> + + This hook occurs immediately after the controlling (parent) process + leaves the endless loop. No arguments are available. + =back =head1 TO DO

Sorry for keeping to bother you :) Just small improvement, post_parent_comm_hook is called always now. Drop all recent patches. Pavel Rob Brown wrote: Show quoted text
-- Pavel Hlavnicka Ginger Alliance www.gingerall.com

*** PreFork.pm.orig 2003-10-29 14:12:45.000000000 +0100 --- PreFork.pm 2003-10-30 13:28:02.000000000 +0100 *************** *** 129,138 **** --- 129,143 ---- $self->run_n_children( $prop->{min_servers} ); ### finish the parent routines + $self->pre_run_parent_hook; $self->run_parent; + $self->post_run_parent_hook; } + sub pre_run_parent_hook {} + sub post_run_parent_hook {} + ### sub to kill of a specified number of children sub kill_n_children { my $self = shift; *************** *** 310,322 **** ); ### loop on reading info from the children while( 1 ){ ### Wait to read. ## Normally it is not good to do selects with ## getline or <$fh> but this is controlled output ## where everything that comes through came from us. ! my @fh = $prop->{child_select}->can_read($prop->{check_for_waiting}); if( &check_sigs() ){ last if $prop->{_HUP}; } --- 315,331 ---- ); ### loop on reading info from the children + my @fh; while( 1 ){ ### Wait to read. ## Normally it is not good to do selects with ## getline or <$fh> but this is controlled output ## where everything that comes through came from us. ! @fh = $prop->{child_select}->can_read($prop->{check_for_waiting}); ! ! last if $self -> pre_parent_comm_hook(@fh); ! if( &check_sigs() ){ last if $prop->{_HUP}; } *************** *** 364,375 **** ### check up on the children $self->coordinate_children(); ! } ### allow fall back to main run method } ### routine to determine if more children need to be started or stopped sub coordinate_children { --- 373,390 ---- ### check up on the children $self->coordinate_children(); ! ! } continue { ! ### run one more hook ! last if $self -> post_parent_comm_hook(@fh); } ### allow fall back to main run method } + sub pre_parent_comm_hook {} + sub post_parent_comm_hook {} + ### routine to determine if more children need to be started or stopped sub coordinate_children { *************** *** 648,656 **** =item C<$self-E<gt>child_is_talking_hook()> ! This hook occurs if child_communication is true and the child ! has written to $self->{server}->{parent_sock}. The first argument ! will be the open socket to the child. =back --- 663,697 ---- =item C<$self-E<gt>child_is_talking_hook()> ! This hook occurs if child_communication is true and the child has ! written to $self->{server}->{parent_sock}. The first argument will be ! the open socket to the child. ! ! =item C<$self-E<gt>pre_run_parent_hook()> ! ! This hook occurs immediately before the controlling (parent) process ! enters the endless loop. No arguments are available. ! ! =item C<$self-E<gt>post_run_parent_hook()> ! ! This hook occurs immediately after the controlling (parent) process ! leaves the endless loop. No arguments are available. ! ! =item C<$self-E<gt>pre_parent_comm_hook()> ! ! This hook is called if the parent process executes the main control ! loop body. It may happen if some child handle is signaled or if ! C<can_read> is timed out. A list of signaled handles is passed in. if ! this hook return non-zero value, the parent main control loop is ! terminated. ! ! =item C<$self-E<gt>post_parent_comm_hook()> ! ! This hook is called after the parent process executes the main control ! loop body. It may happen if some child handle is signaled or if ! C<can_read> is timed out. A list of signaled handles is passed in. if ! this hook return non-zero value, the parent main control loop is ! terminated. =back