Bug #41344 for TAP-Harness-JUnit: The system cannot find the path specified

Mon Dec 01 06:16:05 2008 andreas.pohl [...] continental-corporation.com - Ticket created

Subject:

The system cannot find the path specified

Distribution: TAP::Harness::JUnit 0.25 Perl version: This is perl, v5.10.0 built for MSWin32-x86-multi-thread (with 1 registered patch, see perl -V for more detail) Copyright 1987-2007, Larry Wall Binary build 1001 [283495] provided by ActiveState http://www.ActiveState.com Built Dec 18 2007 08:46:15 Operating System: Windows XP (SP2, SP3), Windows Server 2003 System Environment: Cygwin in c:\cygwin PATH contains c:\cygwin\bin, but NOT c:\cygwin Execution of $jharness->runtests(@tests); leads to an xml file which is not filled with test result data, and the following cmd line msg: "The system cannot find the path specified." Debugging shows that the reason for this is a hardcoded path in JUnit.pm, line number 95. If I replace '/bin/cat' by 'cat', the bug is fixed.

Mon Dec 01 06:25:20 2008 lubo.rintel [...] gooddata.com - Correspondence added

From:

lubo.rintel [...] gooddata.com

Thanks for the report, Andreas! On Mon Dec 01 06:16:05 2008, andreas.pohl wrote: Show quoted text

> Execution of $jharness->runtests(@tests); leads to an xml file which > is not filled with test result data, and the following cmd line msg: > "The system cannot find the path specified."

Apart from the problem you point at, this could definitely be done better on TAP::Parser side (dying if -exec argument doesn't return 0, or something like that). I'll look into it before next release. Show quoted text

> Debugging shows that the reason for this is a hardcoded path in > JUnit.pm, line number 95. If I replace '/bin/cat' by 'cat', the bug is > fixed.

Good catch. I don't quite agree with the proposed fix though, since it won't work (a relative path) in taint mode. I think we should load the whole TAP (it doesn't tend to be very long) into a scalar and specify is as -tap argument to TAP::Parser. Does that make sense?

Mon Dec 01 06:25:24 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 01 07:36:34 2008 andreas.pohl [...] continental-corporation.com - Correspondence added

From:

andreas.pohl [...] continental-corporation.com

Wow, thanks! Quick response :-D Show quoted text

> Good catch. I don't quite agree with the proposed fix though, since

it Show quoted text

> won't work (a relative path) in taint mode. I think we should load

the Show quoted text

> whole TAP (it doesn't tend to be very long) into a scalar and

specify is Show quoted text

> as -tap argument to TAP::Parser. Does that make sense?

Do whatever you think is right - I'm definitely still on the very beginning of the learning curve in Perl...

Fri Jan 02 19:16:32 2009 lubo.rintel [...] gooddata.com - Correspondence added

Hi, On Mon Dec 01 07:36:34 2008, andreas.pohl wrote: Show quoted text

> Wow, thanks! Quick response :-D

0.26 was released which contains a fix for your issue. A public GIT repository with the source code was created, where you can see the relevant commit: http://repo.or.cz/w/TAP-Harness-JUnit.git?a=commitdiff;h=1687f65f04f7591fab8c4f82d3d42d0922f5e0ce Show quoted text

> > Good catch. I don't quite agree with the proposed fix though, since

> it

> > won't work (a relative path) in taint mode. I think we should load

> the

> > whole TAP (it doesn't tend to be very long) into a scalar and

> specify is

> > as -tap argument to TAP::Parser. Does that make sense?

> > Do whatever you think is right - I'm definitely still on the very > beginning of the learning curve in Perl...

Good luck with Perl!

Fri Jan 02 19:16:33 2009 lubo.rintel [...] gooddata.com - Status changed from 'open' to 'resolved'