Bug #41252 for TAP-Harness-JUnit: Tests failure

Wed Nov 26 17:16:38 2008 jeff [...] zeroclue.com - Ticket created

Tests fail. The issue appears to be that funkyindent.xml expects a different format for the way the line number of the failing test is reported. The attached patch against TAP::Harness::JUnit-0.24 fixes the test failure on my system. perl -V Summary of my perl5 (revision 5 version 10 subversion 0) configuration: Platform: osname=linux, osvers=2.6.23.1-42.fc8, archname=i686-linux uname='linux ws-jlavallee 2.6.23.1-42.fc8 #1 smp tue oct 30 13:55:12 edt 2007 i686 i686 i386 gnulinux ' config_args='' hint=recommended, useposix=true, d_sigaction=define useithreads=undef, usemultiplicity=undef useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm', optimize='-O2', cppflags='-fno-strict-aliasing -pipe -I/usr/local/include -I/usr/include/gdbm' ccversion='', gccversion='4.1.2 20070925 (Red Hat 4.1.2-33)', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc libc=/lib/libc-2.8.90.so, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='2.8.90' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib' Characteristics of this binary (from libperl): Compile-time options: PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP USE_LARGE_FILES USE_PERLIO Built under linux Compiled at Sep 1 2008 14:03:39 @INC: /usr/local/lib/perl5/5.10.0/i686-linux /usr/local/lib/perl5/5.10.0 /usr/local/lib/perl5/site_perl/5.10.0/i686-linux /usr/local/lib/perl5/site_perl/5.10.0 . uname -a Linux ws-jlavallee 2.6.23.1-42.fc8 #1 SMP Tue Oct 30 13:55:12 EDT 2007 i686 i686 i386 GNU/Linux

Subject:

TAP-Harness-JUnit.patch

diff -ruP TAP-Harness-JUnit-0.24/t/tests/funkyindent.xml TAP-Harness-JUnit-0.24a/t/tests/funkyindent.xml --- TAP-Harness-JUnit-0.24/t/tests/funkyindent.xml 2008-10-31 04:46:55.000000000 -0700 +++ TAP-Harness-JUnit-0.24a/t/tests/funkyindent.xml 2008-11-26 14:05:38.000000000 -0800 @@ -8,7 +8,7 @@ not ok 1 - This is not ok # Failed test 'This is not ok' -# in t/tests/funkyindent.pl at line 9. +# at t/tests/funkyindent.pl line 9. # <<< >> abcd # <<< >> abcd # abcd

Thu Nov 27 04:41:14 2008 lubo.rintel [...] gooddata.com - Correspondence added

Subject:	Tests failure
From:	lubo.rintel [...] gooddata.com

On Wed Nov 26 17:16:38 2008, jeff@zeroclue.com wrote: Show quoted text

> Tests fail. The issue appears to be that funkyindent.xml expects a > different format for the way the line number of the failing test is > reported. The attached patch against TAP::Harness::JUnit-0.24 fixes the > test failure on my system.

Thanks for the report. Though the attached patch fixes the issue with new Test::More, it would cause failures with older Test::More (which uses the "in..at" wording). I adressed this in 0.25, where the TAP output for tests is stored in text files, not generated by Test::More. I promise to submit the new package today.

Thu Nov 27 04:41:16 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Dec 31 12:53:20 2008 JLAVALLEE [...] cpan.org - Fixed in 0.25 added

Wed Dec 31 13:05:01 2008 JLAVALLEE [...] cpan.org - Correspondence added

On Thu Nov 27 04:41:14 2008, lkundrak wrote: Show quoted text

> I adressed this in 0.25, where the TAP output for tests is stored in > text files, not generated by Test::More. I promise to submit the new > package today.

Thanks for getting this fixed so quickly!

Fri Jan 02 18:33:51 2009 lubo.rintel [...] gooddata.com - Subject changed from (no value) to 'Tests failure'

Fri Jan 02 18:33:51 2009 lubo.rintel [...] gooddata.com - Status changed from 'open' to 'resolved'