| Subject: | cmp_ok fails with overloaded stringification |
The "non-overloaded" changes in 0.85_01 (from http://rt.cpan.org/Ticket/Display.html?
id=24186) broke the tests in Nagios::Plugins, but the fix was simple (to overload "eq" as well as
"").
However, have noticed that cmp_ok fails if the stringified value is 0.
Also, there was a typo with the stringified check, which means the stringification tests fail.
I've attached a newer t/overload.t script, with additional tests where the stringified value is 0,
and the typo is fixed.
| Subject: | overload.t |
#!/usr/bin/perl -w
# $Id$
BEGIN {
if( $ENV{PERL_CORE} ) {
chdir 't';
@INC = ('../lib', 'lib');
}
else {
unshift @INC, 't/lib';
}
}
use strict;
use Test::More tests => 15;
package Overloaded;
use overload
q{eq} => sub { $_[0]->{string} },
q{==} => sub { $_[0]->{num} },
q{""} => sub { $_[0]->{stringify}++; $_[0]->{string} },
q{0+} => sub { $_[0]->{numify}++; $_[0]->{num} }
;
sub new {
my $class = shift;
bless {
string => shift,
num => shift,
stringify => 0,
numify => 0,
}, $class;
}
package main;
local $SIG{__DIE__} = sub {
my($call_file, $call_line) = (caller)[1,2];
fail("SIGDIE accidentally called");
diag("From $call_file at $call_line");
};
# String with value = 0 appears to be a special case
my $obj = Overloaded->new('0', 42);
isa_ok $obj, 'Overloaded';
is $obj, '0', 'is() with string overloading';
cmp_ok $obj, 'eq', '0', 'cmp_ok() ...';
is $obj->{stringify}, 0, 'cmp_ok() eq does not stringify';
$obj = Overloaded->new('foo', 42);
isa_ok $obj, 'Overloaded';
is $obj, 'foo', 'is() with string overloading';
cmp_ok $obj, 'eq', 'foo', 'cmp_ok() ...';
is $obj->{stringify}, 0, 'cmp_ok() eq does not stringify';
cmp_ok $obj, '==', 42, 'cmp_ok() with number overloading';
is $obj->{numify}, 0, 'cmp_ok() == does not numify';
is_deeply [$obj], ['foo'], 'is_deeply with string overloading';
ok eq_array([$obj], ['foo']), 'eq_array ...';
ok eq_hash({foo => $obj}, {foo => 'foo'}), 'eq_hash ...';
# rt.cpan.org 13506
is_deeply $obj, 'foo', 'is_deeply with string overloading at the top';
Test::More->builder->is_num($obj, 42);
Test::More->builder->is_eq ($obj, "foo");
{
# rt.cpan.org 14675
package TestPackage;
use overload q{""} => sub { ::fail("This should not be called") };
package Foo;
::is_deeply(['TestPackage'], ['TestPackage']);
::is_deeply({'TestPackage' => 'TestPackage'},
{'TestPackage' => 'TestPackage'});
::is_deeply('TestPackage', 'TestPackage');
}