Bug #40988 for Test-Tester: INSTALLDIRS=perl should not be set.

Mon Nov 17 05:15:17 2008 nick [...] ccl4.org - Ticket created

Subject:

INSTALLDIRS=perl should not be set.

Test::Tester has INSTALLDIRS=perl set in its Makefile.PL. This indicates to MakeMaker that it is a core module and should be installed with other core modules. Test::Tester is not in the core. INSTALLDIRS should not be set. The fact that it is being installed in the core, rather than site_perl, is causing problems for me (and anyone else) who upgrades their perl install to a newer version. (Given the default @INC order). However, I suspect that the fix needs to be careful, as any existing install has the current version of Test::Tester installed in the wrong place, but early in @INC ahead of site_perl. (see also http://rt.cpan.org/Public/Bug/Display.html?id=40987 and http://rt.cpan.org/Public/Bug/Display.html?id=8893 )

Fri Jun 24 18:05:40 2011 MIYAGAWA [...] cpan.org - Correspondence added

Bump. This is annoying and causes issues with bundling modules with cpanm and alike. Please fix this.

Fri Jun 24 18:05:41 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 20 11:45:02 2011 DRUOSO [...] cpan.org - Severity Normal changed to Critical

Thu Oct 20 11:46:05 2011 DRUOSO [...] cpan.org - Correspondence added

This bug causes problem in automated builds in tons of places. It is a one-line change, please fix this.

Thu Oct 20 11:51:36 2011 DRUOSO [...] cpan.org - Correspondence added

As the initial comment states, there is one additional issue with the fact that it is currently deploying to the wrong location. I think it would be sane to remove "INSTALLDIRS=perl" from the Makefile and add a small check to see if the module is currently installed in the wrong location, I think the safest would be to simply abort the installation and ask the user to remove the module from the old location.

Thu Oct 20 18:31:31 2011 fergal [...] esatclear.ie - Correspondence added

Subject:	Re: [rt.cpan.org #40988] INSTALLDIRS=perl should not be set.
Date:	Fri, 21 Oct 2011 07:31:20 +0900
To:	bug-Test-Tester [...] rt.cpan.org
From:	Fergal Daly <fergal [...] esatclear.ie>

I have 0 time to work on this but if someone could send a patch I'll release it.

Thu Feb 09 10:04:41 2012 https://www.google.com/accounts/o8/id?id=AItOawkyOHx--RP0sCuxSqimRLgFJ_YPC6QRWZk - Correspondence added

Here is the patch. Am Do 20. Okt 2011, 18:31:31, fergal@esatclear.ie schrieb: Show quoted text

> I have 0 time to work on this but if someone could send a patch I'll > release it.

Subject:

Test-Tester.patch

diff -ru Test-Tester-0.108.orig/Makefile.PL Test-Tester-0.108/Makefile.PL --- Test-Tester-0.108.orig/Makefile.PL 2004-07-06 00:22:41.000000000 +0200 +++ Test-Tester-0.108/Makefile.PL 2012-02-09 02:00:17.157874629 +0100 @@ -19,7 +19,6 @@ AUTHOR => 'Fergal Daly <fergal@esatclear.ie>', NAME => $module, VERSION_FROM => $pm_file, - INSTALLDIRS => 'perl', PREREQ_PM => { 'Test::Builder' => 0, },

Thu Feb 09 18:04:17 2012 fergal [...] esatclear.ie - Correspondence added

Subject:	Re: [rt.cpan.org #40988] INSTALLDIRS=perl should not be set.
Date:	Fri, 10 Feb 2012 08:04:10 +0900
To:	bug-Test-Tester [...] rt.cpan.org
From:	Fergal Daly <fergal [...] esatclear.ie>

That is not the patch I was referring to. That will leave people with it installed in the old and the new dirs. See the comment at "Thu Oct 20 11:51:36 2011".

Sun Nov 03 00:57:17 2013 ether [...] cpan.org - Requestor ETHER added

Sun Nov 03 04:28:01 2013 Th.J.v.Hoesel+CPAN [...] gmail.com - Requestor VANHOESEL added

Sun Nov 03 04:44:19 2013 Th.J.v.Hoesel+CPAN [...] gmail.com - Dependency by ticket #89994 added