Skip Menu |

This queue is for tickets about the GSAPI CPAN distribution.

Report information
The Basics
Id: 40928
Status: resolved
Priority: 0/
Queue: GSAPI
People
Owner: Nobody in particular
Requestors: gwyn [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.4
Fixed in: (no value)

History Show all quoted text
  Fri Nov 14 14:51:02 2008 perl [...] pied.nu - Ticket created
Subject: Adding gsapi_set_display_callback support
Hello. You will find attached a large patch to GSAPI that adds gsapi_set_display_callback() support. I also did a large tweak to the documentation and some other bits.
Subject: Philip_Gwyn-set_display_callback.01.patch

Message body is not shown because it is too large.

  Wed Nov 19 11:48:19 2008 stefan [...] hello-penguin.com - Correspondence added
On Fri Nov 14 14:51:02 2008, GWYN wrote: Show quoted text
> Hello. > > You will find attached a large patch to GSAPI that adds > gsapi_set_display_callback() support. I also did a large tweak to the > documentation and some other bits.
First: wow great work. I tested your patch and I want to release a new version. Could you please test http://www.hello-penguin.com/tmp/GSAPI-0.5.tar.gz and edit the Changes-File if needed? ciao - Stefan
  Wed Nov 19 11:48:22 2008 The RT System itself - Status changed from 'new' to 'open'
  Thu Dec 11 16:36:39 2008 perl [...] pied.nu - Correspondence added
Looks good. Only change needed is to remove all mention of Imager. I only used it to test things while developing. Not needed now. -Philip ---------------------------- diff -rub GSAPI-0.5/Makefile.PL GSAPI-0.5-PG/Makefile.PL --- GSAPI-0.5/Makefile.PL 2008-11-18 10:30:37.000000000 -0500 +++ GSAPI-0.5-PG/Makefile.PL 2008-12-11 16:27:40.000000000 -0500 @@ -41,7 +41,7 @@ WriteMakefile( 'NAME' => 'GSAPI', 'VERSION_FROM' => 'GSAPI.pm', # finds $VERSION - 'PREREQ_PM' => { "Imager" }, # e.g., Module::Name => 1.1 + 'PREREQ_PM' => { }, # e.g., Module::Name => 1.1 ($] >= 5.005 ? ## Add these new keywords supported since 5.005 (ABSTRACT_FROM => 'GSAPI.pm', # retrieve abstract from module AUTHOR => 'Stefan Traby <stefan@hello-penguin.com>') : ()), diff -rub GSAPI-0.5/t/20_display.t GSAPI-0.5-PG/t/20_display.t --- GSAPI-0.5/t/20_display.t 2008-11-15 09:34:49.000000000 -0500 +++ GSAPI-0.5-PG/t/20_display.t 2008-12-11 16:27:25.000000000 -0500 @@ -3,8 +3,6 @@ use strict; use warnings; -use Data::Dumper; -use Imager; use Test::More tests => 39; BEGIN { use_ok('GSAPI') };
  Sat Dec 13 10:35:43 2008 stefan [...] hello-penguin.com - Status changed from 'open' to 'resolved'