Skip Menu |

This queue is for tickets about the ACH-Builder CPAN distribution.

Report information
The Basics
Id: 40865
Status: resolved
Priority: 0/
Queue: ACH-Builder

People
Owner: Nobody in particular
Requestors: matthew [...] nocturnal.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.20



Subject: various bugs
Date: Wed, 12 Nov 2008 12:29:57 -0600
To: bug-ACH-Builder [...] rt.cpan.org
From: Matthew Lenz <matthew [...] nocturnal.org>
Tim, I think I've spotted a couple issues you may or may not have known about. 1. batch control record / entry hash. This total should be based on the sum of the entry detail record / receiving rdfi identification (routing number not including the check digit). From what I can see in the code you are including the check digit in your sum. 2. file control record / entry hash. This total should be based on the batch control record / entry hash. From what I can see in the code you are keeping a running total of all the routing numbers across all batches rather than the truncated totals of all the batch entry hashes. 3. your example requires company_name and company_id parameters for creating a new object. This data is used in the batch header record and can change per batch. It looks like you documented adding some setter methods for them but it doesn't look like they were added. Just wanted to give you a heads up on what I found while I was doing research for work. -Matt
Hi, Matt. I have fixed the first two issues, regarding entry hashes being calculated incorrectly, in my branch on github: https://github.com/horsepunchkid/ACH-Builder/ The third issue, allowing company to be set per batch rather than per file, is still open. I'll see if one of the upstream developers can review and merge my changes and put a new release up on CPAN. -Steve
As a reasonable workaround, you can just call set_company_id, set_company_name, and set_company_note before calling make_batch.