Skip Menu |

This queue is for tickets about the Sort-Key-OID CPAN distribution.

Report information
The Basics
Id: 40863
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Sort-Key-OID

People
Owner: salva [...] cpan.org
Requestors: SAPER [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.03
Fixed in: (no value)



Subject: [patch] Constify
Hello, While looking the source of Sort::Key::OID, I saw that str[] can be constified. See attached patch. Regards -- Close the world, txEn eht nepO.
Subject: Sort-Key-OID-0.03-const.diff
diff -ruN Sort-Key-OID-0.03-orig/OID.xs Sort-Key-OID-0.03-new/OID.xs --- Sort-Key-OID-0.03-orig/OID.xs 2008-02-19 10:08:24.000000000 +0100 +++ Sort-Key-OID-0.03-new/OID.xs 2008-11-12 15:27:10.679688268 +0100 @@ -19,7 +19,7 @@ oid = DEFSV; { STRLEN len; - char * str = SvPV(oid, len); + const char * str = SvPV(oid, len); STRLEN rlen = (len + 3) / 2; int i = 0; char *rstr;
done