| Subject: | failing make test by 5.10.0 |
Show quoted text
>uname -a
Linux casper.magi 2.6.26.6-49.fc8 #1 SMP Fri Oct 17 15:33:32 EDT 2008
x86_64 x86_64 x86_64 GNU/Linux
Show quoted text> perl -v
This is perl, v5.10.0 built for x86_64-linux-thread-multi
Copyright 1987-2007, Larry Wall
Perl may be copied only under the terms of either the Artistic License
or the
GNU General Public License, which may be found in the Perl 5 source kit.
Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl". If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.
Show quoted text> perl Makefile.PL && make && make test
Checking if your kit is complete...
Looks good
Writing Makefile for Hatena::Keyword
cp lib/Hatena/Keyword.pm blib/lib/Hatena/Keyword.pm
Manifying blib/man3/Hatena::Keyword.3
PERL_DL_NONLAZY=1 /usr/local/perl/5.10.0/bin/perl
"-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib',
'blib/arch')" t/*.t
t/00-load.........1/1 # Testing Hatena::Keyword 0.05, Perl 5.010000,
/usr/local/perl/5.10.0/bin/perl
t/00-load.........ok
t/01-methods......22/25 HTTP::Message content must be bytes at
/usr/local/perl/5.10.0/lib/site_perl/5.10.0/RPC/XML/Client.pm line 308
# Looks like you planned 25 tests but ran 23.
# Looks like your test exited with 255 just after 23.
t/01-methods...... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/25 subtests
t/02-caching......ok
t/boilerplate.....ok
t/pod-coverage....ok
t/pod.............ok
Test Summary Report
-------------------
t/01-methods (Wstat: 65280 Tests: 23 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 25 tests but ran 23.
Files=6, Tests=39, 2 wallclock secs ( 0.03 usr 0.02 sys + 0.56 cusr
0.13 csys = 0.74 CPU)
Result: FAIL
Failed 1/6 test programs. 0/39 subtests failed.
make: *** [test_dynamic] Error 255
----
patch
----
Show quoted text>diff -ru Hatena-Keyword-0.05.original Hatena-Keyword-0.05
diff -ru Hatena-Keyword-0.05.original/lib/Hatena/Keyword.pm
Hatena-Keyword-0.05/lib/Hatena/Keyword.pm
--- Hatena-Keyword-0.05.original/lib/Hatena/Keyword.pm 2008-02-21
12:11:59.000000000 +0900
+++ Hatena-Keyword-0.05/lib/Hatena/Keyword.pm 2008-11-04
08:46:16.313820699 +0900
@@ -4,6 +4,7 @@
use base qw(Class::Data::Inheritable Class::Accessor::Fast
Class::ErrorHandler);
use overload '""' => \&as_string, fallback => 1;
use Carp;
+use Encode;
use URI;
use RPC::XML;
use RPC::XML::Client;
@@ -41,7 +42,8 @@
sub _call_rpc_with_cache {
my $class = shift;
my ($body, $args) = @_;
- $body = pack('C0A*', $body); # hacking for utf-8 flag
+# $body = pack('C0A*', $body); # hacking for utf-8 flag
+ $body = encode("utf-8", $body); # for perl 5.10
my $cache = delete $args->{cache};
return $class->_call_rpc($body, $args) unless ref($cache);
croak "cache object must have get and set method."