Bug #40604 for DBD-Pg: LC_MESSAGES setting in tests

Sun Nov 02 15:14:11 2008 lamprecht [...] cpan.org - Ticket created

Hi, trying to build DBD::Pg I got failing tests because of a non standard LC_MESSAGES locale: t/02attribs.........209/249 # Failed test 'Database handle attribute "ReadOnly" prevents INSERT queries from working when on' # at t/02attribs.t line 1483. # 'DBD::Pg::db do failed: FEHLER: Transaktion ist Read-Only at t/02attribs.t line 1482. # ' # doesn't match '(?-xism:transaction is read-only)' This could be easily solved by setting LC_MESSAGES to 'C' explicitly. Patch against dbdpg_test_setup.pl attached Regards, Christoph Lamprecht

Subject:

dbdpg_test_setup.diff

--- dbdpg_test_setup_ori.pl 2008-11-02 21:01:31.000000000 +0100 +++ dbdpg_test_setup.pl 2008-11-02 21:00:04.000000000 +0100 @@ -536,6 +536,7 @@ $dbh->{Warn} = 0; $dbh->do($SQL); $dbh->{Warn} = 1; + $dbh->do(q/SET LC_MESSAGES = 'C'/); $dbh->do(q{COMMENT ON COLUMN dbd_pg_test.id IS 'Bob is your uncle'}); } ## end setup

Sun Nov 02 15:19:02 2008 lamprecht [...] cpan.org - Reminder 'LC_MESSAGES setting in tests' added

Sun Nov 02 15:19:56 2008 lamprecht [...] cpan.org - Subject changed from (no value) to 'LC_MESSAGES setting in tests'

Mon Nov 03 07:59:59 2008 greg [...] turnstep.com - Taken

Mon Nov 03 08:52:50 2008 greg [...] turnstep.com - Correspondence added

Show quoted text

> This could be easily solved by setting LC_MESSAGES to 'C' explicitly.

Thanks, great idea. I put this in dbdpg_test_setup.pl as there are a couple other tests caught by the same problem. Committed to subversion and now a part of 2.11.3.

Mon Nov 03 08:52:52 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 04 10:55:48 2008 greg [...] turnstep.com - Fixed in 2.11.3 added

Tue Nov 04 10:55:49 2008 greg [...] turnstep.com - Broken in 2.11.2 deleted

Tue Nov 04 10:55:49 2008 greg [...] turnstep.com - Status changed from 'open' to 'resolved'

Wed Nov 12 10:49:16 2008 david [...] dawninglight.net - Correspondence added

From:

david [...] dawninglight.net

On Mon Nov 03 08:52:50 2008, greg@turnstep.com wrote: Show quoted text

> > This could be easily solved by setting LC_MESSAGES to 'C' explicitly.

> > Thanks, great idea. I put this in dbdpg_test_setup.pl as there are a > couple other tests caught by the same problem. Committed to subversion > and now a part of 2.11.3.

Unfortunately, this breaks if the tests are not run as a db superuser. David Blewett

Wed Nov 12 10:49:17 2008 The RT System itself - Status changed from 'resolved' to 'open'

Wed Nov 12 11:16:05 2008 greg [...] turnstep.com - Correspondence added

Show quoted text

> Unfortunately, this breaks if the tests are not run as a db superuser.

Thanks, will fix.

Wed Nov 12 14:44:28 2008 ch.l.ngre [...] online.de - Correspondence added

Subject:	Re: [rt.cpan.org #40604] LC_MESSAGES setting in tests
Date:	Wed, 12 Nov 2008 20:44:08 +0100
To:	bug-DBD-Pg [...] rt.cpan.org
From:	Ch Lamprecht <ch.l.ngre [...] online.de>

Greg Sabino Mullane via RT schrieb: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=40604 > >

>> Unfortunately, this breaks if the tests are not run as a db superuser.

> > Thanks, will fix.

Maybe it would be better to check for errorcodes instead of messages? Christoph

Wed Nov 12 15:24:45 2008 greg [...] turnstep.com - Correspondence added

Show quoted text

> Maybe it would be better to check for errorcodes instead of messages?

In most cases, the codes are far too generic to be of any use much beyond "error or no error", but I'll check if any can be used for the current checks.

Wed Nov 12 15:39:54 2008 greg [...] turnstep.com - Correspondence added

I stand corrected, we can use the sqlstate codes for all the language-specific tests in question. Thanks! Will be part of version 2.11.4, to be released today.

Thu Nov 13 10:36:55 2008 greg [...] turnstep.com - Fixed in 2.11.4 added

Thu Nov 13 10:36:58 2008 greg [...] turnstep.com - Fixed in 2.11.3 deleted

Thu Nov 13 10:36:58 2008 greg [...] turnstep.com - Status changed from 'open' to 'resolved'